Skip to content

Modern Docker Management, Designed for Everyone

chore: update errors in build service

Kyle Mendell3248945370d6
diff --git a/backend/internal/services/build_service.go b/backend/internal/services/build_service.go
index aee66bf45..cb52c63c2 100644
--- a/backend/internal/services/build_service.go
+++ b/backend/internal/services/build_service.go
@@ -253,7 +253,7 @@ func (s *BuildService) cloneGitContextInternal(ctx context.Context, repositoryUR
return s.gitRepository.gitClient.Clone(ctx, repositoryURL, ref, authConfig)
}
- return buildgit.NewClient("").Clone(ctx, repositoryURL, ref, authConfig)
+ return "", errors.New("git repository service not available")
}
func (s *BuildService) cleanupGitContextInternal(repoPath string) error {
@@ -266,7 +266,7 @@ func (s *BuildService) cleanupGitContextInternal(repoPath string) error {
if s.gitRepository != nil && s.gitRepository.gitClient != nil {
return s.gitRepository.gitClient.Cleanup(repoPath)
}
- return buildgit.NewClient("").Cleanup(repoPath)
+ return errors.New("git repository service not available")
}
func writeBuildProgressStatusInternal(progressWriter io.Writer, serviceName, status string) {
diff --git a/backend/internal/services/build_service_test.go b/backend/internal/services/build_service_test.go
index bd8ba2b87..8a5057e96 100644
--- a/backend/internal/services/build_service_test.go
+++ b/backend/internal/services/build_service_test.go
@@ -143,6 +143,20 @@ func TestBuildService_ResolveBuildRequest_RejectsUnsupportedRemoteContext(t *tes
require.NoError(t, cleanup())
}
+func TestBuildService_ResolveBuildRequest_RequiresGitRepositoryServiceForRemoteContext(t *testing.T) {
+ svc := &BuildService{}
+
+ _, cleanup, err := svc.resolveBuildRequestInternal(
+ context.Background(),
+ image.BuildRequest{ContextDir: "https://github.com/getarcaneapp/arcane.git#main"},
+ nil,
+ "",
+ )
+ require.Error(t, err)
+ assert.Contains(t, err.Error(), "git repository service not available")
+ require.NoError(t, cleanup())
+}
+
func TestBuildService_ResolveBuildRequest_UsesSavedGitCredentials(t *testing.T) {
_, db := setupImageServiceAuthTest(t)
require.NoError(t, db.AutoMigrate(&models.GitRepository{}))