Modern Docker Management, Designed for Everyone
Go composecontainer-managementcontainersdockerdocker-composedocker-managementgoself-hostedsveltekittypescriptweb-ui
fix: image pulling not repecting user defined tag
Kyle Mendell41af2909f79b
diff --git a/src/routes/api/images/pull-stream/[...name]/+server.ts b/src/routes/api/images/pull-stream/[...name]/+server.tsindex 409af8a4a..a14914633 100644--- a/src/routes/api/images/pull-stream/[...name]/+server.ts+++ b/src/routes/api/images/pull-stream/[...name]/+server.ts@@ -1,8 +1,12 @@import type { RequestHandler } from './$types';import { getDockerClient } from '$lib/services/docker/core';+import { URL } from 'url'; // Import URLexport const GET: RequestHandler = async ({ params, request }) => {- const imageRef = params.name;+ const imageName = params.name;+ const url = new URL(request.url);+ const tag = url.searchParams.get('tag') || 'latest';+ const platform = url.searchParams.get('platform');// Set up SSE headersconst headers = new Headers({@@ -20,7 +24,16 @@ export const GET: RequestHandler = async ({ params, request }) => {controller.enqueue(new TextEncoder().encode(`data: ${JSON.stringify(data)}\n\n`));}- const pullStream = await docker.pull(imageRef);+ const fullImageRef = `${imageName}:${tag}`;++ // Construct pull options+ const pullOptions: { platform?: string } = {};+ if (platform) {+ pullOptions.platform = platform;+ }++ // Pass options to docker.pull+ const pullStream = await docker.pull(fullImageRef, pullOptions);let layers: Record<string, any> = {};let totalProgress = 0;@@ -61,8 +74,12 @@ export const GET: RequestHandler = async ({ params, request }) => {totalProgress = Math.min(99, Math.floor((currentProgress / totalSize) * 100));send({ progress: totalProgress, status: event.status });} else {- send({ progress: 5, status: event.status });+ // Send initial status even if progress can't be calculated yet+ send({ progress: 0, status: event.status });}+ } else if (event.status) {+ // Send status updates that don't have layer progress+ send({ status: event.status });}});diff --git a/src/routes/images/pull-image-dialog.svelte b/src/routes/images/pull-image-dialog.svelteindex a48a9c639..67cc1fb88 100644--- a/src/routes/images/pull-image-dialog.svelte+++ b/src/routes/images/pull-image-dialog.svelte@@ -44,7 +44,7 @@if (!imageRef.trim()) return;let urlPath = imageRef.trim();- let imageTag = tag || 'latest';+ let imageTag = tag.trim();if (urlPath.includes(':')) {const parts = urlPath.split(':');