Skip to content

Modern Docker Management, Designed for Everyone

fix: run bulk project updates sequentially (#4524)

Kyle Mendell4c98ef8f3938
diff --git a/frontend/src/routes/(app)/updates/components/project-updates-table.svelte b/frontend/src/routes/(app)/updates/components/project-updates-table.svelte
index 8004cffad..851414a94 100644
--- a/frontend/src/routes/(app)/updates/components/project-updates-table.svelte
+++ b/frontend/src/routes/(app)/updates/components/project-updates-table.svelte
@@ -156,7 +156,8 @@
},
setLoading: (loading) => (bulkUpdating = loading),
onComplete: () => onRefreshData(requestOptions),
- clearSelection: () => (selectedIds = [])
+ clearSelection: () => (selectedIds = []),
+ sequential: true
});
}
diff --git a/tests/spec/updates.spec.ts b/tests/spec/updates.spec.ts
index 853f3f42f..9c9a2bae0 100644
--- a/tests/spec/updates.spec.ts
+++ b/tests/spec/updates.spec.ts
@@ -899,12 +899,17 @@ test.describe('Arcane upgrades', () => {
await registerTokenSeeding(page);
let refreshCalls = 0;
+ let releaseRefresh!: () => void;
+ const refreshReleased = new Promise<void>((resolve) => {
+ releaseRefresh = resolve;
+ });
await page.route(/\/api\/auth\/refresh$/, async (route) => {
refreshCalls++;
if (refreshCalls === 1) {
await route.abort('connectionfailed');
return;
}
+ await refreshReleased;
await route.fulfill({
status: 200,
headers: {
@@ -933,15 +938,24 @@ test.describe('Arcane upgrades', () => {
});
});
- await page.goto('/environments');
- await openAndConfirmUpdateAll(page);
+ try {
+ await page.goto('/environments');
+ await openAndConfirmUpdateAll(page);
- await expect.poll(() => refreshCalls, { timeout: 10_000 }).toBe(1);
- await expect
- .poll(() => page.evaluate((key: string) => localStorage.getItem(key), TOKEN_EXPIRY_KEY))
- .not.toBeNull();
- await expect.poll(() => currentReloadCount(page), { timeout: 15_000 }).toBe(2);
- expect(refreshCalls).toBe(2);
+ await expect.poll(() => refreshCalls, { timeout: 15_000 }).toBe(2);
+ expect(
+ await page.evaluate((key: string) => localStorage.getItem(key), TOKEN_EXPIRY_KEY)
+ ).not.toBeNull();
+ expect(currentReloadCount(page)).toBe(1);
+ await expect(page).toHaveURL('/environments');
+ releaseRefresh();
+
+ await expect.poll(() => currentReloadCount(page), { timeout: 15_000 }).toBe(2);
+ expect(refreshCalls).toBe(2);
+ await expect(page).toHaveURL('/environments');
+ } finally {
+ releaseRefresh();
+ }
});
test('a rejected refresh during an upgrade redirects to login instead of polling', async ({