Skip to content

Modern Docker Management, Designed for Everyone

fix: unable to update existing users usernames

Kyle Mendell5ab4294895e7
diff --git a/backend/internal/huma/handlers/users.go b/backend/internal/huma/handlers/users.go
index efd0a2085..7b321cd9e 100644
--- a/backend/internal/huma/handlers/users.go
+++ b/backend/internal/huma/handlers/users.go
@@ -276,6 +276,9 @@ func (h *UserHandler) UpdateUser(ctx context.Context, input *UpdateUserInput) (*
return nil, huma.Error404NotFound((&common.UserNotFoundError{}).Error())
}
+ if input.Body.Username != nil {
+ userModel.Username = *input.Body.Username
+ }
if input.Body.DisplayName != nil {
userModel.DisplayName = input.Body.DisplayName
}
diff --git a/frontend/src/lib/components/sheets/user-form-sheet.svelte b/frontend/src/lib/components/sheets/user-form-sheet.svelte
index 4dfac4f97..9e8db69c5 100644
--- a/frontend/src/lib/components/sheets/user-form-sheet.svelte
+++ b/frontend/src/lib/components/sheets/user-form-sheet.svelte
@@ -3,7 +3,6 @@
import { ArcaneButton } from '$lib/components/arcane-button/index.js';
import FormInput from '$lib/components/form/form-input.svelte';
import SwitchWithLabel from '$lib/components/form/labeled-switch.svelte';
- import { Spinner } from '$lib/components/ui/spinner/index.js';
import type { User } from '$lib/types/user.type';
import { z } from 'zod/v4';
import { createForm, preventDefault } from '$lib/utils/form.utils';
@@ -30,7 +29,6 @@
let isEditMode = $derived(!!userToEdit);
let canEditUsername = $derived(!isEditMode || allowUsernameEdit);
- let SubmitIcon = $derived(isEditMode ? SaveIcon : AddIcon);
let isOidcUser = $derived(!!userToEdit?.oidcSubjectId);
@@ -72,8 +70,8 @@
roles: [data.isAdmin ? 'admin' : 'user']
};
- // Only include username if we're creating a new user
- if (!isEditMode) {
+ // Only include username if we're creating a new user or if editing is allowed
+ if (!isEditMode || canEditUsername) {
userData.username = data.username;
}
diff --git a/frontend/src/routes/(app)/settings/users/+page.svelte b/frontend/src/routes/(app)/settings/users/+page.svelte
index 312ded1e8..055782db8 100644
--- a/frontend/src/routes/(app)/settings/users/+page.svelte
+++ b/frontend/src/routes/(app)/settings/users/+page.svelte
@@ -149,6 +149,7 @@
roles={[]}
onSubmit={handleUserSubmit}
isLoading={isLoading.editing}
+ allowUsernameEdit={true}
/>
{/snippet}
</SettingsPageLayout>
diff --git a/types/user/user.go b/types/user/user.go
index aadc56fe6..8b3c7b679 100644
--- a/types/user/user.go
+++ b/types/user/user.go
@@ -12,6 +12,7 @@ type CreateUser struct {
// UpdateUser represents the request body for updating a user.
type UpdateUser struct {
+ Username *string `json:"username,omitempty" minLength:"1" maxLength:"255" doc:"Username of the user"`
DisplayName *string `json:"displayName,omitempty" maxLength:"255" doc:"Display name of the user"`
Email *string `json:"email,omitempty" format:"email" doc:"Email address of the user"`
Roles []string `json:"roles,omitempty" doc:"Roles assigned to the user"`