Skip to content

Modern Docker Management, Designed for Everyone

fix: check for image locally before pulling when deploying project

Kyle Mendell7269ece30728
diff --git a/backend/internal/services/image_service.go b/backend/internal/services/image_service.go
index a338972b3..7c6ed7f29 100644
--- a/backend/internal/services/image_service.go
+++ b/backend/internal/services/image_service.go
@@ -172,6 +172,27 @@ func (s *ImageService) PullImage(ctx context.Context, imageName string, progress
return nil
}
+// ImageExistsLocally checks if an image reference exists in the local Docker daemon.
+// Returns (true, nil) if found, (false, nil) if not found, or (false, err) for unexpected errors.
+func (s *ImageService) ImageExistsLocally(ctx context.Context, imageName string) (bool, error) {
+ dockerClient, err := s.dockerService.CreateConnection(ctx)
+ if err != nil {
+ return false, fmt.Errorf("failed to connect to Docker: %w", err)
+ }
+ defer dockerClient.Close()
+
+ _, err = dockerClient.ImageInspect(ctx, imageName)
+ if err == nil {
+ return true, nil
+ }
+
+ errLower := strings.ToLower(err.Error())
+ if strings.Contains(errLower, "no such image") || strings.Contains(errLower, "not found") {
+ return false, nil
+ }
+ return false, fmt.Errorf("failed to inspect image %s: %w", imageName, err)
+}
+
func (s *ImageService) getPullOptionsWithAuth(ctx context.Context, imageRef string, externalCreds []dto.ContainerRegistryCredential) (image.PullOptions, error) {
pullOptions := image.PullOptions{}
diff --git a/backend/internal/services/project_service.go b/backend/internal/services/project_service.go
index b4139cc03..de44d26d3 100644
--- a/backend/internal/services/project_service.go
+++ b/backend/internal/services/project_service.go
@@ -524,8 +524,8 @@ func (s *ProjectService) DeployProject(ctx context.Context, projectID string, us
return fmt.Errorf("failed to update project status to deploying: %w", err)
}
- if perr := s.PullProjectImages(ctx, projectID, io.Discard); perr != nil {
- slog.Warn("pre-pull images failed (continuing to compose up)", "projectID", projectID, "error", perr)
+ if perr := s.EnsureProjectImagesPresent(ctx, projectID, io.Discard); perr != nil {
+ slog.Warn("ensure images present failed (continuing to compose up)", "projectID", projectID, "error", perr)
}
if err := projects.ComposeUp(ctx, project, project.Services.GetProfiles()); err != nil {
@@ -730,6 +730,53 @@ func (s *ProjectService) PullProjectImages(ctx context.Context, projectID string
return nil
}
+// EnsureProjectImagesPresent checks all compose service images for the project and
+// only pulls images that are not already available locally.
+func (s *ProjectService) EnsureProjectImagesPresent(ctx context.Context, projectID string, progressWriter io.Writer) error {
+ proj, err := s.GetProjectFromDatabaseByID(ctx, projectID)
+ if err != nil {
+ return err
+ }
+
+ // Get configured projects directory from settings
+ projectsDirSetting := s.settingsService.GetStringSetting(ctx, "projectsDirectory", "data/projects")
+ projectsDirectory, pdErr := fs.GetProjectsDirectory(ctx, strings.TrimSpace(projectsDirSetting))
+ if pdErr != nil {
+ slog.WarnContext(ctx, "unable to determine projects directory; using default", "error", pdErr)
+ projectsDirectory = "data/projects"
+ }
+
+ compProj, _, lerr := projects.LoadComposeProjectFromDir(ctx, proj.Path, normalizeComposeProjectName(proj.Name), projectsDirectory)
+ if lerr != nil {
+ return fmt.Errorf("failed to load compose project: %w", lerr)
+ }
+
+ images := map[string]struct{}{}
+ for _, svc := range compProj.Services {
+ img := strings.TrimSpace(svc.Image)
+ if img == "" {
+ continue
+ }
+ images[img] = struct{}{}
+ }
+
+ for img := range images {
+ exists, ierr := s.imageService.ImageExistsLocally(ctx, img)
+ if ierr != nil {
+ slog.WarnContext(ctx, "failed to check local image existence", "image", img, "error", ierr)
+ // Non-fatal: attempt to pull to be safe
+ }
+ if exists {
+ slog.DebugContext(ctx, "image already present locally; skipping pull", "image", img)
+ continue
+ }
+ if err := s.imageService.PullImage(ctx, img, progressWriter, systemUser, nil); err != nil {
+ return fmt.Errorf("failed to pull missing image %s: %w", img, err)
+ }
+ }
+ return nil
+}
+
func (s *ProjectService) RestartProject(ctx context.Context, projectID string, user models.User) error {
proj, err := s.GetProjectFromDatabaseByID(ctx, projectID)
if err != nil {
diff --git a/docker/Dockerfile.dev b/docker/Dockerfile.dev
index 114242d19..b4354dff2 100644
--- a/docker/Dockerfile.dev
+++ b/docker/Dockerfile.dev
@@ -1,6 +1,5 @@
# Development Dockerfile with hot reload support
ARG NODE_VERSION="24"
-ARG GO_VERSION="1.25"
# Stage 1: Frontend Development
FROM node:${NODE_VERSION}-alpine AS frontend-dev
@@ -23,7 +22,7 @@ EXPOSE 3000
CMD ["pnpm", "-C", "frontend", "dev", "--host", "0.0.0.0"]
# Stage 2: Backend Development
-FROM golang:${GO_VERSION}-alpine AS backend-dev
+FROM golang:1.25-alpine AS backend-dev
# Install development tools and dependencies
RUN apk add --no-cache \
diff --git a/frontend/src/lib/components/progress-popover.svelte b/frontend/src/lib/components/progress-popover.svelte
index 7d7d3988b..3f09d9bdf 100644
--- a/frontend/src/lib/components/progress-popover.svelte
+++ b/frontend/src/lib/components/progress-popover.svelte
@@ -60,7 +60,7 @@
{@render children()}
</Popover.Trigger>
- <Popover.Content class={cn('bg-popover w-80 rounded-md border p-4 shadow-md', className)} {align} {sideOffset}>
+ <Popover.Content class={cn('bg-popover/20 w-80 backdrop-blur-md', className)} {align} {sideOffset}>
<div class="space-y-3">
{@render headerSection()}
{@render contentSection()}