Skip to content

Modern Docker Management, Designed for Everyone

fix: git builds not ending in .git fail (#2248)

Kyle Mendell7d2160969e98
diff --git a/backend/internal/services/build_service.go b/backend/internal/services/build_service.go
index 169c14b32..3d5678fc2 100644
--- a/backend/internal/services/build_service.go
+++ b/backend/internal/services/build_service.go
@@ -30,6 +30,7 @@ type BuildService struct {
registryService *ContainerRegistryService
gitRepository *GitRepositoryService
builder buildtypes.Builder
+ gitProbeFn func(context.Context, string, buildgit.AuthConfig) error
gitCloneFn func(context.Context, string, string, buildgit.AuthConfig) (string, error)
gitCleanupFn func(string) error
}
@@ -190,6 +191,12 @@ func (s *BuildService) resolveBuildRequestInternal(
if matchedRepository {
writeBuildProgressStatusInternal(progressWriter, serviceName, fmt.Sprintf("using saved git credentials for %s", source.RepositoryURL))
}
+ if libbuild.RequiresGitRemoteProbe(source.RepositoryURL) {
+ writeBuildProgressStatusInternal(progressWriter, serviceName, fmt.Sprintf("verifying remote git repository %s", source.RepositoryURL))
+ if err := s.probeGitContextInternal(ctx, source.RepositoryURL, authConfig); err != nil {
+ return imagetypes.BuildRequest{}, func() error { return nil }, fmt.Errorf("failed to verify remote git repository %q: %w", source.RepositoryURL, err)
+ }
+ }
repoPath, err := s.cloneGitContextInternal(ctx, source.RepositoryURL, source.Ref, authConfig)
if err != nil {
@@ -244,6 +251,18 @@ func (s *BuildService) resolveGitBuildAuthInternal(ctx context.Context, rawURL s
return authConfig, true, nil
}
+func (s *BuildService) probeGitContextInternal(ctx context.Context, repositoryURL string, authConfig buildgit.AuthConfig) error {
+ if s.gitProbeFn != nil {
+ return s.gitProbeFn(ctx, repositoryURL, authConfig)
+ }
+
+ if s.gitRepository != nil && s.gitRepository.gitClient != nil {
+ return s.gitRepository.gitClient.ProbeRemote(ctx, repositoryURL, authConfig)
+ }
+
+ return errors.New("git repository service not available")
+}
+
func (s *BuildService) cloneGitContextInternal(ctx context.Context, repositoryURL, ref string, authConfig buildgit.AuthConfig) (string, error) {
if s.gitCloneFn != nil {
return s.gitCloneFn(ctx, repositoryURL, ref, authConfig)
diff --git a/backend/internal/services/build_service_test.go b/backend/internal/services/build_service_test.go
index 4174f1eb1..9e54a7411 100644
--- a/backend/internal/services/build_service_test.go
+++ b/backend/internal/services/build_service_test.go
@@ -104,6 +104,10 @@ func TestBuildService_ResolveBuildRequest_ClonesRemoteGitContext(t *testing.T) {
cleanupCalled := false
svc := &BuildService{
+ gitProbeFn: func(context.Context, string, buildgit.AuthConfig) error {
+ t.Fatal("git remote probe should not run for .git URLs")
+ return nil
+ },
gitCloneFn: func(_ context.Context, repositoryURL, ref string, auth buildgit.AuthConfig) (string, error) {
assert.Equal(t, "https://github.com/getarcaneapp/arcane.git", repositoryURL)
assert.Equal(t, "main", ref)
@@ -129,17 +133,40 @@ func TestBuildService_ResolveBuildRequest_ClonesRemoteGitContext(t *testing.T) {
assert.True(t, cleanupCalled)
}
-func TestBuildService_ResolveBuildRequest_RejectsUnsupportedRemoteContext(t *testing.T) {
- svc := &BuildService{}
+func TestBuildService_ResolveBuildRequest_ProbesAndClonesRemoteGitContextWithoutGitSuffix(t *testing.T) {
+ repoPath := t.TempDir()
+ require.NoError(t, os.MkdirAll(filepath.Join(repoPath, "docker", "app"), 0o755))
- _, cleanup, err := svc.resolveBuildRequestInternal(
+ probeCalled := false
+ cloneCalled := false
+ svc := &BuildService{
+ gitProbeFn: func(_ context.Context, repositoryURL string, auth buildgit.AuthConfig) error {
+ probeCalled = true
+ assert.Equal(t, "https://git.sr.ht/~jordanreger/nws-alerts", repositoryURL)
+ assert.Equal(t, buildgit.AuthConfig{}, auth)
+ return nil
+ },
+ gitCloneFn: func(_ context.Context, repositoryURL, ref string, auth buildgit.AuthConfig) (string, error) {
+ cloneCalled = true
+ assert.True(t, probeCalled)
+ assert.Equal(t, "https://git.sr.ht/~jordanreger/nws-alerts", repositoryURL)
+ assert.Equal(t, "main", ref)
+ assert.Equal(t, buildgit.AuthConfig{}, auth)
+ return repoPath, nil
+ },
+ gitCleanupFn: func(string) error { return nil },
+ }
+
+ resolvedReq, cleanup, err := svc.resolveBuildRequestInternal(
context.Background(),
- image.BuildRequest{ContextDir: "https://example.com/archive.tar.gz"},
+ image.BuildRequest{ContextDir: "https://git.sr.ht/~jordanreger/nws-alerts#main:docker/app"},
nil,
"",
)
- require.Error(t, err)
- assert.Contains(t, err.Error(), "only git repository URLs are supported")
+ require.NoError(t, err)
+ assert.True(t, probeCalled)
+ assert.True(t, cloneCalled)
+ assert.Equal(t, filepath.Join(repoPath, "docker", "app"), resolvedReq.ContextDir)
require.NoError(t, cleanup())
}
@@ -157,6 +184,32 @@ func TestBuildService_ResolveBuildRequest_RequiresGitRepositoryServiceForRemoteC
require.NoError(t, cleanup())
}
+func TestBuildService_ResolveBuildRequest_RejectsNonGitHTTPContextViaProbeFailure(t *testing.T) {
+ svc := &BuildService{
+ gitProbeFn: func(_ context.Context, repositoryURL string, auth buildgit.AuthConfig) error {
+ assert.Equal(t, "https://example.com/archive.tar.gz", repositoryURL)
+ assert.Equal(t, buildgit.AuthConfig{}, auth)
+ return assert.AnError
+ },
+ gitCloneFn: func(context.Context, string, string, buildgit.AuthConfig) (string, error) {
+ t.Fatal("git clone should not run when remote probe fails")
+ return "", nil
+ },
+ }
+
+ _, cleanup, err := svc.resolveBuildRequestInternal(
+ context.Background(),
+ image.BuildRequest{ContextDir: "https://example.com/archive.tar.gz"},
+ nil,
+ "",
+ )
+ require.Error(t, err)
+ // HTTP(S) URLs without a .git suffix now reach the remote probe step instead of failing suffix validation.
+ assert.Contains(t, err.Error(), "failed to verify remote git repository")
+ assert.Contains(t, err.Error(), "archive.tar.gz")
+ require.NoError(t, cleanup())
+}
+
func TestBuildService_ResolveBuildRequest_UsesSavedGitCredentials(t *testing.T) {
_, db := setupImageServiceAuthTest(t)
require.NoError(t, db.AutoMigrate(&models.GitRepository{}))
@@ -183,7 +236,15 @@ func TestBuildService_ResolveBuildRequest_UsesSavedGitCredentials(t *testing.T)
t.Run("http auth", func(t *testing.T) {
svc := &BuildService{
gitRepository: repoService,
- gitCloneFn: func(_ context.Context, _ string, _ string, auth buildgit.AuthConfig) (string, error) {
+ gitProbeFn: func(_ context.Context, repositoryURL string, auth buildgit.AuthConfig) error {
+ assert.Equal(t, "https://github.com/getarcaneapp/private-build", repositoryURL)
+ assert.Equal(t, "http", auth.AuthType)
+ assert.Equal(t, "builder", auth.Username)
+ assert.Equal(t, "token-123", auth.Token)
+ return nil
+ },
+ gitCloneFn: func(_ context.Context, repositoryURL, _ string, auth buildgit.AuthConfig) (string, error) {
+ assert.Equal(t, "https://github.com/getarcaneapp/private-build", repositoryURL)
assert.Equal(t, "http", auth.AuthType)
assert.Equal(t, "builder", auth.Username)
assert.Equal(t, "token-123", auth.Token)
@@ -194,7 +255,7 @@ func TestBuildService_ResolveBuildRequest_UsesSavedGitCredentials(t *testing.T)
_, cleanup, err := svc.resolveBuildRequestInternal(
context.Background(),
- image.BuildRequest{ContextDir: "https://github.com/getarcaneapp/private-build.git#main"},
+ image.BuildRequest{ContextDir: "https://github.com/getarcaneapp/private-build#main"},
nil,
"",
)
@@ -205,6 +266,10 @@ func TestBuildService_ResolveBuildRequest_UsesSavedGitCredentials(t *testing.T)
t.Run("ssh auth", func(t *testing.T) {
svc := &BuildService{
gitRepository: repoService,
+ gitProbeFn: func(context.Context, string, buildgit.AuthConfig) error {
+ t.Fatal("git remote probe should not run for ssh URLs")
+ return nil
+ },
gitCloneFn: func(_ context.Context, _ string, _ string, auth buildgit.AuthConfig) (string, error) {
assert.Equal(t, "ssh", auth.AuthType)
assert.Equal(t, "ssh-private-key", auth.SSHKey)
diff --git a/backend/internal/services/project_service.go b/backend/internal/services/project_service.go
index 764657d64..a514b757b 100644
--- a/backend/internal/services/project_service.go
+++ b/backend/internal/services/project_service.go
@@ -1777,8 +1777,6 @@ func resolveBuildContextInternal(workingDir string, svc composetypes.ServiceConf
contextDir = workingDir
} else if _, isGitContext, err := libbuild.ParseGitBuildContextSource(contextDir); err != nil {
return "", fmt.Errorf("invalid build context for service %s: %w", serviceName, err)
- } else if libbuild.IsPotentialRemoteBuildContextSource(contextDir) && !isGitContext {
- return "", fmt.Errorf("unsupported remote build context for service %s: only git repository URLs are supported", serviceName)
} else if !isGitContext && !filepath.IsAbs(contextDir) {
contextDir = filepath.Join(workingDir, contextDir)
}
diff --git a/backend/internal/services/project_service_test.go b/backend/internal/services/project_service_test.go
index 43a069cdd..418ec2d62 100644
--- a/backend/internal/services/project_service_test.go
+++ b/backend/internal/services/project_service_test.go
@@ -1669,16 +1669,16 @@ func TestResolveBuildContextInternal_AllowsRemoteGitContext(t *testing.T) {
assert.Equal(t, "https://github.com/getarcaneapp/arcane.git#main:docker/app", contextDir)
}
-func TestResolveBuildContextInternal_RejectsUnsupportedRemoteContext(t *testing.T) {
+func TestResolveBuildContextInternal_AllowsRemoteGitContextWithoutGitSuffix(t *testing.T) {
svc := composetypes.ServiceConfig{
Build: &composetypes.BuildConfig{
- Context: "https://example.com/archive.tar.gz",
+ Context: "https://git.sr.ht/~jordanreger/nws-alerts#main:docker/app",
},
}
- _, err := resolveBuildContextInternal("/projects/demo", svc, "web")
- require.Error(t, err)
- assert.Contains(t, err.Error(), "only git repository URLs are supported")
+ contextDir, err := resolveBuildContextInternal("/projects/demo", svc, "web")
+ require.NoError(t, err)
+ assert.Equal(t, "https://git.sr.ht/~jordanreger/nws-alerts#main:docker/app", contextDir)
}
func TestProjectService_SyncProjectsFromFileSystem_IgnoresSymlinkedProjectDirsWhenDisabled(t *testing.T) {
diff --git a/backend/pkg/gitutil/git.go b/backend/pkg/gitutil/git.go
index 9803fb3c1..379db4bbc 100644
--- a/backend/pkg/gitutil/git.go
+++ b/backend/pkg/gitutil/git.go
@@ -294,30 +294,11 @@ func (c *Client) ListBranches(ctx context.Context, url string, auth AuthConfig)
if err := ctx.Err(); err != nil {
return nil, err
}
- authMethod, err := c.getAuth(auth)
+ refs, err := c.listRemoteReferences(ctx, url, auth)
if err != nil {
return nil, err
}
- // Create a remote without cloning
- rem := git.NewRemote(nil, &config.RemoteConfig{
- Name: "origin",
- URLs: []string{url},
- })
-
- listOptions := &git.ListOptions{}
- if authMethod != nil {
- listOptions.Auth = authMethod
- }
-
- listCtx, cancel := context.WithTimeout(ctx, 60*time.Second)
- defer cancel()
-
- refs, err := rem.ListContext(listCtx, listOptions)
- if err != nil {
- return nil, fmt.Errorf("failed to list remote references: %w", err)
- }
-
var branches []BranchInfo
var defaultBranch string
@@ -363,6 +344,48 @@ func (c *Client) ListBranches(ctx context.Context, url string, auth AuthConfig)
return branches, nil
}
+// ProbeRemote verifies that a remote repository is reachable without cloning it.
+func (c *Client) ProbeRemote(ctx context.Context, url string, auth AuthConfig) error {
+ if err := ctx.Err(); err != nil {
+ return err
+ }
+
+ _, err := c.listRemoteReferences(ctx, url, auth)
+ if err != nil {
+ return err
+ }
+
+ return nil
+}
+
+func (c *Client) listRemoteReferences(ctx context.Context, url string, auth AuthConfig) ([]*plumbing.Reference, error) {
+ authMethod, err := c.getAuth(auth)
+ if err != nil {
+ return nil, err
+ }
+
+ // Create a remote without cloning
+ rem := git.NewRemote(nil, &config.RemoteConfig{
+ Name: "origin",
+ URLs: []string{url},
+ })
+
+ listOptions := &git.ListOptions{}
+ if authMethod != nil {
+ listOptions.Auth = authMethod
+ }
+
+ listCtx, cancel := context.WithTimeout(ctx, 60*time.Second)
+ defer cancel()
+
+ refs, err := rem.ListContext(listCtx, listOptions)
+ if err != nil {
+ return nil, fmt.Errorf("failed to list remote references: %w", err)
+ }
+
+ return refs, nil
+}
+
// ValidatePath ensures the path is safe and doesn't escape the repo
func ValidatePath(repoPath, requestedPath string) error {
// Clean the paths
diff --git a/backend/pkg/libarcane/libbuild/build_context.go b/backend/pkg/libarcane/libbuild/build_context.go
index e7072441d..f98166594 100644
--- a/backend/pkg/libarcane/libbuild/build_context.go
+++ b/backend/pkg/libarcane/libbuild/build_context.go
@@ -73,7 +73,7 @@ func NormalizeGitBuildContextSourceForMatch(raw string) string {
if err != nil || !ok || source == nil {
return ""
}
- return strings.TrimRight(strings.TrimSpace(source.RepositoryURL), "/")
+ return normalizeGitRepositoryURLForMatch(source.RepositoryURL)
}
func IsPotentialRemoteBuildContextSource(raw string) bool {
@@ -82,6 +82,15 @@ func IsPotentialRemoteBuildContextSource(raw string) bool {
return false
}
+ return IsSupportedGitRepositoryURL(trimmed)
+}
+
+func IsSupportedGitRepositoryURL(raw string) bool {
+ trimmed := strings.TrimSpace(raw)
+ if trimmed == "" {
+ return false
+ }
+
if strings.HasPrefix(trimmed, "git@") {
return true
}
@@ -92,34 +101,54 @@ func IsPotentialRemoteBuildContextSource(raw string) bool {
}
switch strings.ToLower(parsed.Scheme) {
- case "http", "https", "ssh", "git":
- return parsed.Host != ""
+ case "git", "ssh":
+ return parsed.Host != "" && hasRepositoryPath(parsed.Path)
+ case "http", "https":
+ return parsed.Host != "" && hasRepositoryPath(parsed.Path)
default:
return false
}
}
-func IsSupportedGitRepositoryURL(raw string) bool {
+func RequiresGitRemoteProbe(raw string) bool {
trimmed := strings.TrimSpace(raw)
- if trimmed == "" {
+ if trimmed == "" || strings.HasPrefix(trimmed, "git@") {
return false
}
- if strings.HasPrefix(trimmed, "git@") {
- return true
- }
-
parsed, err := url.Parse(trimmed)
if err != nil {
return false
}
switch strings.ToLower(parsed.Scheme) {
- case "git", "ssh":
- return true
case "http", "https":
- return strings.HasSuffix(strings.ToLower(parsed.Path), ".git")
+ return parsed.Host != "" && hasRepositoryPath(parsed.Path) && !strings.HasSuffix(strings.ToLower(strings.TrimRight(parsed.Path, "/")), ".git")
default:
return false
}
}
+
+func hasRepositoryPath(rawPath string) bool {
+ trimmedPath := strings.TrimSpace(rawPath)
+ return trimmedPath != "" && trimmedPath != "/"
+}
+
+func normalizeGitRepositoryURLForMatch(raw string) string {
+ trimmed := strings.TrimRight(strings.TrimSpace(raw), "/")
+ if trimmed == "" {
+ return ""
+ }
+
+ if strings.HasPrefix(trimmed, "git@") {
+ return strings.TrimSuffix(trimmed, ".git")
+ }
+
+ parsed, err := url.Parse(trimmed)
+ if err != nil {
+ return strings.TrimSuffix(trimmed, ".git")
+ }
+
+ parsed.Path = strings.TrimSuffix(strings.TrimRight(parsed.Path, "/"), ".git")
+ return parsed.String()
+}
diff --git a/backend/pkg/libarcane/libbuild/build_context_test.go b/backend/pkg/libarcane/libbuild/build_context_test.go
index 201a86ec2..b457351d6 100644
--- a/backend/pkg/libarcane/libbuild/build_context_test.go
+++ b/backend/pkg/libarcane/libbuild/build_context_test.go
@@ -36,8 +36,18 @@ func TestParseGitBuildContextSource(t *testing.T) {
assert.Equal(t, "dev", source.Ref)
})
- t.Run("non git url is ignored", func(t *testing.T) {
- source, ok, err := ParseGitBuildContextSource("https://example.com/archive.tar.gz")
+ t.Run("forge style http url without git suffix", func(t *testing.T) {
+ source, ok, err := ParseGitBuildContextSource("https://git.sr.ht/~jordanreger/nws-alerts#main:docker/app")
+ require.NoError(t, err)
+ require.True(t, ok)
+ require.NotNil(t, source)
+ assert.Equal(t, "https://git.sr.ht/~jordanreger/nws-alerts", source.RepositoryURL)
+ assert.Equal(t, "main", source.Ref)
+ assert.Equal(t, "docker/app", source.Subdir)
+ })
+
+ t.Run("non remote path is ignored", func(t *testing.T) {
+ source, ok, err := ParseGitBuildContextSource("./docker/app")
require.NoError(t, err)
assert.False(t, ok)
assert.Nil(t, source)
@@ -50,3 +60,28 @@ func TestParseGitBuildContextSource(t *testing.T) {
assert.Nil(t, source)
})
}
+
+func TestNormalizeGitBuildContextSourceForMatch(t *testing.T) {
+ assert.Equal(
+ t,
+ "https://github.com/getarcaneapp/arcane",
+ NormalizeGitBuildContextSourceForMatch("https://github.com/getarcaneapp/arcane.git#main"),
+ )
+ assert.Equal(
+ t,
+ "https://github.com/getarcaneapp/arcane",
+ NormalizeGitBuildContextSourceForMatch("https://github.com/getarcaneapp/arcane/"),
+ )
+ assert.Equal(
+ t,
+ "[email protected]:getarcaneapp/arcane",
+ NormalizeGitBuildContextSourceForMatch("[email protected]:getarcaneapp/arcane.git#dev"),
+ )
+}
+
+func TestRequiresGitRemoteProbe(t *testing.T) {
+ assert.True(t, RequiresGitRemoteProbe("https://git.sr.ht/~jordanreger/nws-alerts"))
+ assert.False(t, RequiresGitRemoteProbe("https://github.com/getarcaneapp/arcane.git"))
+ assert.False(t, RequiresGitRemoteProbe("[email protected]:getarcaneapp/arcane.git"))
+ assert.False(t, RequiresGitRemoteProbe("ssh://[email protected]/getarcaneapp/arcane.git"))
+}
diff --git a/frontend/src/routes/(app)/images/builds/+page.svelte b/frontend/src/routes/(app)/images/builds/+page.svelte
index 1ddef3adf..1ef68c882 100644
--- a/frontend/src/routes/(app)/images/builds/+page.svelte
+++ b/frontend/src/routes/(app)/images/builds/+page.svelte
@@ -251,13 +251,14 @@
});
if (!response.ok || !response.body) {
- const errorData = await response.json().catch(() => ({
+ const errorData = (await response.json().catch(() => ({
data: { message: m.build_request_failed() }
- }));
+ }))) as Record<string, unknown>;
+ const errorDataPayload = errorData['data'] as Record<string, unknown> | undefined;
const errorMessage =
- errorData.data?.message ||
- errorData.error ||
- errorData.message ||
+ errorDataPayload?.['message'] ||
+ errorData['error'] ||
+ errorData['message'] ||
m.build_request_failed_http({ status: response.status });
throw new Error(String(errorMessage));
}
@@ -615,7 +616,7 @@
const protocol = parsed.protocol.toLowerCase();
if (protocol === 'ssh:' || protocol === 'git:') return true;
if (protocol === 'http:' || protocol === 'https:') {
- return parsed.pathname.toLowerCase().endsWith('.git');
+ return parsed.pathname !== '/';
}
} catch {
return false;
@@ -658,21 +659,21 @@
if (!data || typeof data !== 'object') {
return { raw: sanitizeLogText(line), isJson: false } satisfies BuildOutputEntry;
}
- const progressDetail = data.progressDetail as Record<string, unknown> | undefined;
+ const progressDetail = data['progressDetail'] as Record<string, unknown> | undefined;
const progress = progressDetail
? {
- current: typeof progressDetail.current === 'number' ? progressDetail.current : undefined,
- total: typeof progressDetail.total === 'number' ? progressDetail.total : undefined
+ current: typeof progressDetail['current'] === 'number' ? progressDetail['current'] : undefined,
+ total: typeof progressDetail['total'] === 'number' ? progressDetail['total'] : undefined
}
: undefined;
return {
raw: sanitizeLogText(line),
isJson: true,
- type: typeof data.type === 'string' ? data.type : undefined,
- status: data.status ? sanitizeLogText(String(data.status)) : undefined,
- id: data.id ? String(data.id) : undefined,
- phase: typeof data.phase === 'string' ? data.phase : undefined,
- error: data.error ? sanitizeLogText(String(data.error)) : undefined,
+ type: typeof data['type'] === 'string' ? data['type'] : undefined,
+ status: data['status'] ? sanitizeLogText(String(data['status'])) : undefined,
+ id: data['id'] ? String(data['id']) : undefined,
+ phase: typeof data['phase'] === 'string' ? data['phase'] : undefined,
+ error: data['error'] ? sanitizeLogText(String(data['error'])) : undefined,
progress
} satisfies BuildOutputEntry;
} catch {
@@ -927,7 +928,7 @@
item.status === 'success' ? 'emerald' : item.status === 'failed' ? 'red' : item.status === 'running' ? 'blue' : 'gray'
})}
title={(item: ImageBuildRecord) => getBuildTitle(item)}
- subtitle={(item: ImageBuildRecord) => ((mobileFieldVisibility.context ?? true) ? item.contextDir : null)}
+ subtitle={(item: ImageBuildRecord) => ((mobileFieldVisibility['context'] ?? true) ? item.contextDir : null)}
badges={[
(item: ImageBuildRecord) => ({
variant: getStatusBadgeVariant(item.status),
@@ -940,28 +941,28 @@
getValue: (item: ImageBuildRecord) => item.tags?.join(', ') || '-',
icon: TagIcon,
iconVariant: 'gray' as const,
- show: mobileFieldVisibility.tags ?? true
+ show: mobileFieldVisibility['tags'] ?? true
},
{
label: m.build_provider(),
getValue: (item: ImageBuildRecord) => item.provider || '-',
icon: SettingsIcon,
iconVariant: 'gray' as const,
- show: mobileFieldVisibility.provider ?? true
+ show: mobileFieldVisibility['provider'] ?? true
},
{
label: m.common_created(),
getValue: (item: ImageBuildRecord) => formatTimestamp(item.createdAt),
icon: ClockIcon,
iconVariant: 'gray' as const,
- show: mobileFieldVisibility.createdAt ?? true
+ show: mobileFieldVisibility['createdAt'] ?? true
},
{
label: m.build_duration_label(),
getValue: (item: ImageBuildRecord) => formatDuration(item.durationMs ?? 0),
icon: ArrowDownIcon,
iconVariant: 'gray' as const,
- show: mobileFieldVisibility.durationMs ?? false
+ show: mobileFieldVisibility['durationMs'] ?? false
}
]}
onclick={(item: ImageBuildRecord) => openBuildDetails(item)}
diff --git a/tests/spec/builds.spec.ts b/tests/spec/builds.spec.ts
index 398e399e6..ade00d741 100644
--- a/tests/spec/builds.spec.ts
+++ b/tests/spec/builds.spec.ts
@@ -153,7 +153,7 @@ test.describe('Build workspace provider flows', () => {
await switchContextMode(page, 'Remote Git');
await page
.locator('#remote-context-url')
- .fill('https://github.com/getarcaneapp/arcane.git#main:docker/app');
+ .fill('https://git.sr.ht/~jordanreger/nws-alerts#main:docker/app');
await setRequiredBuildInputs(page, `e2e/remote:${Date.now()}`);
let buildPayload: Record<string, unknown> | null = null;
@@ -170,7 +170,7 @@ test.describe('Build workspace provider flows', () => {
await expect.poll(() => buildPayload, { timeout: 10000 }).not.toBeNull();
expect(buildPayload?.contextDir).toBe(
- 'https://github.com/getarcaneapp/arcane.git#main:docker/app'
+ 'https://git.sr.ht/~jordanreger/nws-alerts#main:docker/app'
);
});