Skip to content

Modern Docker Management, Designed for Everyone

chore: service worker caching tweaks

Kyle Mendell86057f1c9697
diff --git a/backend/frontend/frontend.go b/backend/frontend/frontend.go
index f419061f0..c64141b8a 100644
--- a/backend/frontend/frontend.go
+++ b/backend/frontend/frontend.go
@@ -37,14 +37,6 @@ func RegisterFrontend(router *gin.Engine) error {
return
}
- if path == "/health" {
- c.JSON(http.StatusNotFound, gin.H{
- "success": false,
- "error": "Health endpoint not found",
- })
- return
- }
-
requestedPath := strings.TrimPrefix(path, "/")
if requestedPath == "" {
requestedPath = "index.html"
@@ -84,8 +76,28 @@ func (f *FileServerWithCaching) ServeHTTP(w http.ResponseWriter, r *http.Request
path = "index.html"
}
- // Never cache index.html or service-worker.js - they need to be fresh to detect updates
- if path == "index.html" || path == "service-worker.js" {
+ // Service worker needs correct MIME type and no caching for PWA updates
+ if path == "service-worker.js" {
+ w.Header().Set("Content-Type", "application/javascript; charset=utf-8")
+ w.Header().Set("Cache-Control", "no-cache, no-store, must-revalidate")
+ w.Header().Set("Pragma", "no-cache")
+ w.Header().Set("Expires", "0")
+ http.FileServer(f.root).ServeHTTP(w, r)
+ return
+ }
+
+ // Web manifest needs correct MIME type and no caching for PWA updates
+ if path == "app.webmanifest" {
+ w.Header().Set("Content-Type", "application/manifest+json; charset=utf-8")
+ w.Header().Set("Cache-Control", "no-cache, no-store, must-revalidate")
+ w.Header().Set("Pragma", "no-cache")
+ w.Header().Set("Expires", "0")
+ http.FileServer(f.root).ServeHTTP(w, r)
+ return
+ }
+
+ // Never cache index.html - it needs to be fresh to detect updates
+ if path == "index.html" {
w.Header().Set("Cache-Control", "no-cache, no-store, must-revalidate")
w.Header().Set("Pragma", "no-cache")
w.Header().Set("Expires", "0")
diff --git a/frontend/src/service-worker.ts b/frontend/src/service-worker.ts
index d7ddb36b6..ac6be7783 100644
--- a/frontend/src/service-worker.ts
+++ b/frontend/src/service-worker.ts
@@ -7,16 +7,17 @@ import { build, files, version } from '$service-worker';
const self = globalThis.self as unknown as ServiceWorkerGlobalScope;
+const DATA_CACHE = `data-cache-${version}`;
const CACHE = `cache-${version}`;
-const ASSETS = [
- ...build, // the app itself
- ...files // everything in `static`
-];
+const ASSETS = [...build, ...files];
self.addEventListener('install', (event) => {
+ console.log('[ServiceWorker] Install');
+
async function addFilesToCache() {
const cache = await caches.open(CACHE);
+ console.log('[ServiceWorker] Caching app shell');
await cache.addAll(ASSETS);
}
@@ -24,53 +25,59 @@ self.addEventListener('install', (event) => {
});
self.addEventListener('activate', (event) => {
+ console.log('[ServiceWorker] Activate');
+
async function deleteOldCaches() {
- for (const key of await caches.keys()) {
- if (key !== CACHE) await caches.delete(key);
- }
+ const keyList = await caches.keys();
+ await Promise.all(
+ keyList.map((key) => {
+ if (key !== CACHE && key !== DATA_CACHE) {
+ console.log('[ServiceWorker] Removing old cache', key);
+ return caches.delete(key);
+ }
+ })
+ );
}
event.waitUntil(deleteOldCaches());
+ return self.clients.claim();
});
self.addEventListener('fetch', (event) => {
+ console.log('[ServiceWorker] Fetch', event.request.url);
+
if (event.request.method !== 'GET') return;
+ const url = new URL(event.request.url);
+ const isApiRequest = url.pathname.startsWith('/api/');
+
async function respond() {
- const url = new URL(event.request.url);
- const cache = await caches.open(CACHE);
+ if (isApiRequest) {
+ const cache = await caches.open(DATA_CACHE);
+ try {
+ const response = await fetch(event.request);
- // `build`/`files` can always be served from the cache
- if (ASSETS.includes(url.pathname)) {
- const response = await cache.match(url.pathname);
+ if (response.status === 200) {
+ cache.put(event.request, response.clone());
+ }
- if (response) {
return response;
+ } catch (err) {
+ const cachedResponse = await cache.match(event.request);
+ if (cachedResponse) {
+ return cachedResponse;
+ }
+ throw err;
}
- }
-
- // for everything else, try the network first, but
- // fall back to the cache if we're offline
- try {
- const response = await fetch(event.request);
-
- if (!(response instanceof Response)) {
- throw new Error('invalid response from fetch');
- }
+ } else {
+ const cache = await caches.open(CACHE);
+ const cachedResponse = await cache.match(event.request);
- if (response.status === 200) {
- cache.put(event.request, response.clone());
- }
-
- return response;
- } catch (err) {
- const response = await cache.match(event.request);
-
- if (response) {
- return response;
+ if (cachedResponse) {
+ return cachedResponse;
}
- throw err;
+ return fetch(event.request);
}
}