Modern Docker Management, Designed for Everyone
Go composecontainer-managementcontainersdockerdocker-composedocker-managementgoself-hostedsveltekittypescriptweb-ui
perf(build): omit the output column from the build history list query (#3604)
Kyle Mendell8a4bc0f12953
diff --git a/backend/internal/build/service.go b/backend/internal/build/service.goindex 57daf31ae..76dcad151 100644--- a/backend/internal/build/service.go+++ b/backend/internal/build/service.go@@ -405,7 +405,9 @@ func (s *BuildService) ListImageBuildsByEnvironmentPaginated(ctx context.Context}var builds []models.ImageBuild- q := s.db.WithContext(ctx).Model(&models.ImageBuild{}).Where("environment_id = ?", environmentID)+ // The list DTO never includes the build output (buildToRecord with+ // includeOutput=false), so skip reading the up-to-2-MiB output column.+ q := s.db.WithContext(ctx).Model(&models.ImageBuild{}).Omit("output").Where("environment_id = ?", environmentID)if term := strings.TrimSpace(params.Search); term != "" {searchPattern := "%" + term + "%"diff --git a/backend/internal/build/service_test.go b/backend/internal/build/service_test.goindex 62a225fc5..9dd272b2e 100644--- a/backend/internal/build/service_test.go+++ b/backend/internal/build/service_test.go@@ -18,6 +18,7 @@ import ("github.com/getarcaneapp/arcane/backend/v2/internal/gitrepo""github.com/getarcaneapp/arcane/backend/v2/internal/models"buildgit "github.com/getarcaneapp/arcane/backend/v2/pkg/gitutil"+ "github.com/getarcaneapp/arcane/backend/v2/pkg/pagination""github.com/libtnb/sqlite""github.com/stretchr/testify/assert""github.com/stretchr/testify/require"@@ -438,6 +439,34 @@ func (b testBuildRecorder) BuildImage(_ context.Context, req buildtypes.BuildReqreturn &buildtypes.BuildResult{Provider: "local"}, nil}+func TestBuildService_ListImageBuilds_OmitsOutputColumn(t *testing.T) {+ db, err := setupBuildHistoryTestDB()+ require.NoError(t, err)+ svc := &BuildService{db: db}++ output := "large build output"+ require.NoError(t, db.WithContext(context.Background()).Create(&models.ImageBuild{+ BaseModel: models.BaseModel{ID: "build-omit-output"},+ EnvironmentID: "0",+ Status: models.ImageBuildStatusSuccess,+ ContextDir: "/ctx",+ Output: &output,+ }).Error)++ records, _, err := svc.ListImageBuildsByEnvironmentPaginated(context.Background(), "0", pagination.QueryParams{+ Params: pagination.Params{Limit: 10},+ })+ require.NoError(t, err)+ require.Len(t, records, 1)+ assert.Nil(t, records[0].Output)++ // The detail endpoint must still return the stored output.+ detail, err := svc.GetImageBuildByID(context.Background(), "0", "build-omit-output")+ require.NoError(t, err)+ require.NotNil(t, detail.Output)+ assert.Equal(t, output, *detail.Output)+}+func setupBuildHistoryTestDB() (*database.DB, error) {db, err := gorm.Open(sqlite.Open(":memory:"), &gorm.Config{})if err != nil {