Skip to content

Modern Docker Management, Designed for Everyone

fix: password policy not able to be saved

Kyle Mendell976cd831bc06
diff --git a/src/lib/services/settings-service.ts b/src/lib/services/settings-service.ts
index 348552688..bfecb8ac3 100644
--- a/src/lib/services/settings-service.ts
+++ b/src/lib/services/settings-service.ts
@@ -21,7 +21,7 @@ export const DEFAULT_SETTINGS: Settings = {
auth: {
localAuthEnabled: true,
sessionTimeout: 60,
- passwordPolicy: 'medium',
+ passwordPolicy: 'strong',
rbacEnabled: false
}
};
diff --git a/src/lib/stores/settings-store.ts b/src/lib/stores/settings-store.ts
index 5e0474b3e..34a6acd1f 100644
--- a/src/lib/stores/settings-store.ts
+++ b/src/lib/stores/settings-store.ts
@@ -41,7 +41,7 @@ export const settingsStore = writable<Settings>({
auth: {
localAuthEnabled: true,
sessionTimeout: 30,
- passwordPolicy: 'medium',
+ passwordPolicy: 'strong',
rbacEnabled: false
}
});
diff --git a/src/lib/types/settings.type.ts b/src/lib/types/settings.type.ts
index b1446ac79..df8a6da4b 100644
--- a/src/lib/types/settings.type.ts
+++ b/src/lib/types/settings.type.ts
@@ -1,7 +1,7 @@
export interface AuthSettings {
localAuthEnabled: boolean;
sessionTimeout: number;
- passwordPolicy: 'low' | 'medium' | 'high';
+ passwordPolicy: 'basic' | 'standard' | 'strong';
rbacEnabled: boolean;
}
diff --git a/src/routes/api/settings/+server.ts b/src/routes/api/settings/+server.ts
index 02dc0b042..2b4ef9786 100644
--- a/src/routes/api/settings/+server.ts
+++ b/src/routes/api/settings/+server.ts
@@ -129,7 +129,8 @@ export const PUT: RequestHandler = async ({ request }) => {
if (body.auth !== undefined) {
body.auth = {
localAuthEnabled: body.auth.localAuthEnabled ?? currentSettings.auth?.localAuthEnabled ?? true,
- sessionTimeout: body.auth.sessionTimeout ?? currentSettings.auth?.sessionTimeout ?? 60
+ sessionTimeout: body.auth.sessionTimeout ?? currentSettings.auth?.sessionTimeout ?? 60,
+ passwordPolicy: body.auth.passwordPolicy ?? currentSettings.auth?.passwordPolicy ?? 'strong'
};
} else if (currentSettings.auth) {
// Keep current auth settings if not provided in update
diff --git a/src/routes/api/users/+server.ts b/src/routes/api/users/+server.ts
index d64696348..1bc959309 100644
--- a/src/routes/api/users/+server.ts
+++ b/src/routes/api/users/+server.ts
@@ -53,7 +53,7 @@ export const POST: RequestHandler = async ({ request, locals }) => {
// Get password policy from settings
const settings = await getSettings();
- const policy = settings.auth?.passwordPolicy || 'medium';
+ const policy = settings.auth?.passwordPolicy || 'strong';
// Validate password according to policy
if (!validatePassword(password, policy)) {
@@ -89,13 +89,13 @@ export const POST: RequestHandler = async ({ request, locals }) => {
};
// Validate password based on policy
-function validatePassword(password: string, policy: 'low' | 'medium' | 'high'): boolean {
+function validatePassword(password: string, policy: 'basic' | 'standard' | 'strong'): boolean {
switch (policy) {
- case 'low':
+ case 'basic':
return password.length >= 8;
- case 'medium':
+ case 'standard':
return password.length >= 10 && /[A-Z]/.test(password) && /[0-9]/.test(password);
- case 'high':
+ case 'strong':
return password.length >= 12 && /[A-Z]/.test(password) && /[0-9]/.test(password) && /[^A-Za-z0-9]/.test(password);
default:
return true;
diff --git a/src/routes/onboarding/settings/+page.svelte b/src/routes/onboarding/settings/+page.svelte
index f4488b3f6..acc963285 100644
--- a/src/routes/onboarding/settings/+page.svelte
+++ b/src/routes/onboarding/settings/+page.svelte
@@ -43,7 +43,7 @@
...(currentSettings.auth || {}),
localAuthEnabled: true,
sessionTimeout: 30,
- passwordPolicy: 'medium' as 'medium' | 'low' | 'high',
+ passwordPolicy: 'strong' as 'basic' | 'standard' | 'strong',
rbacEnabled: false
},
onboarding: {
diff --git a/src/routes/settings/tabs/authentication.svelte b/src/routes/settings/tabs/authentication.svelte
index 19cf35ee0..168407ba9 100644
--- a/src/routes/settings/tabs/authentication.svelte
+++ b/src/routes/settings/tabs/authentication.svelte
@@ -92,50 +92,50 @@
<label for="passwordPolicy" class="text-sm font-medium">Password Policy</label>
<div class="grid grid-cols-3 gap-2">
<Button
- variant={$settingsStore.auth?.passwordPolicy === 'low' ? 'default' : 'outline'}
+ variant={($settingsStore.auth?.passwordPolicy || 'strong') === 'basic' ? 'default' : 'outline'}
class="w-full"
onclick={() => {
settingsStore.update((current) => ({
...current,
auth: {
...current.auth,
- passwordPolicy: 'low'
+ passwordPolicy: 'basic'
}
}));
}}>Basic</Button
>
<Button
- variant={$settingsStore.auth?.passwordPolicy === 'medium' ? 'default' : 'outline'}
+ variant={($settingsStore.auth?.passwordPolicy || 'strong') === 'standard' ? 'default' : 'outline'}
class="w-full"
onclick={() => {
settingsStore.update((current) => ({
...current,
auth: {
...current.auth,
- passwordPolicy: 'medium'
+ passwordPolicy: 'standard'
}
}));
}}>Standard</Button
>
<Button
- variant={$settingsStore.auth?.passwordPolicy === 'high' ? 'default' : 'outline'}
+ variant={($settingsStore.auth?.passwordPolicy || 'strong') === 'strong' ? 'default' : 'outline'}
class="w-full"
onclick={() => {
settingsStore.update((current) => ({
...current,
auth: {
...current.auth,
- passwordPolicy: 'high'
+ passwordPolicy: 'strong'
}
}));
}}>Strong</Button
>
</div>
- <input type="hidden" id="passwordPolicy" name="passwordPolicy" value={$settingsStore.auth?.passwordPolicy} />
+ <input type="hidden" id="passwordPolicy" name="passwordPolicy" value={$settingsStore.auth?.passwordPolicy || 'strong'} />
<p class="text-xs text-muted-foreground mt-1">
- {#if $settingsStore.auth?.passwordPolicy === 'low'}
+ {#if $settingsStore.auth?.passwordPolicy === 'basic'}
Basic: Minimum 8 characters
- {:else if $settingsStore.auth?.passwordPolicy === 'medium'}
+ {:else if $settingsStore.auth?.passwordPolicy === 'standard'}
Standard: Minimum 10 characters, requires mixed case and numbers
{:else}
Strong: Minimum 12 characters, requires mixed case, numbers and special characters