Skip to content

Modern Docker Management, Designed for Everyone

tests: fix volume tests

Kyle Mendella81366741d3c
diff --git a/frontend/.prettierignore b/frontend/.prettierignore
deleted file mode 100644
index 9ad56c287..000000000
--- a/frontend/.prettierignore
+++ /dev/null
@@ -1,8 +0,0 @@
-# Package Managers
-package-lock.json
-pnpm-lock.yaml
-yarn.lock
-
-# Compiled files
-.svelte-kit/
-build/
\ No newline at end of file
diff --git a/frontend/.prettierrc b/frontend/.prettierrc
deleted file mode 100644
index 3f7802c37..000000000
--- a/frontend/.prettierrc
+++ /dev/null
@@ -1,15 +0,0 @@
-{
- "useTabs": true,
- "singleQuote": true,
- "trailingComma": "none",
- "printWidth": 100,
- "plugins": ["prettier-plugin-svelte"],
- "overrides": [
- {
- "files": "*.svelte",
- "options": {
- "parser": "svelte"
- }
- }
- ]
-}
diff --git a/frontend/src/routes/volumes/volume-table.svelte b/frontend/src/routes/volumes/volume-table.svelte
index 34f5e638f..387033c36 100644
--- a/frontend/src/routes/volumes/volume-table.svelte
+++ b/frontend/src/routes/volumes/volume-table.svelte
@@ -210,6 +210,7 @@
<DropdownMenu.Item
variant="destructive"
onclick={() => handleRemoveVolumeConfirm(item.name)}
+ disabled={item.inUse}
>
<Trash2 class="size-4" />
Remove
diff --git a/tests/spec/volumes.spec.ts b/tests/spec/volumes.spec.ts
index 1b0b59bd9..a33b76d69 100644
--- a/tests/spec/volumes.spec.ts
+++ b/tests/spec/volumes.spec.ts
@@ -11,7 +11,6 @@ async function fetchVolumesWithRetry(page: Page, maxRetries = 3): Promise<any[]>
retries++;
console.log(`Attempt ${retries} failed, ${maxRetries - retries} retries left`);
if (retries >= maxRetries) throw error;
- // Wait before retrying
await new Promise((resolve) => setTimeout(resolve, 1000));
}
}
@@ -23,30 +22,56 @@ let realVolumes: any[] = [];
test.beforeEach(async ({ page }) => {
await page.goto('/volumes');
await page.waitForLoadState('networkidle');
+ realVolumes = await fetchVolumesWithRetry(page);
+});
+
+async function setDropdownMenuItemCheckbox(page: Page, label: string, desired: boolean) {
+ const menu = page.locator('[role="menu"]').last();
+ await expect(menu).toBeVisible();
+
+ const desiredValue = desired ? 'true' : 'false';
+
+ for (let attempt = 0; attempt < 5; attempt++) {
+ const item = menu.getByRole('menuitemcheckbox', { name: label });
+
+ await item.waitFor({ state: 'visible' });
- try {
- realVolumes = await fetchVolumesWithRetry(page);
- } catch (error) {
- console.warn('Could not fetch volumes after multiple retries:', error);
- realVolumes = [];
+ const current = (await item.getAttribute('aria-checked')) === 'true';
+ if (current === desired) return;
+
+ await item.focus();
+ await expect(item).toBeFocused();
+
+ await page.waitForTimeout(50);
+
+ await page.keyboard.press(' ');
+
+ try {
+ await expect(item).toHaveAttribute('aria-checked', desiredValue, { timeout: 1000 });
+ return;
+ } catch {
+ continue;
+ }
}
-});
+
+ await expect(menu.getByRole('menuitemcheckbox', { name: label })).toHaveAttribute('aria-checked', desiredValue);
+}
test.describe('Volumes Page', () => {
- test('should display the volumes page title and description', async ({ page }) => {
+ test('Volume Page Display', async ({ page }) => {
await page.goto('/volumes');
await expect(page.getByRole('heading', { name: 'Volumes', level: 1 })).toBeVisible();
await expect(page.getByText('Manage your Docker volumes').first()).toBeVisible();
});
- test('should display stats cards with correct counts', async ({ page }) => {
+ test('Correct Volume Stat Card Counts', async ({ page }) => {
await page.goto('/volumes');
await expect(page.locator('p:has-text("Total Volumes") + p')).toHaveText(realVolumes.length.toString());
});
- test('should display the volume table when volumes exist', async ({ page }) => {
+ test('Tables Displays When Volumes Exist', async ({ page }) => {
await page.goto('/volumes');
await page.waitForLoadState('networkidle');
@@ -58,7 +83,7 @@ test.describe('Volumes Page', () => {
}
});
- test('should open the Create Volume dialog', async ({ page }) => {
+ test('Create Volume Sheet Opens', async ({ page }) => {
await page.goto('/volumes');
await page.waitForLoadState('networkidle');
@@ -67,7 +92,7 @@ test.describe('Volumes Page', () => {
await expect(page.getByText('Create New Volume')).toBeVisible();
});
- test('should display filter dropdown and allow filtering', async ({ page }) => {
+ test('Display Volume Filters', async ({ page }) => {
await page.goto('/volumes');
await page.waitForLoadState('networkidle');
@@ -77,7 +102,7 @@ test.describe('Volumes Page', () => {
await expect(page.getByText('Show Unused Volumes')).toBeVisible();
});
- test('should navigate to volume details on inspect click', async ({ page }) => {
+ test('Inspect Volume', async ({ page }) => {
test.skip(!realVolumes.length, 'No volumes available for inspect test');
await page.goto('/volumes');
@@ -90,36 +115,23 @@ test.describe('Volumes Page', () => {
await expect(page).toHaveURL(new RegExp(`/volumes/.+`));
});
- //Commenting out for now till i fix the table
- // test('should call remove API on row action delete click and confirmation', async ({ page }) => {
- // test.skip(!realVolumes.length, 'No volumes available for remove API test');
-
- // await page.goto('/volumes');
- // await page.waitForLoadState('networkidle');
-
- // const unusedVolume = 'my-app-data';
- // test.skip(!unusedVolume, 'No unused volumes available for deletion test');
-
- // const firstRow = await page.getByRole('row', { name: 'my-app-data' });
- // await firstRow.getByRole('button', { name: 'Open menu' }).click();
-
- // await page.getByRole('menuitem', { name: 'Delete' }).click();
+ test('Remove Volume', async ({ page }) => {
+ await page.goto('/volumes');
+ await page.waitForLoadState('networkidle');
- // await expect(page.getByRole('heading', { name: 'Delete Volume' })).toBeVisible();
+ const firstRow = await page.getByRole('row', { name: 'my-app-data' });
+ await firstRow.getByRole('button', { name: 'Open menu' }).click();
- // const removePromise = page.waitForRequest(
- // (req) => req.url().includes(`/api/volumes/my-app-data`) && req.method() === 'DELETE'
- // );
+ await page.getByRole('menuitem', { name: 'Remove' }).click();
- // await page.locator('button:has-text("Delete")').click();
- // const removeRequest = await removePromise;
+ await expect(page.getByRole('heading', { name: 'Remove Volume' })).toBeVisible();
- // expect(removeRequest).toBeTruthy();
+ await page.locator('button:has-text("Remove")').click();
- // await expect(page.locator('li[data-sonner-toast][data-type="success"] div[data-title]')).toBeVisible();
- // });
+ await expect(page.locator('li[data-sonner-toast][data-type="success"] div[data-title]')).toBeVisible();
+ });
- test('should create volume via form', async ({ page }) => {
+ test('Create Volume', async ({ page }) => {
await page.goto('/volumes');
await page.waitForLoadState('networkidle');
@@ -136,29 +148,21 @@ test.describe('Volumes Page', () => {
).toBeVisible();
});
- test('should disable delete action for volumes in use', async ({ page }) => {
- test.skip(!realVolumes.length, 'No volumes available for in-use test');
-
+ test('Disable remove action when volume is in use', async ({ page }) => {
const volumeInUse = realVolumes.find((vol) => vol.inUse);
- test.skip(!volumeInUse, 'No volumes in use found for test');
await page.goto('/volumes');
await page.waitForLoadState('networkidle');
-
- const volumeRow = page.locator(`tr:has-text("${volumeInUse.Name}")`);
+ const volumeRow = page.locator(`tr:has-text("${volumeInUse.name}")`);
await volumeRow.getByRole('button', { name: 'Open menu' }).click();
- const deleteButton = page.getByRole('menuitem', { name: 'Delete' });
- await expect(deleteButton).toBeDisabled();
+ await expect(page.getByRole('menuitem', { name: 'Remove' })).toBeDisabled();
});
- test('should display correct status badges for volume usage', async ({ page }) => {
- test.skip(!realVolumes.length, 'No volumes available for status badge test');
-
+ test('Display correct volume usage badge', async ({ page }) => {
await page.goto('/volumes');
await page.waitForLoadState('networkidle');
- // Check for "In Use" and "Unused" badges
const usedVolumes = realVolumes.filter((vol) => vol.inUse);
const unusedVolumes = realVolumes.filter((vol) => !vol.inUse);
@@ -171,44 +175,25 @@ test.describe('Volumes Page', () => {
}
});
- test('should filter volumes by usage status', async ({ page }) => {
- test.skip(!realVolumes.length, 'No volumes available for filter test');
-
- const usedVolumes = realVolumes.filter((vol) => vol.inUse);
- const unusedVolumes = realVolumes.filter((vol) => !vol.inUse);
-
- // Skip if we don't have both types
- test.skip(
- usedVolumes.length === 0 || unusedVolumes.length === 0,
- 'Need both used and unused volumes for filter test'
- );
+ test('Filter Volumes by Usage Status', async ({ page }) => {
+ const usedVolumes = realVolumes.filter((v) => v.inUse);
+ const unusedVolumes = realVolumes.filter((v) => !v.inUse);
await page.goto('/volumes');
await page.waitForLoadState('networkidle');
- // Open filter dropdown
+ // Show only Used
await page.locator('button:has-text("Filter")').click();
+ await setDropdownMenuItemCheckbox(page, 'Show Used Volumes', true);
+ await setDropdownMenuItemCheckbox(page, 'Show Unused Volumes', false);
+ await page.keyboard.press('Escape');
+ await expect(page.locator('tbody tr')).toHaveCount(usedVolumes.length);
- // Uncheck "Show Used Volumes"
- await page.getByText('Show Used Volumes').click();
-
- // Close dropdown
+ // Show only Unused
await page.locator('button:has-text("Filter")').click();
-
- // Should only show unused volumes
+ await setDropdownMenuItemCheckbox(page, 'Show Used Volumes', false);
+ await setDropdownMenuItemCheckbox(page, 'Show Unused Volumes', true);
+ await page.keyboard.press('Escape');
await expect(page.locator('tbody tr')).toHaveCount(unusedVolumes.length);
-
- // Open filter dropdown again
- await page.locator('button:has-text("Filter")').click();
-
- // Check "Show Used Volumes" and uncheck "Show Unused Volumes"
- await page.getByText('Show Used Volumes').click();
- await page.getByText('Show Unused Volumes').click();
-
- // Close dropdown
- await page.locator('button:has-text("Filter")').click();
-
- // Should only show used volumes
- await expect(page.locator('tbody tr')).toHaveCount(usedVolumes.length);
});
});
diff --git a/tests/tmp/build-errors.log b/tests/tmp/build-errors.log
deleted file mode 100644
index 05e59854e..000000000
--- a/tests/tmp/build-errors.log
+++ /dev/null
@@ -1 +0,0 @@
-exit status 1
\ No newline at end of file