Skip to content

Modern Docker Management, Designed for Everyone

fix: make update-all dialog list scroll with large fleets

Kyle Mendellb7a619b2c7f8
diff --git a/frontend/src/lib/components/dialogs/update-all-dialog.svelte b/frontend/src/lib/components/dialogs/update-all-dialog.svelte
index 3bc29029c..72858ff2b 100644
--- a/frontend/src/lib/components/dialogs/update-all-dialog.svelte
+++ b/frontend/src/lib/components/dialogs/update-all-dialog.svelte
@@ -265,12 +265,18 @@
// from a dev-guarded callsite.
async function runDebugDemo() {
const wait = (ms: number) => new Promise((resolve) => setTimeout(resolve, ms));
+ // Big enough fleet (10) to exercise the scrolling list (#3655).
const demo: Array<{ name: string; outcome: UpdateAllEnvironmentStatus; to: string; error?: string }> = [
{ name: 'Local Docker', outcome: 'updated', to: 'v0.9.2' },
{ name: 'palladium', outcome: 'updated', to: 'v0.9.2' },
{ name: 'naswidc1.ofkm.us', outcome: 'up_to_date', to: 'v0.9.1' },
{ name: 'ofkm-cloud', outcome: 'skipped_offline', to: '' },
- { name: 'parquetide', outcome: 'failed', to: '', error: 'dial tcp 10.0.0.9:3552: connect: connection refused' }
+ { name: 'parquetide', outcome: 'failed', to: '', error: 'dial tcp 10.0.0.9:3552: connect: connection refused' },
+ { name: 'edge-nuc-01', outcome: 'updated', to: 'v0.9.2' },
+ { name: 'edge-nuc-02', outcome: 'updated', to: 'v0.9.2' },
+ { name: 'hetzner-fsn1', outcome: 'triggered', to: 'v0.9.2' },
+ { name: 'homelab-pi5', outcome: 'up_to_date', to: 'v0.9.1' },
+ { name: 'staging.ofkm.us', outcome: 'updated', to: 'v0.9.2' }
];
job = {
@@ -291,7 +297,7 @@
const starting = job?.results?.[index];
if (phase !== 'running' || !starting) return;
starting.status = 'updating';
- await wait(1400);
+ await wait(700);
// The manager restart is the one moment the reconnecting banner shows.
if (index === 0) {
@@ -407,7 +413,9 @@
{#if totalCount > 0}
<div class="border-t border-border/60">
- <ScrollArea.Root class="max-h-72">
+ <!-- Native scroller: ScrollArea's percentage-height viewport resolves to auto
+ under a max-height-only parent, so it never clips (#3655). -->
+ <div class="max-h-72 overflow-y-auto">
<ul class="divide-y divide-border/50">
{#each results as result (result.environmentId)}
{@const versions = versionLine(result)}
@@ -448,7 +456,7 @@
</li>
{/each}
</ul>
- </ScrollArea.Root>
+ </div>
</div>
{:else}
<div class="flex items-center gap-2 border-t border-border/60 px-6 py-4 text-sm text-muted-foreground">
diff --git a/frontend/src/lib/components/mobile-nav/mobile-nav-sheet.svelte b/frontend/src/lib/components/mobile-nav/mobile-nav-sheet.svelte
index 49c41e6f6..463191bbe 100644
--- a/frontend/src/lib/components/mobile-nav/mobile-nav-sheet.svelte
+++ b/frontend/src/lib/components/mobile-nav/mobile-nav-sheet.svelte
@@ -201,7 +201,12 @@
</Drawer.Content>
</Drawer.Root>
-<UpdateAllDialog bind:open={upgradeCheck.showConfirmDialog} {versionInformation} canConfirm={upgradeCheck.shouldShowUpgrade} />
+<UpdateAllDialog
+ bind:open={upgradeCheck.showConfirmDialog}
+ {versionInformation}
+ canConfirm={upgradeCheck.shouldShowUpgrade}
+ debugDemo={debug}
+/>
<style>
:global(.scrollbar-hide) {
diff --git a/frontend/src/lib/components/sidebar/sidebar-updatebanner.svelte b/frontend/src/lib/components/sidebar/sidebar-updatebanner.svelte
index 7d8665c12..da80642d7 100644
--- a/frontend/src/lib/components/sidebar/sidebar-updatebanner.svelte
+++ b/frontend/src/lib/components/sidebar/sidebar-updatebanner.svelte
@@ -34,7 +34,12 @@
);
</script>
-<UpdateAllDialog bind:open={upgradeCheck.showConfirmDialog} {versionInformation} canConfirm={upgradeCheck.shouldShowUpgrade} />
+<UpdateAllDialog
+ bind:open={upgradeCheck.showConfirmDialog}
+ {versionInformation}
+ canConfirm={upgradeCheck.shouldShowUpgrade}
+ debugDemo={debug}
+/>
{#if upgradeCheck.shouldShowBanner}
<div class={cn('pb-2', isCollapsed ? 'px-1' : 'px-3')}>
diff --git a/frontend/src/routes/(app)/+layout.svelte b/frontend/src/routes/(app)/+layout.svelte
index 8f5bcd35f..0cc19256b 100644
--- a/frontend/src/routes/(app)/+layout.svelte
+++ b/frontend/src/routes/(app)/+layout.svelte
@@ -50,9 +50,6 @@
return flattenNavigationItems(items).filter((item) => item.shortcut?.length);
});
- // Environment liveness is pushed for as long as the app shell is mounted, so
- // every surface that reads environmentStore — the board, the environments
- // table, the switcher — sees an agent reconnect without a page load.
$effect(() => {
if (!user) {
return;
@@ -108,13 +105,6 @@
<svelte:window onkeydown={handleNavigationShortcut} />
-<!--
- `children` is rendered at a single, stable call site so the page subtree is NOT
- torn down and recreated when `isMobile` flips across the 768px breakpoint. A
- remount would re-run each page's one-time state setup and silently discard
- unsaved edits (e.g. the project compose editor). Only the surrounding chrome and
- classes are toggled by viewport. See issue #2938.
--->
<Sidebar.Provider class={isMobile.current ? 'h-auto min-h-dvh' : undefined}>
{#if !isMobile.current}
<AppSidebar {versionInformation} {user} {swarmEnabled} {permissionsManifest} />