Skip to content

Modern Docker Management, Designed for Everyone

fix: user creation button not showing loading state

Kyle Mendelld79b2ff76825
diff --git a/src/lib/components/dialogs/user-form-dialog.svelte b/src/lib/components/dialogs/user-form-dialog.svelte
index 82cd063c8..dce84938e 100644
--- a/src/lib/components/dialogs/user-form-dialog.svelte
+++ b/src/lib/components/dialogs/user-form-dialog.svelte
@@ -12,11 +12,13 @@
open = $bindable(false),
userToEdit = $bindable<User | null>(null),
roles = [],
+ isLoading = $bindable(false), // Add this prop to control loading state from parent
onSubmit = $bindable((_data: { user: Partial<User> & { password?: string }; isEditMode: boolean; userId?: string }) => {})
}: {
open?: boolean;
userToEdit?: User | null;
roles: { id: string; name: string }[];
+ isLoading?: boolean; // New prop
onSubmit?: (data: { user: Partial<User> & { password?: string }; isEditMode: boolean; userId?: string }) => void;
} = $props();
@@ -25,7 +27,6 @@
let displayName = $state('');
let email = $state('');
let selectedRole = $state('user');
- let isSaving = $state(false);
let error = $state<string | null>(null);
let isEditMode = $derived(!!userToEdit);
@@ -53,8 +54,7 @@
});
async function handleSubmit() {
- if (isSaving) return;
- isSaving = true;
+ if (isLoading) return;
error = null;
const userData: Partial<User> & { password?: string } = {
@@ -70,11 +70,9 @@
try {
onSubmit({ user: userData, isEditMode, userId: userToEdit?.id });
- isSaving = false;
} catch (err: unknown) {
const errorMessage = err instanceof Error ? err.message : 'An unexpected error occurred.';
error = errorMessage;
- isSaving = false;
}
}
</script>
@@ -126,11 +124,11 @@
{/if}
<Dialog.Footer>
- <Button type="button" variant="outline" onclick={() => (open = false)} disabled={isSaving}>Cancel</Button>
- <Button type="submit" disabled={isSaving}>
- {#if isSaving}
+ <Button type="button" variant="outline" onclick={() => (open = false)} disabled={isLoading}>Cancel</Button>
+ <Button type="submit" disabled={isLoading}>
+ {#if isLoading}
<Loader2 class="mr-2 h-4 w-4 animate-spin" />
- Saving...
+ Creating...
{:else}
<SubmitIcon class="mr-2 h-4 w-4" />
{submitButtonText}
diff --git a/src/routes/settings/tabs/user-management.svelte b/src/routes/settings/tabs/user-management.svelte
index 9b6fdd41c..969c75af2 100644
--- a/src/routes/settings/tabs/user-management.svelte
+++ b/src/routes/settings/tabs/user-management.svelte
@@ -63,6 +63,7 @@
userPageStates.isUserDialogOpen = false;
toast.success(isEditMode ? 'User Updated Successfully' : 'User Created Successfully');
await invalidateAll();
+ isLoading.saving = false;
}
);
}
@@ -90,7 +91,7 @@
}
</script>
-<UserFormDialog bind:open={userPageStates.isUserDialogOpen} bind:userToEdit={userPageStates.userToEdit} {roles} onSubmit={handleDialogSubmit} bind:this={userDialogRef} />
+<UserFormDialog bind:open={userPageStates.isUserDialogOpen} bind:userToEdit={userPageStates.userToEdit} {roles} onSubmit={handleDialogSubmit} bind:this={userDialogRef} isLoading={isLoading.saving} />
<div class="grid grid-cols-1 gap-6 h-full">
<!-- User List Card -->