Skip to content

Modern Docker Management, Designed for Everyone

fix: validation failed when creating git sync

Kyle Mendelld7a8bc19f9d4
diff --git a/frontend/src/lib/components/dialogs/gitops-sync-dialog.svelte b/frontend/src/lib/components/dialogs/gitops-sync-dialog.svelte
index ce2b377ee..5a7d3d8de 100644
--- a/frontend/src/lib/components/dialogs/gitops-sync-dialog.svelte
+++ b/frontend/src/lib/components/dialogs/gitops-sync-dialog.svelte
@@ -3,6 +3,7 @@
import { Button } from '$lib/components/ui/button/index.js';
import FormInput from '$lib/components/form/form-input.svelte';
import SwitchWithLabel from '$lib/components/form/labeled-switch.svelte';
+ import SelectWithLabel from '$lib/components/form/select-with-label.svelte';
import { Spinner } from '$lib/components/ui/spinner/index.js';
import * as Select from '$lib/components/ui/select/index.js';
import { Label } from '$lib/components/ui/label/index.js';
@@ -27,8 +28,20 @@
let { open = $bindable(false), syncToEdit = $bindable(), targetType, onSubmit, isLoading }: GitOpsSyncFormProps = $props();
+ type GitOpsSyncTargetType = 'project' | 'swarm_stack';
+
let isEditMode = $derived(!!syncToEdit);
let showFileBrowser = $state(false);
+ let selectedTargetType = $state<GitOpsSyncTargetType>('project');
+
+ const targetTypeOptions = [
+ { value: 'project', label: m.project() },
+ { value: 'swarm_stack', label: m.swarm_stack() }
+ ] satisfies { value: GitOpsSyncTargetType; label: string; description?: string }[];
+
+ function normalizeTargetType(value?: string | null): GitOpsSyncTargetType {
+ return value === 'swarm_stack' ? 'swarm_stack' : 'project';
+ }
const formSchema = z.object({
name: z.string().min(1, m.common_name_required()),
@@ -75,6 +88,7 @@
if (open) {
selectedRepository = undefined;
showFileBrowser = false;
+ selectedTargetType = isEditMode ? normalizeTargetType(syncToEdit?.targetType) : normalizeTargetType(targetType);
if (!isEditMode) {
form.reset();
}
@@ -107,7 +121,7 @@
repositoryId: selectedRepository?.value || data.repositoryId,
branch: data.branch,
composePath: data.composePath,
- targetType,
+ targetType: selectedTargetType,
projectName: data.name,
syncDirectory: data.syncDirectory,
autoSync: data.autoSync,
@@ -133,6 +147,14 @@
<form id="sync-form" onsubmit={preventDefault(handleSubmit)} class="grid gap-y-3 py-4">
<FormInput label={m.git_sync_name()} type="text" placeholder={m.common_name_placeholder()} bind:input={$inputs.name} />
+ <SelectWithLabel
+ id="targetType"
+ label={m.webhook_target_type_label()}
+ value={selectedTargetType}
+ options={targetTypeOptions}
+ onValueChange={(value) => (selectedTargetType = value as GitOpsSyncTargetType)}
+ />
+
<div class="space-y-1.5">
<Label for="repository">{m.git_sync_repository()}</Label>
<Select.Root
diff --git a/frontend/src/routes/(app)/environments/[id]/gitops/+page.svelte b/frontend/src/routes/(app)/environments/[id]/gitops/+page.svelte
index f4f61b913..d7207d13b 100644
--- a/frontend/src/routes/(app)/environments/[id]/gitops/+page.svelte
+++ b/frontend/src/routes/(app)/environments/[id]/gitops/+page.svelte
@@ -78,9 +78,9 @@
});
}
- function openCreateSyncDialog(targetType?: string) {
+ function openCreateSyncDialog(targetType?: string | Event) {
syncToEdit = null;
- dialogTargetType = targetType;
+ dialogTargetType = typeof targetType === 'string' ? targetType : undefined;
isSyncDialogOpen = true;
}
@@ -153,7 +153,7 @@
id: 'create',
action: 'create',
label: m.common_add_button({ resource: m.resource_sync_cap() }),
- onclick: openCreateSyncDialog
+ onclick: () => openCreateSyncDialog()
},
{
id: 'import',