Skip to content

Modern Docker Management, Designed for Everyone

perf: add missing database indexes to improve slow sql queries (#1169)

Kyle Mendellee62ca4a9e75
diff --git a/backend/internal/services/environment_service.go b/backend/internal/services/environment_service.go
index 5c486b3a3..ce1832346 100644
--- a/backend/internal/services/environment_service.go
+++ b/backend/internal/services/environment_service.go
@@ -282,13 +282,20 @@ func (s *EnvironmentService) updateEnvironmentStatusInternal(ctx context.Context
func (s *EnvironmentService) UpdateEnvironmentHeartbeat(ctx context.Context, id string) error {
now := time.Now()
- if err := s.db.WithContext(ctx).Model(&models.Environment{}).Where("id = ?", id).Updates(map[string]interface{}{
- "last_seen": &now,
- "status": string(models.EnvironmentStatusOnline),
- "updated_at": &now,
- }).Error; err != nil {
- return fmt.Errorf("failed to update environment heartbeat: %w", err)
+
+ // Use Exec with raw SQL for better performance
+ // Only update if last_seen is NULL or older than 30 seconds to reduce write frequency
+ result := s.db.WithContext(ctx).Exec(`
+ UPDATE environments
+ SET last_seen = ?, status = ?, updated_at = ?
+ WHERE id = ?
+ AND (last_seen IS NULL OR last_seen < ?)
+ `, &now, string(models.EnvironmentStatusOnline), &now, id, now.Add(-30*time.Second))
+
+ if result.Error != nil {
+ return fmt.Errorf("failed to update environment heartbeat: %w", result.Error)
}
+
return nil
}
func (s *EnvironmentService) createEnvironmentEvent(ctx context.Context, envID, envName string, eventType models.EventType, title, description string, severity models.EventSeverity, userID, username *string) {
diff --git a/backend/resources/migrations/postgres/027_add_missing_indexes.down.sql b/backend/resources/migrations/postgres/027_add_missing_indexes.down.sql
new file mode 100644
index 000000000..40bd1dcbf
--- /dev/null
+++ b/backend/resources/migrations/postgres/027_add_missing_indexes.down.sql
@@ -0,0 +1,15 @@
+DROP INDEX IF EXISTS idx_environments_enabled;
+DROP INDEX IF EXISTS idx_environments_status;
+DROP INDEX IF EXISTS idx_environments_last_seen;
+DROP INDEX IF EXISTS idx_container_registries_enabled;
+DROP INDEX IF EXISTS idx_projects_status;
+DROP INDEX IF EXISTS idx_projects_name;
+DROP INDEX IF EXISTS idx_users_username;
+DROP INDEX IF EXISTS idx_users_email;
+DROP INDEX IF EXISTS idx_users_oidc_subject_id;
+DROP INDEX IF EXISTS idx_image_updates_has_update;
+DROP INDEX IF EXISTS idx_image_updates_has_update_notification;
+DROP INDEX IF EXISTS idx_image_updates_check_time;
+DROP INDEX IF EXISTS idx_image_updates_notification_sent;
+DROP INDEX IF EXISTS idx_notification_settings_enabled;
+DROP INDEX IF EXISTS idx_apprise_settings_enabled;
diff --git a/backend/resources/migrations/postgres/027_add_missing_indexes.up.sql b/backend/resources/migrations/postgres/027_add_missing_indexes.up.sql
new file mode 100644
index 000000000..6ccc193f0
--- /dev/null
+++ b/backend/resources/migrations/postgres/027_add_missing_indexes.up.sql
@@ -0,0 +1,15 @@
+CREATE INDEX IF NOT EXISTS idx_environments_enabled ON environments (enabled);
+CREATE INDEX IF NOT EXISTS idx_environments_status ON environments (status);
+CREATE INDEX IF NOT EXISTS idx_environments_last_seen ON environments (last_seen);
+CREATE INDEX IF NOT EXISTS idx_container_registries_enabled ON container_registries (enabled);
+CREATE INDEX IF NOT EXISTS idx_projects_status ON projects (status);
+CREATE INDEX IF NOT EXISTS idx_projects_name ON projects (name);
+CREATE INDEX IF NOT EXISTS idx_users_username ON users (username);
+CREATE INDEX IF NOT EXISTS idx_users_email ON users (email);
+CREATE INDEX IF NOT EXISTS idx_users_oidc_subject_id ON users (oidc_subject_id);
+CREATE INDEX IF NOT EXISTS idx_image_updates_has_update ON image_updates (has_update);
+CREATE INDEX IF NOT EXISTS idx_image_updates_has_update_notification ON image_updates (has_update, notification_sent);
+CREATE INDEX IF NOT EXISTS idx_image_updates_check_time ON image_updates (check_time);
+CREATE INDEX IF NOT EXISTS idx_image_updates_notification_sent ON image_updates (notification_sent);
+CREATE INDEX IF NOT EXISTS idx_notification_settings_enabled ON notification_settings (enabled);
+CREATE INDEX IF NOT EXISTS idx_apprise_settings_enabled ON apprise_settings (enabled);
diff --git a/backend/resources/migrations/sqlite/027_add_missing_indexes.down.sql b/backend/resources/migrations/sqlite/027_add_missing_indexes.down.sql
new file mode 100644
index 000000000..efef67c37
--- /dev/null
+++ b/backend/resources/migrations/sqlite/027_add_missing_indexes.down.sql
@@ -0,0 +1,16 @@
+-- Remove all indexes added in migration 027
+DROP INDEX IF EXISTS idx_environments_enabled;
+DROP INDEX IF EXISTS idx_environments_status;
+DROP INDEX IF EXISTS idx_environments_last_seen;
+DROP INDEX IF EXISTS idx_container_registries_enabled;
+DROP INDEX IF EXISTS idx_projects_status;
+DROP INDEX IF EXISTS idx_projects_name;
+DROP INDEX IF EXISTS idx_users_username;
+DROP INDEX IF EXISTS idx_users_email;
+DROP INDEX IF EXISTS idx_users_oidc_subject_id;
+DROP INDEX IF EXISTS idx_image_updates_has_update;
+DROP INDEX IF EXISTS idx_image_updates_has_update_notification;
+DROP INDEX IF EXISTS idx_image_updates_check_time;
+DROP INDEX IF EXISTS idx_image_updates_notification_sent;
+DROP INDEX IF EXISTS idx_notification_settings_enabled;
+DROP INDEX IF EXISTS idx_apprise_settings_enabled;
diff --git a/backend/resources/migrations/sqlite/027_add_missing_indexes.up.sql b/backend/resources/migrations/sqlite/027_add_missing_indexes.up.sql
new file mode 100644
index 000000000..8f0975c54
--- /dev/null
+++ b/backend/resources/migrations/sqlite/027_add_missing_indexes.up.sql
@@ -0,0 +1,15 @@
+CREATE INDEX IF NOT EXISTS idx_environments_enabled ON environments(enabled);
+CREATE INDEX IF NOT EXISTS idx_environments_status ON environments(status);
+CREATE INDEX IF NOT EXISTS idx_environments_last_seen ON environments(last_seen);
+CREATE INDEX IF NOT EXISTS idx_container_registries_enabled ON container_registries(enabled);
+CREATE INDEX IF NOT EXISTS idx_projects_status ON projects(status);
+CREATE INDEX IF NOT EXISTS idx_projects_name ON projects(name);
+CREATE INDEX IF NOT EXISTS idx_users_username ON users(username);
+CREATE INDEX IF NOT EXISTS idx_users_email ON users(email);
+CREATE INDEX IF NOT EXISTS idx_users_oidc_subject_id ON users(oidc_subject_id);
+CREATE INDEX IF NOT EXISTS idx_image_updates_has_update ON image_updates(has_update);
+CREATE INDEX IF NOT EXISTS idx_image_updates_has_update_notification ON image_updates(has_update, notification_sent);
+CREATE INDEX IF NOT EXISTS idx_image_updates_check_time ON image_updates(check_time);
+CREATE INDEX IF NOT EXISTS idx_image_updates_notification_sent ON image_updates(notification_sent);
+CREATE INDEX IF NOT EXISTS idx_notification_settings_enabled ON notification_settings(enabled);
+CREATE INDEX IF NOT EXISTS idx_apprise_settings_enabled ON apprise_settings(enabled);