Skip to content

Turn any idea, plan, or codebase into a beautiful interactive diagram. An agent skill for Claude Code, Codex, and more.

fix(waterfall): preserve nonzero fractional timing labels

杨嘉伟1e8105682d31
diff --git a/archify/renderers/waterfall/render-waterfall.mjs b/archify/renderers/waterfall/render-waterfall.mjs
index e6db3728..348071cc 100644
--- a/archify/renderers/waterfall/render-waterfall.mjs
+++ b/archify/renderers/waterfall/render-waterfall.mjs
@@ -126,6 +126,10 @@ const rows = [];
}(spans.filter((span) => span.parent === undefined), 0));
function number(value) {
+ if (value !== 0 && Math.abs(value) < 0.01) {
+ return Math.abs(value) < 1e-6 ? Number(value.toPrecision(3)).toString()
+ : value.toLocaleString('en-US', { maximumSignificantDigits: 3 });
+ }
const rounded = Math.round(value * 100) / 100;
return rounded.toLocaleString('en-US', { maximumFractionDigits: 2 });
}
diff --git a/test/waterfall-rendering.test.mjs b/test/waterfall-rendering.test.mjs
index efe988e0..3dc670da 100644
--- a/test/waterfall-rendering.test.mjs
+++ b/test/waterfall-rendering.test.mjs
@@ -65,6 +65,21 @@ test('waterfall: percentages name their denominator and are never summed into th
assert.match(html, /data-waterfall-evidence="illustrative"/);
});
+test('waterfall: small fractional values keep nonzero duration labels', () => {
+ for (const duration of [0.004, 0.00004, 1e-8]) {
+ const diagram = clone(small);
+ diagram.spans = [{ id: 'request', name: 'Request', start: 0, duration }];
+ const result = run(diagram);
+ assert.equal(result.status, 0, result.stderr);
+ const html = fs.readFileSync(result.output, 'utf8');
+ assert.match(html, new RegExp(`${String(duration).replace('.', '\\.')} ms`));
+ const tickLabels = [...html.matchAll(/class="t-muted wf-num"[^>]*>([^<]+)<\/text>/g)].map((match) => match[1]);
+ assert.ok(new Set(tickLabels).size > 1, 'distinct positive ticks must not all round to zero');
+ const report = layoutOf(diagram);
+ assert.notEqual(report.rows[0].label, '0 ms');
+ }
+});
+
test('waterfall: a short operation keeps its duration label beside the bar', () => {
const diagram = clone(small);
diagram.spans.push({ id: 'cache', name: 'Read cache', start: 400, duration: 4, parent: 'payment' });