Skip to content

Turn any idea, plan, or codebase into a beautiful interactive diagram. An agent skill for Claude Code, Codex, and more.

fix(viewer): ignore cancelled Passport drag click on page background

tt-a1i25d6984ed70f
diff --git a/archify/assets/template.html b/archify/assets/template.html
index d3e2852c..253dd255 100644
--- a/archify/assets/template.html
+++ b/archify/assets/template.html
@@ -7691,6 +7691,7 @@ OTHER DEALINGS IN THE FONT SOFTWARE.
var relationshipHitTargets = [];
var directPreviewTimer = null;
var lensDrag = null;
+ var lensDragClickPointer = null;
var manualLensPosition = null;
var reachabilityMode = null;
var activeReachability = null;
@@ -8768,6 +8769,7 @@ OTHER DEALINGS IN THE FONT SOFTWARE.
event.stopPropagation();
var activeDrag = lensDrag;
lensDrag = null;
+ if (activeDrag.moved) lensDragClickPointer = activeDrag.pointerId;
chip.removeAttribute('data-panel-dragging');
try { moveBtn.releasePointerCapture(event.pointerId); } catch (_) {}
if (!cancel) return;
@@ -9181,7 +9183,20 @@ OTHER DEALINGS IN THE FONT SOFTWARE.
event.preventDefault();
buttons[index].focus();
});
+ document.addEventListener('pointerdown', function () {
+ lensDragClickPointer = null;
+ }, true);
document.addEventListener('click', function (event) {
+ // Losing capture (for example when a resize hides the handle) can
+ // retarget this drag's final click to the page. It is not dismissal.
+ // A new pointerdown releases the guard; keyboard clicks remain live.
+ if (lensDragClickPointer != null && event.detail > 0 &&
+ (event.pointerId == null || event.pointerId === lensDragClickPointer)) {
+ lensDragClickPointer = null;
+ event.preventDefault();
+ event.stopPropagation();
+ return;
+ }
var target = event.target;
if (chip.hidden || !target || typeof target.closest !== 'function' || chip.contains(target)) return;
if (container.getAttribute('data-just-panned') === 'true') return;
@@ -9258,6 +9273,7 @@ OTHER DEALINGS IN THE FONT SOFTWARE.
};
})();
+
/* ============================================================
Intent Trace — temporary one-hop topology before durable focus.
Fine-pointer hover and keyboard focus share the same stable-ID preview;
diff --git a/archify/test/semantic-passport-move-browser.test.mjs b/archify/test/semantic-passport-move-browser.test.mjs
index 3131d80a..ae7dc17b 100644
--- a/archify/test/semantic-passport-move-browser.test.mjs
+++ b/archify/test/semantic-passport-move-browser.test.mjs
@@ -250,8 +250,10 @@ test('Semantic Passport pointer movement honors threshold, capture, four-edge cl
}))`);
await browser.cdp.send('Input.dispatchMouseEvent', {
type: 'mouseReleased',
- x: cancelStart.x + 70,
- y: cancelStart.y + 50,
+ // After cancellation the handle no longer owns the pointer. Releasing
+ // over page background must not turn the cancelled drag into dismissal.
+ x: 5,
+ y: 5,
button: 'left',
buttons: 0,
clickCount: 1,
@@ -327,6 +329,14 @@ test('Semantic Passport pointer movement honors threshold, capture, four-edge cl
const reopened = await focusNode(browser, sessionId, 'lb');
assert.equal(reopened.manual, null, JSON.stringify(reopened, null, 2));
assert.equal(reopened.styleLeft, '', JSON.stringify(reopened, null, 2));
+ await browser.cdp.send('Input.dispatchMouseEvent', {
+ type: 'mousePressed', x: 5, y: 5, button: 'left', buttons: 1, clickCount: 1,
+ }, sessionId);
+ await browser.cdp.send('Input.dispatchMouseEvent', {
+ type: 'mouseReleased', x: 5, y: 5, button: 'left', buttons: 0, clickCount: 1,
+ }, sessionId);
+ await settle(browser, sessionId, 20);
+ assert.equal((await passportState(browser, sessionId)).hidden, true, 'a subsequent deliberate outside click must still dismiss');
} finally {
await browser.close();
}
diff --git a/viewer/focus.js b/viewer/focus.js
index e114a719..51ef666e 100644
--- a/viewer/focus.js
+++ b/viewer/focus.js
@@ -39,6 +39,7 @@
var relationshipHitTargets = [];
var directPreviewTimer = null;
var lensDrag = null;
+ var lensDragClickPointer = null;
var manualLensPosition = null;
var reachabilityMode = null;
var activeReachability = null;
@@ -1116,6 +1117,7 @@
event.stopPropagation();
var activeDrag = lensDrag;
lensDrag = null;
+ if (activeDrag.moved) lensDragClickPointer = activeDrag.pointerId;
chip.removeAttribute('data-panel-dragging');
try { moveBtn.releasePointerCapture(event.pointerId); } catch (_) {}
if (!cancel) return;
@@ -1529,7 +1531,20 @@
event.preventDefault();
buttons[index].focus();
});
+ document.addEventListener('pointerdown', function () {
+ lensDragClickPointer = null;
+ }, true);
document.addEventListener('click', function (event) {
+ // Losing capture (for example when a resize hides the handle) can
+ // retarget this drag's final click to the page. It is not dismissal.
+ // A new pointerdown releases the guard; keyboard clicks remain live.
+ if (lensDragClickPointer != null && event.detail > 0 &&
+ (event.pointerId == null || event.pointerId === lensDragClickPointer)) {
+ lensDragClickPointer = null;
+ event.preventDefault();
+ event.stopPropagation();
+ return;
+ }
var target = event.target;
if (chip.hidden || !target || typeof target.closest !== 'function' || chip.contains(target)) return;
if (container.getAttribute('data-just-panned') === 'true') return;
@@ -1604,4 +1619,4 @@
},
active: function () { return activeIds.length === 0 ? null : (activeIds.length === 1 ? activeIds[0] : activeIds.slice()); }
};
- })();
\ No newline at end of file
+ })();