Skip to content

Turn any idea, plan, or codebase into a beautiful interactive diagram. An agent skill for Claude Code, Codex, and more.

fix(sequence): validate segment label canvas containment (fixes #297)

hasak213c42a59abe97
diff --git a/archify.zip b/archify.zip
index e64f6fa9..152a97c9 100644
Binary files a/archify.zip and b/archify.zip differ
diff --git a/archify/renderers/sequence/render-sequence.mjs b/archify/renderers/sequence/render-sequence.mjs
index 02d77817..1cfc032a 100644
--- a/archify/renderers/sequence/render-sequence.mjs
+++ b/archify/renderers/sequence/render-sequence.mjs
@@ -113,6 +113,19 @@ function messageRouteBox(message) {
};
}
+function segmentLabelBox(segment) {
+ const labelW = Math.max(42, textUnits(segment.label) * 5.2 + 14);
+ const occupied = asArray(sequence.messages)
+ .flatMap((message) => [messageLabelBox(message), messageRouteBox(message)])
+ .filter(Boolean);
+ const label = { x: 56, y: segment.from - 22, width: labelW, height: 18 };
+ for (let attempt = 0; attempt < 4; attempt += 1) {
+ if (!occupied.some((rect) => rectsOverlap(label, rect, 2))) break;
+ label.y -= 22;
+ }
+ return label;
+}
+
const compositionFrames = asArray(sequence.segments).map((segment, index) => ({
id: index,
label: segment.label,
@@ -270,6 +283,12 @@ function validateSequence() {
if (segment.from < layout.topY || segment.to > layout.lifelineBottom + 20) {
problems.push(`Segment "${segment.label}" extends outside the canvas — keep its y range between ${layout.topY} and ${layout.lifelineBottom + 20}.`);
}
+ const labelBox = segmentLabelBox(segment);
+ const availableWidth = Math.max(0, viewBox[0] - 48 - labelBox.x);
+ if (labelBox.x + labelBox.width > viewBox[0] - 48) {
+ const requiredWidth = Math.ceil(labelBox.x + labelBox.width + 48);
+ problems.push(`Segment "${segment.label}" label (~${Math.round(labelBox.width)}px) exceeds the segment frame's available width (${availableWidth}px) — shorten the label or increase meta.viewBox[0] to at least ${requiredWidth}.`);
+ }
}
for (const activation of asArray(sequence.activations)) {
@@ -322,15 +341,7 @@ function renderSegment(segment, index) {
}
function renderSegmentLabel(segment, index) {
- const labelW = Math.max(42, textUnits(segment.label) * 5.2 + 14);
- const occupied = asArray(sequence.messages)
- .flatMap((message) => [messageLabelBox(message), messageRouteBox(message)])
- .filter(Boolean);
- const label = { x: 56, y: segment.from - 22, width: labelW, height: 18 };
- for (let attempt = 0; attempt < 4; attempt += 1) {
- if (!occupied.some((rect) => rectsOverlap(label, rect, 2))) break;
- label.y -= 22;
- }
+ const label = segmentLabelBox(segment);
return ` <g data-graph-role="segment-label" data-segment-id="${index}">
<rect x="${label.x}" y="${label.y}" width="${label.width}" height="${label.height}" rx="3" class="c-mask"/>
<text x="${label.x + 6}" y="${label.y + 13}" class="t-dim" font-size="9" font-weight="600">${esc(segment.label)}</text>
diff --git a/archify/test/layout-rules.test.mjs b/archify/test/layout-rules.test.mjs
index b432ddab..1182dc9c 100644
--- a/archify/test/layout-rules.test.mjs
+++ b/archify/test/layout-rules.test.mjs
@@ -214,6 +214,9 @@ const CASES = [
(d) => { d.messages[0].y = 9000; }, ['outside the readable timeline', 'keep y between']],
['sequence: segment to <= from', 'sequence',
(d) => { d.segments = [{ from: 400, to: 300, label: 'bad' }]; }, ['invalid y range', 'greater than']],
+ ['sequence: segment label exceeds segment frame available width', 'sequence',
+ (d) => { d.segments[0].label = 'Long Segment Label '.repeat(10); },
+ ['exceeds the segment frame\'s available width', 'increase meta.viewBox[0]']],
['sequence: participant sublabel wider than its legible minimum', 'sequence',
(d) => { d.participants[0].sublabel = 'This supporting sentence is far too long for one sequence participant'; },
['Sublabel', 'legible', 'shorten the sublabel']],
@@ -1446,4 +1449,41 @@ test('sequence: segment title badge clears a nearby first message label', () =>
assert.equal(overlaps, false, 'segment title badge must not cover the first message label');
});
+test('sequence: segment label exceeding segment frame available width fails layout validation with remediation', () => {
+ const d = load('sequence');
+ d.segments[0].label = 'Phase 1: Dual-Certificate mTLS Handshake & Distributed Token Verification Protocol Negotiation'.repeat(2);
+
+ const { code, stderr } = render('sequence', d);
+ assert.equal(code, 1);
+ assert.match(stderr, /Segment "Phase 1: Dual-Certificate mTLS Handshake & Distributed Token Verification Protocol NegotiationPhase 1: Dual-Certificate mTLS Handshake & Distributed Token Verification Protocol Negotiation" label \(~992px\) exceeds the segment frame's available width \(716px\) — shorten the label or increase meta\.viewBox\[0\] to at least 1096\./);
+
+ // Remediating by increasing viewBox[0] to the suggested minimum allows it to pass cleanly
+ d.meta.viewBox[0] = 1096;
+ const fixed = render('sequence', d);
+ assert.equal(fixed.code, 0, fixed.stderr);
+});
+
+test('sequence: segment label boundary containment within canvas vs segment frame and exact-fit', () => {
+ // Available width in default sequence fixture (viewBox[0] = 820):
+ // frame right edge = 820 - 48 = 772
+ // labelBox.x = 56
+ // availableWidth = 772 - 56 = 716px
+ // 135 ASCII units -> labelW = 135 * 5.2 + 14 = 716px -> label right edge = 56 + 716 = 772px (exact fit)
+ // 136 ASCII units -> labelW = 136 * 5.2 + 14 = 721.2px -> label right edge = 56 + 721.2 = 777.2px
+ // (777.2px <= 820 canvas width, but > 772 segment frame edge)
+
+ // 1. Fits within canvas (777.2 <= 820) but exceeds segment frame (777.2 > 772)
+ const dExceed = load('sequence');
+ dExceed.segments[0].label = 'A'.repeat(136);
+ const resExceed = render('sequence', dExceed);
+ assert.equal(resExceed.code, 1, 'label exceeding segment frame must fail even if within canvas');
+ assert.match(resExceed.stderr, /label \(~721px\) exceeds the segment frame's available width \(716px\) — shorten the label or increase meta\.viewBox\[0\] to at least 826\./);
+
+ // 2. Exact-fit case at the frame's right edge (56 + 716 = 772 === 820 - 48)
+ const dExact = load('sequence');
+ dExact.segments[0].label = 'A'.repeat(135);
+ const resExact = render('sequence', dExact);
+ assert.equal(resExact.code, 0, `exact-fit label at segment frame boundary must pass cleanly: ${resExact.stderr}`);
+});
+
process.on('exit', () => fs.rmSync(tmp, { recursive: true, force: true }));