Skip to content

Turn any idea, plan, or codebase into a beautiful interactive diagram. An agent skill for Claude Code, Codex, and more.

test: retain shared renderer consumers in affected coverage

tt-a1i8aac409ee21d
diff --git a/scripts/ci-scope.mjs b/scripts/ci-scope.mjs
index 066f6d55..dd6563c9 100644
--- a/scripts/ci-scope.mjs
+++ b/scripts/ci-scope.mjs
@@ -39,6 +39,11 @@ export function classifyPaths(paths) {
const renderer = name.match(rendererPath);
if (renderer) {
own(renderer[1] || renderer[2]);
+ // These mode-local helpers also serve other renderers directly.
+ if (name === 'archify/renderers/erd/grid.mjs') own('class');
+ if (name === 'archify/renderers/architecture/routing.mjs') {
+ own('erd'); own('class');
+ }
if (renderer[2]) own('schema');
plan.generated = plan.browser = plan.package = true;
continue;
diff --git a/scripts/run-affected-tests.mjs b/scripts/run-affected-tests.mjs
index 3f93ac67..1cb7deb9 100644
--- a/scripts/run-affected-tests.mjs
+++ b/scripts/run-affected-tests.mjs
@@ -8,7 +8,7 @@ import { sameEntry } from '../archify/renderers/shared/path-semantics.mjs';
const root = fileURLToPath(new URL('../', import.meta.url));
const mode = /^(architecture|workflow|sequence|dataflow|lifecycle|erd|class|tree|timeline|waterfall)-/;
// A few broad ownership families, not a source-to-test dependency graph.
-const shared = /^(geometry|spatial-grid|svg-path-analysis|layout-rules|engineering-profile|legend-contract|render-|renderer-(?:diagnostic|import)|route-|authored-|spread-|text-|base-input-|v1-|brand-|semantic-legend)/;
+const shared = /^(geometry|spatial-grid|svg-path-analysis|layout-rules|engineering-profile|legend-contract|render-|renderer-(?:diagnostic|import)|route-|authored-|spread-|text-|base-input-|v1-|brand-|semantic-legend|automatic-port-spread|edge-label-color|label-clearance|vertical-edge|node-icons)/;
const viewer = /^(viewer-|reader-|desktop-|semantic-|finder|focus|intent-|crossover-|animation|export-|motion-|offline-|i18n|relationship-|share-|reach-|presentation)/;
export function selectAffectedTests(owners, changed, available) {
if (!Array.isArray(owners) || !Array.isArray(changed)) throw new Error('CI test selection must contain arrays');
@@ -26,7 +26,8 @@ export function selectAffectedTests(owners, changed, available) {
: owner === 'delta' ? name === 'architecture-delta.test.mjs'
: owner === 'schema' ? /^(generate-validators|base-input-|v1-|workflow-migration)/.test(name)
: owner === 'readme' ? name === 'readme-showcase.test.mjs'
- : name.startsWith(`${owner}-`) || shared.test(name));
+ : name.startsWith(`${owner}-`) || shared.test(name)
+ || (owner === 'architecture' && name === 'grid.test.mjs'));
}).sort();
}
if (process.argv[1] && sameEntry(process.argv[1], fileURLToPath(import.meta.url)).status === 'match') {
diff --git a/test/ci-scope.test.mjs b/test/ci-scope.test.mjs
index 6c6e10a3..abd14973 100644
--- a/test/ci-scope.test.mjs
+++ b/test/ci-scope.test.mjs
@@ -49,6 +49,46 @@ test('recipe, schema and shared renderer owners include their real source consum
assert.ok(selectAffectedTests(schema.owners, [], available).includes('test/generate-validators.test.mjs'));
});
+test('Architecture grid changes retain explicit placement regression coverage', () => {
+ const available = ['test/grid.test.mjs', 'test/architecture-first-draft.test.mjs', 'test/cli.test.mjs'];
+ const plan = classifyPaths(['archify/renderers/architecture/grid.mjs']);
+ assert.equal(plan.scope, 'core');
+ assert.ok(plan.generated && plan.browser && plan.package);
+ const selected = selectAffectedTests(plan.owners, [], available);
+ assert.ok(selected.includes('test/grid.test.mjs'));
+ assert.ok(!selected.includes('test/cli.test.mjs'));
+});
+
+test('the grid shared by ERD and Class retains both modes and their compatibility checks', () => {
+ const available = ['test/erd-rendering.test.mjs', 'test/class-rendering.test.mjs', 'test/tree-rendering.test.mjs'];
+ const plan = classifyPaths(['archify/renderers/erd/grid.mjs']);
+ assert.equal(plan.scope, 'core');
+ assert.ok(plan.owners.includes('erd') && plan.owners.includes('class'));
+ assert.deepEqual(selectAffectedTests(plan.owners, [], available), available.slice(0, 2).sort());
+});
+
+test('the router shared by Architecture, ERD and Class retains all three callers', () => {
+ const available = ['test/architecture-first-draft.test.mjs', 'test/erd-rendering.test.mjs',
+ 'test/class-rendering.test.mjs', 'test/tree-rendering.test.mjs'];
+ const plan = classifyPaths(['archify/renderers/architecture/routing.mjs']);
+ assert.equal(plan.scope, 'core');
+ assert.ok(plan.generated && plan.browser && plan.package);
+ assert.ok(['architecture', 'erd', 'class'].every(owner => plan.owners.includes(owner)));
+ assert.deepEqual(selectAffectedTests(plan.owners, [], available), available.slice(0, 3).sort());
+});
+
+test('renderer changes retain cross-mode public regressions even without changing those tests', () => {
+ const regressions = ['test/automatic-port-spread.test.mjs', 'test/edge-label-color.test.mjs',
+ 'test/label-clearance.test.mjs', 'test/vertical-edge.test.mjs', 'test/node-icons.test.mjs'];
+ const available = [...regressions, 'test/cli.test.mjs'];
+ for (const source of ['archify/renderers/dataflow/render-dataflow.mjs',
+ 'archify/renderers/sequence/render-sequence.mjs', 'archify/renderers/shared/geometry.mjs']) {
+ const plan = classifyPaths([source]);
+ assert.equal(plan.scope, 'core');
+ assert.deepEqual(selectAffectedTests(plan.owners, [], available), regressions.slice().sort(), source);
+ }
+});
+
test('checked artifacts retain XML integrity and compare artifact regression coverage', () => {
const available = ['test/generated-artifact-xml.test.mjs', 'test/architecture-delta.test.mjs'];
for (const name of ['examples/checkout-platform-delta.html', 'docs/guide.html', 'archify/examples/rendered.html', 'docs/assets/example.svg']) {
diff --git a/test/core-smoke.test.mjs b/test/core-smoke.test.mjs
index edee2a19..3769fa8c 100644
--- a/test/core-smoke.test.mjs
+++ b/test/core-smoke.test.mjs
@@ -182,7 +182,7 @@ test('core smoke: public CLI diagrams, compatibility and delivery safety', async
});
await t.test('strict provenance binds the delivered artifact bytes', (t) => {
- if (!workflow) return t.skip('requires the official workflow delivery that failed above');
+ if (!workflow) return t.skip('requires a successful official workflow delivery');
const checked = receipt(['check', workflow.output, '--require-provenance']);
assert.equal(checked.ok, true);
assert.equal(checked.provenance, 'current');
@@ -200,7 +200,7 @@ test('core smoke: public CLI diagrams, compatibility and delivery safety', async
});
await t.test('invalid schema preserves the last artifact and marks its delivery as failed', (t) => {
- if (!workflow) return t.skip('requires the official workflow delivery that failed above');
+ if (!workflow) return t.skip('requires a successful official workflow delivery');
const invalid = structuredClone(workflow.document);
invalid.nodes[0].unexpected = true;
const input = path.join(workflow.directory, 'invalid.workflow.json');