Turn any idea, plan, or codebase into a beautiful interactive diagram. An agent skill for Claude Code, Codex, and more.
HTML agent-skillsai-agentsarchitecture-diagramclaude-codeclaude-skillscodexcoding-agentsdeepseek-harnessdeveloper-toolsdiagramsdiagrams-as-codedsh-pluginflowchartllmmermaidopencodesequence-diagramsoftware-architecturesystem-designvisualization
chore(review): keep Workflow reader evidence out of the final tree
tt-a1i99939e3a633d
diff --git a/docs/assets/reviews/workflow-reader-width/README.md b/docs/assets/reviews/workflow-reader-width/README.mddeleted file mode 100644index bf177786..00000000--- a/docs/assets/reviews/workflow-reader-width/README.md+++ /dev/null@@ -1,31 +0,0 @@-# Workflow stack reading width--Comparison base: `e23fc2c5c8cf1aaa3864e7966f8b8ec43dc2bebd` (`dev`). The candidate changes only the existing automatic stacked-Workflow Reader declaration from `intrinsic-height` to `width-first`. The inputs are original synthetic public examples, not redactions or copies of a private project. They illustrate two layout shapes; they are not an agent generation benchmark and do not establish a first-pass success rate.--All four screenshots use Chrome, **1440 × 1000**, light theme, `signal-flow`, showcase quality, camera **100%**, and page top. No private source or internal project content is included. The browser waits for fonts and layout settling, then captures the viewport. The JSON records actual primary-label pixel font sizes from computed fonts and SVG screen transforms, document scrolling, horizontal overflow, and a separate bottom-scroll observation.--| Synthetic input | dev before | Candidate after | Minimum actual primary-label font | Document scroll beyond viewport | Horizontal overflow |-| --- | --- | --- | --- | --- | --- |-| [One lane, five stages](../../../../test/fixtures/reader-readability/five-stage-stack.workflow.json) | [Before](five-stage-stack-before.png) | [After](five-stage-stack-after.png) | 12.04 → 15.00 px | 136 → 289 px | false → false |-| [Execution and failure lanes](../../../../test/fixtures/reader-readability/execution-failure-stack.workflow.json) | [Before](execution-failure-stack-before.png) | [After](execution-failure-stack-after.png) | 10.24 → 15.00 px | 199 → 549 px | false → false |--Both candidates reach the existing 1.5× SVG enlargement cap. Larger labels cost more vertical page scrolling. The Dock temporarily overlays the SVG area at the viewport floor on the initial screen; no primary node rectangles intersect the Dock in these examples. Bottom scrolling exposes the remaining stages completely. This evidence does not establish that the balance is optimal: maintainers should judge the before/after images and the readability-versus-overview tradeoff. The existing `visual-check` reports minimum projected text conservatively with a scale capped at 1, so its 8px result is distinct from the actual displayed primary-label font measurements above.--## Reproduce--Use official Node 22, Chrome, and install both root and `archify/` dependencies in the candidate. Use a clean checkout or archive of the pinned base as `/tmp/archify-pr4-baseline`, with its renderer dependencies installed. From the candidate repository root:--```sh-export ARCHIFY_CHROME='/Applications/Google Chrome.app/Contents/MacOS/Google Chrome'-node scripts/capture-workflow-reader-width.mjs /tmp/archify-pr4-baseline /tmp/workflow-reader-width-evidence-node archify/bin/archify.mjs render workflow test/fixtures/reader-readability/five-stage-stack.workflow.json /tmp/five-stage-stack.html --quality showcase-node archify/bin/archify.mjs render workflow test/fixtures/reader-readability/execution-failure-stack.workflow.json /tmp/execution-failure-stack.html --quality showcase-node archify/bin/archify.mjs visual-check /tmp/five-stage-stack.html --json-node archify/bin/archify.mjs visual-check /tmp/execution-failure-stack.html --json-node --test test/workflow-compiler.test.mjs-node test/golden.mjs-npm --prefix archify run check:validators-node --test test/desktop-reader-browser.test.mjs test/reader-layout-browser.test.mjs-```--The capture output directory must not already contain the screenshot names (the browser writes them exclusively). [Measurements](measurements.json) preserve the full per-label values. Browser checks establish containment, readability floors, the enlargement cap, and retained authored geometry; they are separate from maintainer perceptual review. Embed, Present, and print remain on their previous layout path.diff --git a/docs/assets/reviews/workflow-reader-width/execution-failure-stack-after.png b/docs/assets/reviews/workflow-reader-width/execution-failure-stack-after.pngdeleted file mode 100644index 7f65d56a..00000000Binary files a/docs/assets/reviews/workflow-reader-width/execution-failure-stack-after.png and /dev/null differdiff --git a/docs/assets/reviews/workflow-reader-width/execution-failure-stack-before.png b/docs/assets/reviews/workflow-reader-width/execution-failure-stack-before.pngdeleted file mode 100644index 264928d9..00000000Binary files a/docs/assets/reviews/workflow-reader-width/execution-failure-stack-before.png and /dev/null differdiff --git a/docs/assets/reviews/workflow-reader-width/five-stage-stack-after.png b/docs/assets/reviews/workflow-reader-width/five-stage-stack-after.pngdeleted file mode 100644index b612658f..00000000Binary files a/docs/assets/reviews/workflow-reader-width/five-stage-stack-after.png and /dev/null differdiff --git a/docs/assets/reviews/workflow-reader-width/five-stage-stack-before.png b/docs/assets/reviews/workflow-reader-width/five-stage-stack-before.pngdeleted file mode 100644index 605ad15c..00000000Binary files a/docs/assets/reviews/workflow-reader-width/five-stage-stack-before.png and /dev/null differdiff --git a/docs/assets/reviews/workflow-reader-width/measurements.json b/docs/assets/reviews/workflow-reader-width/measurements.jsondeleted file mode 100644index 51411252..00000000--- a/docs/assets/reviews/workflow-reader-width/measurements.json+++ /dev/null@@ -1,213 +0,0 @@-{- "baseline": "e23fc2c5c8cf1aaa3864e7966f8b8ec43dc2bebd",- "records": [- {- "name": "five-stage-stack",- "revision": "before",- "screenshot": "five-stage-stack-before.png",- "viewport": [- 1440,- 1000- ],- "theme": "light",- "preset": "signal-flow",- "readerFit": "intrinsic-height",- "svgWidth": 925,- "viewBoxWidth": 768,- "gateMinimumProjectedNodeTextPx": 8,- "scrollY": 0,- "scrollHeight": 1136,- "pageScrollPx": 136,- "overflowX": false,- "zoom": "100%",- "minimumActualNodeFontPx": 12.044229233226837,- "fonts": [- {- "text": "Build preview",- "pixelFont": 12.887325279552716- },- {- "text": "Check format",- "pixelFont": 13.248652156549522- },- {- "text": "Collect input",- "pixelFont": 12.887325279552716- },- {- "text": "Publish result",- "pixelFont": 12.044229233226837- },- {- "text": "Review output",- "pixelFont": 12.887325279552716- }- ],- "dockCoveredNodesAtPageTop": [],- "dockOverlapsSvgAtPageTop": false,- "bottomScroll": {- "scrollY": 136,- "lowestNodeBottom": 596.4901123046875,- "allNodesAboveViewportBottom": true- }- },- {- "name": "five-stage-stack",- "revision": "after",- "screenshot": "five-stage-stack-after.png",- "viewport": [- 1440,- 1000- ],- "theme": "light",- "preset": "signal-flow",- "readerFit": "width-first",- "svgWidth": 1152,- "viewBoxWidth": 768,- "gateMinimumProjectedNodeTextPx": 8,- "scrollY": 0,- "scrollHeight": 1289,- "pageScrollPx": 289,- "overflowX": false,- "zoom": "100%",- "minimumActualNodeFontPx": 15,- "fonts": [- {- "text": "Build preview",- "pixelFont": 16.049999999999997- },- {- "text": "Check format",- "pixelFont": 16.5- },- {- "text": "Collect input",- "pixelFont": 16.049999999999997- },- {- "text": "Publish result",- "pixelFont": 15- },- {- "text": "Review output",- "pixelFont": 16.049999999999997- }- ],- "dockCoveredNodesAtPageTop": [],- "dockOverlapsSvgAtPageTop": true,- "bottomScroll": {- "scrollY": 289,- "lowestNodeBottom": 590.6875,- "allNodesAboveViewportBottom": true- }- },- {- "name": "execution-failure-stack",- "revision": "before",- "screenshot": "execution-failure-stack-before.png",- "viewport": [- 1440,- 1000- ],- "theme": "light",- "preset": "signal-flow",- "readerFit": "intrinsic-height",- "svgWidth": 799,- "viewBoxWidth": 780,- "gateMinimumProjectedNodeTextPx": 8,- "scrollY": 0,- "scrollHeight": 1199,- "pageScrollPx": 199,- "overflowX": false,- "zoom": "100%",- "minimumActualNodeFontPx": 10.243503736413045,- "fonts": [- {- "text": "Execute job",- "pixelFont": 11.26785411005435- },- {- "text": "Store result",- "pixelFont": 11.26785411005435- },- {- "text": "Prepare job",- "pixelFont": 11.26785411005435- },- {- "text": "Inspect error",- "pixelFont": 10.960548997961956- },- {- "text": "Record failure",- "pixelFont": 10.243503736413045- },- {- "text": "Queue retry",- "pixelFont": 11.26785411005435- }- ],- "dockCoveredNodesAtPageTop": [],- "dockOverlapsSvgAtPageTop": false,- "bottomScroll": {- "scrollY": 199,- "lowestNodeBottom": 556.4925537109375,- "allNodesAboveViewportBottom": true- }- },- {- "name": "execution-failure-stack",- "revision": "after",- "screenshot": "execution-failure-stack-after.png",- "viewport": [- 1440,- 1000- ],- "theme": "light",- "preset": "signal-flow",- "readerFit": "width-first",- "svgWidth": 1170,- "viewBoxWidth": 780,- "gateMinimumProjectedNodeTextPx": 8,- "scrollY": 0,- "scrollHeight": 1549,- "pageScrollPx": 549,- "overflowX": false,- "zoom": "100%",- "minimumActualNodeFontPx": 15,- "fonts": [- {- "text": "Execute job",- "pixelFont": 16.5- },- {- "text": "Store result",- "pixelFont": 16.5- },- {- "text": "Prepare job",- "pixelFont": 16.5- },- {- "text": "Inspect error",- "pixelFont": 16.049999999999997- },- {- "text": "Record failure",- "pixelFont": 15- },- {- "text": "Queue retry",- "pixelFont": 16.5- }- ],- "dockCoveredNodesAtPageTop": [],- "dockOverlapsSvgAtPageTop": true,- "bottomScroll": {- "scrollY": 549,- "lowestNodeBottom": 495.6875,- "allNodesAboveViewportBottom": true- }- }- ]-}diff --git a/scripts/capture-workflow-reader-width.mjs b/scripts/capture-workflow-reader-width.mjsdeleted file mode 100644index 896ad047..00000000--- a/scripts/capture-workflow-reader-width.mjs+++ /dev/null@@ -1,69 +0,0 @@-// Public synthetic evidence, fixed input and browser conditions on both revisions.-import fs from 'node:fs';-import assert from 'node:assert/strict';-import path from 'node:path';-import os from 'node:os';-import { fileURLToPath } from 'node:url';-import { execFileSync } from 'node:child_process';-import { ChromeVisualBrowser, findChrome } from '../archify/bin/visual-check.mjs';--const root = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');-const beforeRoot = process.argv[2];-if (!beforeRoot) throw new Error('Usage: node scripts/capture-workflow-reader-width.mjs <baseline-checkout> [output-directory]');-const output = path.resolve(process.argv[3] || path.join(root, 'docs/assets/reviews/workflow-reader-width'));-fs.mkdirSync(output, { recursive: true });-const scratch = fs.mkdtempSync(path.join(os.tmpdir(), 'archify-workflow-width-'));-const browser = new ChromeVisualBrowser(findChrome());-const records = [];-try {- for (const name of ['five-stage-stack', 'execution-failure-stack']) {- const input = path.join(root, 'test/fixtures/reader-readability', `${name}.workflow.json`);- let baselineHtml;- for (const [revision, checkout] of [['before', path.resolve(beforeRoot)], ['after', root]]) {- const artifact = path.join(scratch, `${name}-${revision}.html`);- execFileSync(process.execPath, [path.join(checkout, 'archify/bin/archify.mjs'), 'render', 'workflow', input, artifact, '--quality', 'showcase']);- const html = fs.readFileSync(artifact, 'utf8');- if (revision === 'before') baselineHtml = html;- else assert.equal(html.replace('data-reader-fit="width-first"', 'data-reader-fit="intrinsic-height"'), baselineHtml, 'Only the reader-fit declaration may differ');- const screenshot = `${name}-${revision}.png`;- const metrics = await browser.inspect({ artifactPath: artifact, width: 1440, height: 1000,- theme: 'light', screenshotPath: path.join(output, screenshot) });- const session = await browser.sessionPromise;- const measured = await browser.cdp.send('Runtime.evaluate', { returnByValue: true, expression: `(() => {- const svg = document.querySelector('.diagram-container svg');- const fonts = [...svg.querySelectorAll('text[data-node-label]')].map(el => {- const matrix = el.getScreenCTM();- return {text: el.textContent.trim(), pixelFont: parseFloat(getComputedStyle(el).fontSize) * Math.hypot(matrix.a, matrix.b)};- });- const dock = document.querySelector('.diagram-nav');- const rect = dock && dock.getBoundingClientRect();- const coveredNodes = rect ? [...svg.querySelectorAll('g[data-node-id]')].filter(el => {- const r = el.getBoundingClientRect();- return r.right > rect.left && r.left < rect.right && r.bottom > rect.top && r.top < rect.bottom;- }).map(el => el.getAttribute('data-node-id')) : [];- return {scrollY, scrollHeight: document.documentElement.scrollHeight,- pageScrollPx: document.documentElement.scrollHeight - innerHeight,- overflowX: document.documentElement.scrollWidth > innerWidth,- zoom: document.querySelector('[data-view-percent]')?.textContent || null,- minimumActualNodeFontPx: Math.min(...fonts.map(f => f.pixelFont)), fonts, dockCoveredNodesAtPageTop: coveredNodes,- dockOverlapsSvgAtPageTop: Boolean(rect && svg.getBoundingClientRect().bottom > rect.top && svg.getBoundingClientRect().right > rect.left)};- })()` }, session);- assert.equal(measured.result.value.zoom, '100%');- assert.equal(measured.result.value.scrollY, 0);- assert.equal(measured.result.value.overflowX, false);- const scroll = await browser.cdp.send('Runtime.evaluate', {returnByValue: true, awaitPromise: true, expression: `(async () => {- scrollTo(0, document.documentElement.scrollHeight); await new Promise(r => requestAnimationFrame(() => requestAnimationFrame(r)));- const bottoms = [...document.querySelectorAll('.diagram-container svg g[data-node-id]')].map(el => el.getBoundingClientRect().bottom);- return {scrollY, lowestNodeBottom: Math.max(...bottoms), allNodesAboveViewportBottom: Math.max(...bottoms) <= innerHeight};- })()`}, session);- records.push({name, revision, screenshot, viewport: [1440,1000], theme:'light', preset:'signal-flow',- readerFit: metrics.readerFit, svgWidth: metrics.diagramWidth, viewBoxWidth: metrics.viewBoxWidth,- gateMinimumProjectedNodeTextPx: metrics.minimumProjectedNodeTextPx,- ...measured.result.value, bottomScroll: scroll.result.value});- }- }- fs.writeFileSync(path.join(output, 'measurements.json'), JSON.stringify({baseline: 'e23fc2c5c8cf1aaa3864e7966f8b8ec43dc2bebd', records}, null, 2) + '\n');-} finally {- await browser.close();- fs.rmSync(scratch, {recursive:true, force:true});-}