Skip to content

Turn any idea, plan, or codebase into a beautiful interactive diagram. An agent skill for Claude Code, Codex, and more.

fix: cover deliver-stage meta.output diagnostics and split silent vs unreached defects

momoyeyuaeb0cf2ecc8a
diff --git a/archify/test/repair-rounds.test.mjs b/archify/test/repair-rounds.test.mjs
index df5bb1c5..459d344c 100644
--- a/archify/test/repair-rounds.test.mjs
+++ b/archify/test/repair-rounds.test.mjs
@@ -144,7 +144,7 @@ test('report aggregates disclosure, late discovery, and token cost across receip
defects: [
{ class: 'node-long-label', detected: true, firstSeenRound: 1, firstSeenGate: 'validate', late: false },
{ class: 'title-overflow', detected: true, firstSeenRound: 2, firstSeenGate: 'browser-check', late: true },
- { class: 'subtitle-overflow', detected: false, firstSeenRound: null, firstSeenGate: null, late: false },
+ { class: 'subtitle-overflow', detected: false, silent: true, firstSeenRound: null, firstSeenGate: null, late: false },
],
rounds: [{ diagnostics: [{ code: 'viewer/viewport-overflow', hasSubjectDetail: true, hasEvidence: true, hasSupportedFixes: true }] }],
passed: true,
@@ -163,7 +163,8 @@ test('report aggregates disclosure, late discovery, and token cost across receip
assert.deepEqual(report.overall.roundsToPass, { mean: 2.5, median: 3, max: 3 });
assert.equal(report.overall.disclosure.defects, 4);
assert.equal(report.overall.disclosure.detected, 3);
- assert.equal(report.overall.disclosure.undetected, 1);
+ assert.equal(report.overall.disclosure.silent, 1);
+ assert.equal(report.overall.disclosure.unreached, 0);
assert.equal(report.overall.disclosure.firstRoundDisclosureRate, 0.5);
assert.equal(report.overall.disclosure.lateDiscoveryRate, 1 / 3);
assert.equal(report.overall.disclosure.firstSeenGate['browser-check'], 1);
diff --git a/benchmarks/repair-rounds/benchmark.mjs b/benchmarks/repair-rounds/benchmark.mjs
index 78f52c60..9e0b2f0a 100644
--- a/benchmarks/repair-rounds/benchmark.mjs
+++ b/benchmarks/repair-rounds/benchmark.mjs
@@ -220,15 +220,21 @@ function runCase(manifestCase, fixtures, config) {
lastDocHash = docHash;
}
- const defectResults = injections.map((injection) => ({
- class: injection.class,
- expectedCodes: injection.expectedCodes,
- firstSeenRound: injection.firstSeenRound ?? null,
- firstSeenGate: injection.firstSeenGate ?? null,
- seenCount: injection.seenCount || 0,
- detected: injection.firstSeenRound !== undefined,
- late: LATE_GATES.has(injection.firstSeenGate),
- }));
+ const defectResults = injections.map((injection) => {
+ const detected = injection.firstSeenRound !== undefined;
+ return {
+ class: injection.class,
+ expectedCodes: injection.expectedCodes,
+ firstSeenRound: injection.firstSeenRound ?? null,
+ firstSeenGate: injection.firstSeenGate ?? null,
+ seenCount: injection.seenCount || 0,
+ detected,
+ // a silent defect passed every gate; an unreached defect never surfaced
+ // because the loop stalled on an earlier failure first
+ silent: !detected && passed,
+ late: LATE_GATES.has(injection.firstSeenGate),
+ };
+ });
const receiptTokens = rounds.reduce((sum, round) => sum + round.receiptTokens, 0);
const candidateTokens = rounds.reduce((sum, round) => sum + round.candidateTokens, 0);
@@ -375,7 +381,8 @@ function summarize(manifest, results) {
disclosure: {
defects: defects.length,
detected: detected.length,
- undetected: defects.length - detected.length,
+ silent: defects.filter((defect) => !defect.detected && defect.silent).length,
+ unreached: defects.filter((defect) => !defect.detected && !defect.silent).length,
firstRoundDisclosureRate: defects.length ? firstRound.length / defects.length : 0,
lateDiscoveryRate: detected.length ? late.length / detected.length : 0,
firstSeenGate: byGate,
diff --git a/benchmarks/repair-rounds/defects.mjs b/benchmarks/repair-rounds/defects.mjs
index afa7b1b4..76a7f857 100644
--- a/benchmarks/repair-rounds/defects.mjs
+++ b/benchmarks/repair-rounds/defects.mjs
@@ -57,7 +57,8 @@ const LONG_SUBTITLE = 'QuarterlyCrossRegionalComplianceReconciliationAndSettleme
export const DEFECTS = {
'meta-missing-output': {
appliesTo: ALL_TYPES,
- expectedCodes: { default: ['schema/required'] },
+ // finalize checks meta.output at the deliver gate before validate runs.
+ expectedCodes: { default: ['schema/required', 'output/meta-path-syntax', 'output/path-resolution'] },
inject(doc) {
const restores = [capture(doc, '/meta/output')];
delete doc.meta.output;
diff --git a/benchmarks/repair-rounds/repairs.mjs b/benchmarks/repair-rounds/repairs.mjs
index d04f545b..99cfc97e 100644
--- a/benchmarks/repair-rounds/repairs.mjs
+++ b/benchmarks/repair-rounds/repairs.mjs
@@ -123,6 +123,19 @@ const RULES = [
: null;
},
},
+ {
+ // "set meta.output to a portable relative .html path such as reports/diagram.html"
+ match: (diagnostic) => (diagnostic.code || '').startsWith('output/meta-')
+ && diagnostic.subject?.path === '/meta/output',
+ apply(diagnostic, doc) {
+ const fix = (diagnostic.supportedFixes || [])
+ .find((entry) => /such as (\S+\.html)/.test(entry));
+ const value = fix ? fix.match(/such as (\S+\.html)/)[1] : 'output.html';
+ return setByPointer(doc, '/meta/output', value)
+ ? { detail: `set /meta/output to ${JSON.stringify(value)}` }
+ : null;
+ },
+ },
{
// "...reflow automatic spacing ... so the complete viewBox width is at most
// 1240px (current 2400px; ...)"