Skip to content

Turn any idea, plan, or codebase into a beautiful interactive diagram. An agent skill for Claude Code, Codex, and more.

Require the lifecycle rail browser regression in CI

tt-a1iafe593ab68d8
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index f51d4a50..d1c7829b 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -83,7 +83,7 @@ jobs:
ARCHIFY_CHROME: ${{ steps.setup-chrome.outputs.chrome-path }}
ARCHIFY_CHROME_NO_SANDBOX: '1'
- name: Verify Viewer chrome, camera, motion and input interactions
- run: node --test --test-concurrency=2 test/viewer-chrome-layout.test.mjs test/viewer-camera-browser.test.mjs test/motion-governor-browser.test.mjs test/finder-browser.test.mjs test/intent-trace-browser.test.mjs test/semantic-lens-browser.test.mjs test/route-probe-browser.test.mjs test/guided-views-browser.test.mjs test/focus-browser.test.mjs test/export-browser.test.mjs test/viewer-identifiers-browser.test.mjs
+ run: node --test --test-concurrency=2 test/viewer-chrome-layout.test.mjs test/viewer-camera-browser.test.mjs test/motion-governor-browser.test.mjs test/finder-browser.test.mjs test/intent-trace-browser.test.mjs test/semantic-lens-browser.test.mjs test/route-probe-browser.test.mjs test/guided-views-browser.test.mjs test/focus-browser.test.mjs test/export-browser.test.mjs test/viewer-identifiers-browser.test.mjs test/lifecycle-rail-browser.test.mjs
working-directory: archify
env:
ARCHIFY_CHROME: ${{ steps.setup-chrome.outputs.chrome-path }}
diff --git a/archify/test/lifecycle-rail-browser.test.mjs b/archify/test/lifecycle-rail-browser.test.mjs
index bc2bca42..009225f6 100644
--- a/archify/test/lifecycle-rail-browser.test.mjs
+++ b/archify/test/lifecycle-rail-browser.test.mjs
@@ -10,7 +10,8 @@ import { ChromeVisualBrowser, findChrome } from '../bin/visual-check.mjs';
const __dirname = path.dirname(fileURLToPath(import.meta.url));
const skillRoot = path.resolve(__dirname, '..');
-const chromePath = process.env.ARCHIFY_CHROME ? findChrome() : null;
+const browserRequested = Object.hasOwn(process.env, 'ARCHIFY_CHROME');
+const chromePath = browserRequested ? findChrome() : null;
async function evaluate(browser, sessionId, expression, awaitPromise = false) {
const response = await browser.cdp.send('Runtime.evaluate', {
@@ -50,8 +51,9 @@ async function loadArtifact(browser, artifactPath) {
}
test('lifecycle rail stays ordinary in READ and hides for hover, relationship preview, and committed focus', {
- skip: chromePath ? false : 'Set ARCHIFY_CHROME to run the real browser regression.',
+ skip: browserRequested ? false : 'Set ARCHIFY_CHROME to run the real browser regression.',
}, async () => {
+ assert.ok(chromePath, 'The configured browser regression requires Chrome.');
const tmp = fs.mkdtempSync(path.join(os.tmpdir(), 'archify-lifecycle-rail-browser-'));
const artifact = path.join(tmp, 'agent-run.html');
execFileSync(process.execPath, [