Turn any idea, plan, or codebase into a beautiful interactive diagram. An agent skill for Claude Code, Codex, and more.
HTML agent-skillsai-agentsarchitecture-diagramclaude-codeclaude-skillscodexcoding-agentsdeepseek-harnessdeveloper-toolsdiagramsdiagrams-as-codedsh-pluginflowchartllmmermaidopencodesequence-diagramsoftware-architecturesystem-designvisualization
fix(erd): default the grid and isolate self-relationships
tt-a1id8003e070b0e
diff --git a/archify/renderers/erd/grid.mjs b/archify/renderers/erd/grid.mjsindex 4ec4c88d..7985e705 100644--- a/archify/renderers/erd/grid.mjs+++ b/archify/renderers/erd/grid.mjs@@ -23,7 +23,13 @@ export const DEFAULT_ER_GRID = {export function erGridLayout(er) {const raw = er.layout;- if (!raw || raw.mode !== 'grid') return null;+ // Grid cells without a layout block mean the default grid, not absolute+ // coordinates that were never supplied.+ if (!raw) {+ const gridPlaced = (er.entities || []).some((entity) => Number.isFinite(entity?.row) && Number.isFinite(entity?.col));+ return gridPlaced ? { ...DEFAULT_ER_GRID } : null;+ }+ if (raw.mode !== 'grid') return null;return { ...DEFAULT_ER_GRID, ...raw };}diff --git a/archify/renderers/erd/render-erd.mjs b/archify/renderers/erd/render-erd.mjsindex 24034323..181b5b0c 100644--- a/archify/renderers/erd/render-erd.mjs+++ b/archify/renderers/erd/render-erd.mjs@@ -899,6 +899,10 @@ function entityHeader(entity) {function validateEr() {const problems = [];+ // A self-relationship is reported once below; route checks skip it so they+ // do not suggest side or route repairs for a line that is never drawn.+ const routableRelationships = relationships.map((relationship) => (+ relationship.from === relationship.to ? null : relationship));const headerDetails = [];const domainDetails = [];for (const entity of entities.values()) {@@ -1081,7 +1085,7 @@ function validateEr() {}problems.push(...cleanEndpointSideProblems({- relations: relationships,+ relations: routableRelationships,endpointIds: new Set(entities.keys()),pathFor,diagramType: 'erd',@@ -1091,7 +1095,7 @@ function validateEr() {routeHint: 'keep automatic routing so the renderer can use a side-aware bridge, or set truthful fromSide/toSide',}));problems.push(...cleanFlowProblems({- relations: relationships,+ relations: routableRelationships,obstacles: entities.values(),pathFor,diagramType: 'erd',@@ -1100,7 +1104,7 @@ function validateEr() {routeHint: 'adjust fromSide/toSide, set route/via, or move the entity',}));problems.push(...cleanCrossingProblems({- relations: relationships,+ relations: routableRelationships,endpointIds: new Set(entities.keys()),pathFor,diagramType: 'erd',@@ -1109,7 +1113,7 @@ function validateEr() {routeHint: 'move the entities so unrelated relationships use separate corridors',}));problems.push(...cleanAmbiguousCorridorProblems({- relations: relationships,+ relations: routableRelationships,endpointIds: new Set(entities.keys()),pathFor,diagramType: 'erd',@@ -1118,7 +1122,7 @@ function validateEr() {routeHint: 'give the relationships different fromSide/toSide targets, or move an entity so their corridors differ',}));problems.push(...cleanRouteRhythmProblems({- relations: relationships,+ relations: routableRelationships,endpointIds: new Set(entities.keys()),pathFor,diagramType: 'erd',@@ -1147,7 +1151,7 @@ function validateEr() {}}problems.push(...cleanLabelRouteClearanceProblems({- relations: relationships,+ relations: routableRelationships,labels: labelRects,endpointIds: new Set(entities.keys()),pathFor,diff --git a/test/erd-rendering.test.mjs b/test/erd-rendering.test.mjsindex 4c616975..828707fe 100644--- a/test/erd-rendering.test.mjs+++ b/test/erd-rendering.test.mjs@@ -1138,3 +1138,27 @@ test('a domain band rejects intrusion into another tagged domain', () => {assert.equal(spaced.status, 0, spaced.stderr);}});++test('grid-placed entities without a layout block use the default grid', t => {+ const directory = fs.mkdtempSync(path.join(os.tmpdir(), 'archify-erd-default-grid-'));+ t.after(() => fs.rmSync(directory, { recursive: true, force: true }));+ const diagram = cloneWithoutViews(example);+ delete diagram.layout;+ for (const relationship of diagram.relationships) delete relationship.label;+ const result = render(diagram, directory);+ assert.equal(result.status, 0, result.stderr);+ assert.equal(entityBoxes(fs.readFileSync(result.output, 'utf8')).size, diagram.entities.length);+});++test('a self-relationship reports only its own unsupported-shape problem', t => {+ const directory = fs.mkdtempSync(path.join(os.tmpdir(), 'archify-erd-self-'));+ t.after(() => fs.rmSync(directory, { recursive: true, force: true }));+ const diagram = cloneWithoutViews(example);+ diagram.meta.quality_profile = 'showcase';+ const entity = diagram.entities[0].id;+ diagram.relationships.push({ id: 'self', from: entity, to: entity, label: 'parent', fromCardinality: 'many', toCardinality: 'one' });+ const result = render(diagram, directory);+ assert.notEqual(result.status, 0);+ assert.match(result.stderr, /connects entity "[^"]+" to itself/);+ assert.doesNotMatch(result.stderr, /relationships\[\d+\] id "self"/);+});