Turn any idea, plan, or codebase into a beautiful interactive diagram. An agent skill for Claude Code, Codex, and more.
HTML agent-skillsai-agentsarchitecture-diagramclaude-codeclaude-skillscodexcoding-agentsdeepseek-harnessdeveloper-toolsdiagramsdiagrams-as-codedsh-pluginflowchartllmmermaidopencodesequence-diagramsoftware-architecturesystem-designvisualization
fix(viewer): settle and clean up WebM recording failures
To3akaRindb3739d4b696
diff --git a/CHANGELOG.md b/CHANGELOG.mdindex 451f85cd..c41e2add 100644--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -6,6 +6,10 @@ All notable changes are documented here. Format loosely follows [Keep a Changelo> Development identity: `v3.0.2-dev.1`. Not a stable release.+### Fixed++- **WebM 录制失败清理 (#622)。** 画布、捕获流、编码器启动、逐帧绘制或停止失败时,录制 Promise 现在会拒绝并释放已创建的流、临时 URL、动画帧和定时器;晚到的编码事件不能再将失败录制报告为成功。正常编码与最佳努力的最终片段 flush 行为保持不变。+## [3.0.1] — 2026-09-28### Changeddiff --git a/archify/assets/template.html b/archify/assets/template.htmlindex 948094d3..b49f9a08 100644--- a/archify/assets/template.html+++ b/archify/assets/template.html@@ -6548,7 +6548,6 @@ OTHER DEALINGS IN THE FONT SOFTWARE.var vb = svg.viewBox.baseVal;var scale = Math.min(1, 1280 / vb.width);var data = serializeSvg(scale);- var sourceUrl = URL.createObjectURL(new Blob([data.svgString], { type: 'image/svg+xml;charset=utf-8' }));function createMotionScene(root) {var rootMatrix = root.getCTM ? root.getCTM() : null;@@ -6700,73 +6699,99 @@ OTHER DEALINGS IN THE FONT SOFTWARE.var motionScene = createMotionScene(svg);return new Promise(function (resolve, reject) {- var backgroundImage = new Image();- backgroundImage.onload = function () {- var canvas = document.createElement('canvas');- canvas.width = Math.max(2, Math.round(data.width / 2) * 2);- canvas.height = Math.max(2, Math.round(data.height / 2) * 2);- var ctx = canvas.getContext('2d');- var stream = canvas.captureStream(fps);- var mime = motionMimeType();- var recorder;- try {- recorder = new MediaRecorder(stream, { mimeType: mime, videoBitsPerSecond: 6000000 });- } catch (err) {- URL.revokeObjectURL(sourceUrl);- stream.getTracks().forEach(function (track) { track.stop(); });- reject(err);- return;- }- var chunks = [];- var raf = 0;- var stopped = false;- var startedAt = performance.now();- function cleanup() {- if (stopped) return;- stopped = true;- cancelAnimationFrame(raf);- URL.revokeObjectURL(sourceUrl);- stream.getTracks().forEach(function (track) { track.stop(); });+ var sourceUrl = null;+ var backgroundImage = null;+ var stream = null;+ var recorder = null;+ var raf = 0;+ var durationTimer = 0;+ var flushTimer = 0;+ var settled = false;++ function finish(error, blob) {+ if (settled) return;+ // 先锁定终态:停止录制和释放流可能产生晚到的编码事件。+ settled = true;+ cancelAnimationFrame(raf);+ clearTimeout(durationTimer);+ clearTimeout(flushTimer);+ if (backgroundImage) {+ backgroundImage.onload = null;+ backgroundImage.onerror = null;}- function draw(now) {- var elapsed = Math.max(0, ((Number(now) || performance.now()) - startedAt) / 1000);- drawMotionFrame(ctx, backgroundImage, motionScene, elapsed);- raf = requestAnimationFrame(draw);+ if (recorder) {+ recorder.ondataavailable = null;+ recorder.onerror = null;+ recorder.onstop = null;+ try { if (recorder.state !== 'inactive') recorder.stop(); } catch (_) {}}- recorder.ondataavailable = function (event) {- if (event.data && event.data.size) chunks.push(event.data);- };- recorder.onerror = function (event) {- cleanup();- reject(event.error || exportError('viewer.export.error.mediaRecorder'));+ if (stream) stream.getTracks().forEach(function (track) { track.stop(); });+ if (sourceUrl) URL.revokeObjectURL(sourceUrl);+ if (blob) resolve(blob);+ else reject(error);+ }++ try {+ sourceUrl = URL.createObjectURL(new Blob([data.svgString], { type: 'image/svg+xml;charset=utf-8' }));+ backgroundImage = new Image();+ backgroundImage.onload = function () {+ if (settled) return;+ try {+ var canvas = document.createElement('canvas');+ canvas.width = Math.max(2, Math.round(data.width / 2) * 2);+ canvas.height = Math.max(2, Math.round(data.height / 2) * 2);+ var ctx = canvas.getContext('2d');+ if (!ctx) throw exportError('viewer.export.error.contextUnavailable', { label: 'WebM' });+ stream = canvas.captureStream(fps);+ var mime = motionMimeType();+ recorder = new MediaRecorder(stream, { mimeType: mime, videoBitsPerSecond: 6000000 });+ var chunks = [];+ var startedAt = performance.now();+ function draw(now) {+ if (settled) return;+ try {+ var elapsed = Math.max(0, ((Number(now) || performance.now()) - startedAt) / 1000);+ drawMotionFrame(ctx, backgroundImage, motionScene, elapsed);+ raf = requestAnimationFrame(draw);+ } catch (error) { finish(error); }+ }+ recorder.ondataavailable = function (event) {+ if (!settled && event.data && event.data.size) chunks.push(event.data);+ };+ recorder.onerror = function (event) {+ finish(event.error || exportError('viewer.export.error.mediaRecorder'));+ };+ recorder.onstop = function () {+ if (settled) return;+ try {+ var blob = new Blob(chunks, { type: recorder.mimeType || mime });+ if (!blob.size) throw exportError('viewer.export.error.emptyWebm');+ finish(null, blob);+ } catch (error) { finish(error); }+ };+ drawMotionFrame(ctx, backgroundImage, motionScene, 0);+ recorder.start(250);+ if (settled) return;+ startedAt = performance.now();+ raf = requestAnimationFrame(draw);+ durationTimer = setTimeout(function () {+ if (settled || recorder.state === 'inactive') return;+ // 保留最佳努力的编码器 flush;失败后仍通过 stop 收集最后的片段。+ try { recorder.requestData(); } catch (_) {}+ if (settled) return;+ flushTimer = setTimeout(function () {+ if (settled) return;+ try { if (recorder.state !== 'inactive') recorder.stop(); }+ catch (error) { finish(error); }+ }, 120);+ }, duration);+ } catch (error) { finish(error); }};- recorder.onstop = function () {- cleanup();- var blob = new Blob(chunks, { type: recorder.mimeType || mime });- if (!blob.size) reject(exportError('viewer.export.error.emptyWebm'));- else resolve(blob);+ backgroundImage.onerror = function () {+ finish(exportError('viewer.export.error.webmBackground'));};- drawMotionFrame(ctx, backgroundImage, motionScene, 0);- recorder.start(250);- startedAt = performance.now();- raf = requestAnimationFrame(draw);- setTimeout(function () {- if (recorder.state === 'inactive') return;- // Chromium normally emits the final chunk during stop(), but- // some embedded browser shells need an explicit encoder flush- // first. Keep the short grace window bounded and harmless for- // browsers that already delivered timeslice chunks.- try { recorder.requestData(); } catch (_) {}- setTimeout(function () {- if (recorder.state !== 'inactive') recorder.stop();- }, 120);- }, duration);- };- backgroundImage.onerror = function () {- URL.revokeObjectURL(sourceUrl);- reject(exportError('viewer.export.error.webmBackground'));- };- backgroundImage.src = sourceUrl;+ backgroundImage.src = sourceUrl;+ } catch (error) { finish(error); }});}diff --git a/archify/test/export-browser.test.mjs b/archify/test/export-browser.test.mjsindex c4d7742d..f0089429 100644--- a/archify/test/export-browser.test.mjs+++ b/archify/test/export-browser.test.mjs@@ -47,8 +47,8 @@ test('Export preserves menu, clipboard, semantic cards and recording lifecycles'console.error=(...args)=>exportConsole.push(args.map(String).join(' '));window.exportUrls=new Map();window.exportDownloads=[];window.exportTracks=[];window.exportCancelled=[];const create=URL.createObjectURL.bind(URL),revoke=URL.revokeObjectURL.bind(URL);- URL.createObjectURL=blob=>{const url=create(blob);exportUrls.set(url,{blob,revoked:false});return url;};- URL.revokeObjectURL=url=>{const item=exportUrls.get(url);if(item)item.revoked=true;revoke(url);};+ URL.createObjectURL=blob=>{const url=create(blob);exportUrls.set(url,{blob,revoked:false,revocations:0});return url;};+ URL.revokeObjectURL=url=>{const item=exportUrls.get(url);if(item){item.revoked=true;item.revocations++;}revoke(url);};const click=HTMLAnchorElement.prototype.click;HTMLAnchorElement.prototype.click=function(){if(this.download){exportDownloads.push({name:this.download,blob:exportUrls.get(this.href).blob,attached:this.isConnected});return;}return click.call(this);};const capture=HTMLCanvasElement.prototype.captureStream;@@ -365,6 +365,115 @@ test('Export preserves menu, clipboard, semantic cards and recording lifecycles'await run('exportWait(()=>[...exportUrls.values()].every(u=>u.revoked))');});+ // 只替换指定的浏览器故障边界;图片、画布、流和其余编码过程仍使用真实实现。+ async function recordingFault(fault) {+ await run(`window.webmOriginals={Image,MediaRecorder,capture:HTMLCanvasElement.prototype.captureStream,+ context:HTMLCanvasElement.prototype.getContext,draw:CanvasRenderingContext2D.prototype.drawImage};+ window.webmRecorders=[];window.webmLateEvents=0;window.webmDraws=0;+ window.restoreWebmFault=()=>{window.Image=webmOriginals.Image;window.MediaRecorder=webmOriginals.MediaRecorder;+ HTMLCanvasElement.prototype.captureStream=webmOriginals.capture;+ HTMLCanvasElement.prototype.getContext=webmOriginals.context;+ CanvasRenderingContext2D.prototype.drawImage=webmOriginals.draw;};+ window.webmFault=${JSON.stringify(fault)};+ window.webmFailure=new Error('recording boundary: '+webmFault);+ if(webmFault==='image')window.Image=class {set src(value){queueMicrotask(()=>this.onerror&&this.onerror());}};+ if(webmFault==='context-null')HTMLCanvasElement.prototype.getContext=()=>null;+ if(webmFault==='context-throw')HTMLCanvasElement.prototype.getContext=()=>{throw webmFailure;};+ if(webmFault==='capture')HTMLCanvasElement.prototype.captureStream=()=>{throw webmFailure;};+ if(webmFault==='first-frame'||webmFault==='later-frame')CanvasRenderingContext2D.prototype.drawImage=function(...args){+ if(++webmDraws>=(webmFault==='first-frame'?1:2))throw webmFailure;+ return webmOriginals.draw.apply(this,args);+ };+ window.MediaRecorder=class extends webmOriginals.MediaRecorder {+ constructor(...args){super(...args);webmRecorders.push(this);this.stopCalls=0;}+ start(...args){+ if(webmFault==='start')throw webmFailure;+ const value=super.start(...args);+ if(webmFault==='async-error'){+ const lateData=this.ondataavailable,lateStop=this.onstop,lateError=this.onerror;+ setTimeout(()=>{+ this.dispatchEvent(new ErrorEvent('error',{error:webmFailure}));+ // 模拟错误之后已经排队的回调,不能恢复成功状态或重复清理资源。+ setTimeout(()=>{lateData({data:new Blob(['late'])});lateStop();lateError({error:new Error('late error')});webmLateEvents++;},20);+ },20);+ }+ return value;+ }+ requestData(){if(webmFault==='flush')throw webmFailure;return super.requestData();}+ stop(){this.stopCalls++;if(webmFault==='stop')throw webmFailure;return super.stop();}+ };`);+ }+ async function recordingOutcome(expression = 'Archify.motion.recordWebm({duration:250,fps:10})') {+ return run(`Promise.race([+ ${expression}.then(blob=>({status:'resolved',bytes:blob.size}),error=>({status:'rejected',message:error.message})),+ new Promise(resolve=>setTimeout(()=>resolve({status:'pending'}),2000))+ ])`);+ }++ for (const fault of ['image','context-null','context-throw','capture','start','first-frame','later-frame','async-error','stop']) {+ await t.test('recording settles and releases its resources after ' + fault, async () => {+ await load();+ await recordingFault(fault);+ const outcome = await recordingOutcome();+ assert.equal(outcome.status,'rejected',JSON.stringify(outcome));+ if (!['image','context-null'].includes(fault)) assert.equal(outcome.message,'recording boundary: '+fault);+ if (fault === 'async-error') await run('exportWait(()=>webmLateEvents===1)');+ const state=await record('webm-boundary-'+fault);+ assert.deepEqual(state.downloads,[]);+ assert.ok(state.urls.length>0);assert.ok(state.urls.every(u=>u.revoked));+ assert.ok(state.tracks.every(s=>s==='ended'));+ assert.deepEqual(await run('[...exportUrls.values()].map(u=>u.revocations)'),[1]);+ if (fault === 'async-error') {+ assert.deepEqual(await run('webmRecorders.map(r=>r.state)'),['inactive']);+ const stops=await run('webmRecorders.map(r=>r.stopCalls)');+ await run('new Promise(resolve=>setTimeout(resolve,400))');+ assert.deepEqual(await run('webmRecorders.map(r=>r.stopCalls)'),stops,'完成后定时器不能再次停止录制');+ }+ });+ }++ await t.test('recording failures reach the menu receipt and a later same-page recording succeeds', async () => {+ await load();+ await recordingFault('capture');+ const outcome=await recordingOutcome(`Archify.exportMenu.run('webm').then(()=>new Blob())`);+ assert.equal(outcome.status,'resolved','菜单应处理失败并完成调用');+ const failed=await record('webm-menu-boundary');+ assert.equal(failed.receipt['data-last-export-error-format'],'webm');+ assert.equal(failed.receipt['data-last-export-error'],'recording boundary: capture');+ assert.equal(failed.receipt['data-last-export-format'],undefined);+ assert.deepEqual(failed.downloads,[]);+ assert.equal(await run(`document.querySelector('[data-format="webm"]').disabled`),true);+ await run('restoreWebmFault()');+ const retry=await recordingOutcome();+ assert.equal(retry.status,'resolved');assert.ok(retry.bytes>0);+ const retried=await record('webm-recovered');+ assert.ok(retried.urls.every(u=>u.revoked));assert.ok(retried.tracks.every(s=>s==='ended'));+ assert.deepEqual(await run('[...exportUrls.values()].map(u=>u.revocations)'),[1,1]);+ });++ await t.test('recording keeps flush best-effort and isolates overlapping calls', async () => {+ await load();+ await recordingFault('flush');+ const flushed=await recordingOutcome();+ assert.equal(flushed.status,'resolved');assert.ok(flushed.bytes>0);+ assert.ok((await record('webm-flush')).urls.every(u=>u.revoked));+ await run('restoreWebmFault()');+ const parallel=await run(`(async()=>{+ const NativeRecorder=MediaRecorder;let sequence=0;+ window.MediaRecorder=class extends NativeRecorder {+ constructor(...args){super(...args);this.fail=sequence++===0;}+ start(...args){const result=super.start(...args);if(this.fail)setTimeout(()=>this.dispatchEvent(new ErrorEvent('error',{error:new Error('first recording failed')})),20);return result;}+ };+ const observe=promise=>promise.then(blob=>({status:'resolved',bytes:blob.size}),error=>({status:'rejected',message:error.message}));+ return await Promise.all([observe(Archify.motion.recordWebm({duration:250,fps:10})),observe(Archify.motion.recordWebm({duration:500,fps:10}))]);+ })()`);+ assert.equal(parallel[0].status,'rejected');assert.equal(parallel[0].message,'first recording failed');+ assert.equal(parallel[1].status,'resolved');assert.ok(parallel[1].bytes>0);+ const state=await record('webm-parallel');+ assert.ok(state.tracks.every(s=>s==='ended'));assert.ok(state.urls.every(u=>u.revoked));+ assert.deepEqual(await run('[...exportUrls.values()].map(u=>u.revocations)'),[1,1,1]);+ });+await t.test('recording constructor/error/empty failures clean up and public run disables WebM', async () => {for (const fault of ['constructor','error','empty']) {await load();diff --git a/viewer/README.md b/viewer/README.mdindex 73402856..44aa7396 100644--- a/viewer/README.md+++ b/viewer/README.md@@ -832,5 +832,13 @@ rasterization, clipboard and recording remain owned by Export. Its existingcallers use the same paths and return fields. Tests exercise final browser exports;isolated clone tests supplement them for restoration and idempotence.+## WebM 录制失败与资源生命周期++`Archify.motion.recordWebm()` 的每次调用独立拥有背景 URL、捕获流、编码器、动画帧和停止定时器。背景加载、画布或流创建、编码器启动、绘制、编码事件以及停止失败时,返回的 Promise 拒绝,资源在同一次终态清理中释放;晚到的事件不会恢复成功状态。正常停止后只有非空 WebM 才能成功返回,`requestData()` 失败仍允许通过 `stop()` 完成最佳努力的最终片段收集。++菜单沿用原有错误提示、失败回执与 WebM 禁用规则;接口调用之间互不清理对方资源。SVG 序列化发生在录制 Promise 之前,其同步异常契约保持不变。修复后的行为仅存在于重新生成的 HTML 中。++回归入口:在 `archify/` 下设置 `ARCHIFY_CHROME` 后运行 `node --test test/export-browser.test.mjs`。该套件覆盖真实编码、故障边界、晚到事件、同页重试及并行调用;`node test/webm-artifact.smoke.mjs` 另行验证视频解码与实际帧变化。+For required browser, output and package evidence, follow[Contributing](../CONTRIBUTING.md#local-setup-and-verification).diff --git a/viewer/export.js b/viewer/export.jsindex 72d15d83..8cdcd667 100644--- a/viewer/export.js+++ b/viewer/export.js@@ -800,7 +800,6 @@var vb = svg.viewBox.baseVal;var scale = Math.min(1, 1280 / vb.width);var data = serializeSvg(scale);- var sourceUrl = URL.createObjectURL(new Blob([data.svgString], { type: 'image/svg+xml;charset=utf-8' }));function createMotionScene(root) {var rootMatrix = root.getCTM ? root.getCTM() : null;@@ -952,73 +951,99 @@var motionScene = createMotionScene(svg);return new Promise(function (resolve, reject) {- var backgroundImage = new Image();- backgroundImage.onload = function () {- var canvas = document.createElement('canvas');- canvas.width = Math.max(2, Math.round(data.width / 2) * 2);- canvas.height = Math.max(2, Math.round(data.height / 2) * 2);- var ctx = canvas.getContext('2d');- var stream = canvas.captureStream(fps);- var mime = motionMimeType();- var recorder;- try {- recorder = new MediaRecorder(stream, { mimeType: mime, videoBitsPerSecond: 6000000 });- } catch (err) {- URL.revokeObjectURL(sourceUrl);- stream.getTracks().forEach(function (track) { track.stop(); });- reject(err);- return;- }- var chunks = [];- var raf = 0;- var stopped = false;- var startedAt = performance.now();- function cleanup() {- if (stopped) return;- stopped = true;- cancelAnimationFrame(raf);- URL.revokeObjectURL(sourceUrl);- stream.getTracks().forEach(function (track) { track.stop(); });+ var sourceUrl = null;+ var backgroundImage = null;+ var stream = null;+ var recorder = null;+ var raf = 0;+ var durationTimer = 0;+ var flushTimer = 0;+ var settled = false;++ function finish(error, blob) {+ if (settled) return;+ // 先锁定终态:停止录制和释放流可能产生晚到的编码事件。+ settled = true;+ cancelAnimationFrame(raf);+ clearTimeout(durationTimer);+ clearTimeout(flushTimer);+ if (backgroundImage) {+ backgroundImage.onload = null;+ backgroundImage.onerror = null;}- function draw(now) {- var elapsed = Math.max(0, ((Number(now) || performance.now()) - startedAt) / 1000);- drawMotionFrame(ctx, backgroundImage, motionScene, elapsed);- raf = requestAnimationFrame(draw);+ if (recorder) {+ recorder.ondataavailable = null;+ recorder.onerror = null;+ recorder.onstop = null;+ try { if (recorder.state !== 'inactive') recorder.stop(); } catch (_) {}}- recorder.ondataavailable = function (event) {- if (event.data && event.data.size) chunks.push(event.data);- };- recorder.onerror = function (event) {- cleanup();- reject(event.error || exportError('viewer.export.error.mediaRecorder'));+ if (stream) stream.getTracks().forEach(function (track) { track.stop(); });+ if (sourceUrl) URL.revokeObjectURL(sourceUrl);+ if (blob) resolve(blob);+ else reject(error);+ }++ try {+ sourceUrl = URL.createObjectURL(new Blob([data.svgString], { type: 'image/svg+xml;charset=utf-8' }));+ backgroundImage = new Image();+ backgroundImage.onload = function () {+ if (settled) return;+ try {+ var canvas = document.createElement('canvas');+ canvas.width = Math.max(2, Math.round(data.width / 2) * 2);+ canvas.height = Math.max(2, Math.round(data.height / 2) * 2);+ var ctx = canvas.getContext('2d');+ if (!ctx) throw exportError('viewer.export.error.contextUnavailable', { label: 'WebM' });+ stream = canvas.captureStream(fps);+ var mime = motionMimeType();+ recorder = new MediaRecorder(stream, { mimeType: mime, videoBitsPerSecond: 6000000 });+ var chunks = [];+ var startedAt = performance.now();+ function draw(now) {+ if (settled) return;+ try {+ var elapsed = Math.max(0, ((Number(now) || performance.now()) - startedAt) / 1000);+ drawMotionFrame(ctx, backgroundImage, motionScene, elapsed);+ raf = requestAnimationFrame(draw);+ } catch (error) { finish(error); }+ }+ recorder.ondataavailable = function (event) {+ if (!settled && event.data && event.data.size) chunks.push(event.data);+ };+ recorder.onerror = function (event) {+ finish(event.error || exportError('viewer.export.error.mediaRecorder'));+ };+ recorder.onstop = function () {+ if (settled) return;+ try {+ var blob = new Blob(chunks, { type: recorder.mimeType || mime });+ if (!blob.size) throw exportError('viewer.export.error.emptyWebm');+ finish(null, blob);+ } catch (error) { finish(error); }+ };+ drawMotionFrame(ctx, backgroundImage, motionScene, 0);+ recorder.start(250);+ if (settled) return;+ startedAt = performance.now();+ raf = requestAnimationFrame(draw);+ durationTimer = setTimeout(function () {+ if (settled || recorder.state === 'inactive') return;+ // 保留最佳努力的编码器 flush;失败后仍通过 stop 收集最后的片段。+ try { recorder.requestData(); } catch (_) {}+ if (settled) return;+ flushTimer = setTimeout(function () {+ if (settled) return;+ try { if (recorder.state !== 'inactive') recorder.stop(); }+ catch (error) { finish(error); }+ }, 120);+ }, duration);+ } catch (error) { finish(error); }};- recorder.onstop = function () {- cleanup();- var blob = new Blob(chunks, { type: recorder.mimeType || mime });- if (!blob.size) reject(exportError('viewer.export.error.emptyWebm'));- else resolve(blob);+ backgroundImage.onerror = function () {+ finish(exportError('viewer.export.error.webmBackground'));};- drawMotionFrame(ctx, backgroundImage, motionScene, 0);- recorder.start(250);- startedAt = performance.now();- raf = requestAnimationFrame(draw);- setTimeout(function () {- if (recorder.state === 'inactive') return;- // Chromium normally emits the final chunk during stop(), but- // some embedded browser shells need an explicit encoder flush- // first. Keep the short grace window bounded and harmless for- // browsers that already delivered timeslice chunks.- try { recorder.requestData(); } catch (_) {}- setTimeout(function () {- if (recorder.state !== 'inactive') recorder.stop();- }, 120);- }, duration);- };- backgroundImage.onerror = function () {- URL.revokeObjectURL(sourceUrl);- reject(exportError('viewer.export.error.webmBackground'));- };- backgroundImage.src = sourceUrl;+ backgroundImage.src = sourceUrl;+ } catch (error) { finish(error); }});}