Skip to content

Turn any idea, plan, or codebase into a beautiful interactive diagram. An agent skill for Claude Code, Codex, and more.

refactor: consolidate repeated viewport-overflow diagnostics in finalize receipts

momoyeyudecf39204810
diff --git a/archify/bin/finalize.mjs b/archify/bin/finalize.mjs
index 4407059b..3019d886 100644
--- a/archify/bin/finalize.mjs
+++ b/archify/bin/finalize.mjs
@@ -370,6 +370,44 @@ function stageStatus(stage, exitCode, receipt, quality) {
return exitCode === 0 && validStageReceipt(stage, receipt, quality) ? 'pass' : 'fail';
}
+function consolidateDiagnostics(diagnostics) {
+ const result = [];
+ const seen = new Set();
+ const overflow = [];
+ let overflowIndex = -1;
+ for (const diagnostic of diagnostics || []) {
+ if (diagnostic?.code === 'viewer/viewport-overflow') {
+ if (overflowIndex < 0) overflowIndex = result.length;
+ overflow.push(diagnostic);
+ continue;
+ }
+ const key = `${diagnostic?.code}${diagnostic?.message}`;
+ if (seen.has(key)) continue;
+ seen.add(key);
+ result.push(diagnostic);
+ }
+ if (overflow.length > 1) {
+ const first = overflow[0];
+ result.splice(overflowIndex, 0, {
+ ...first,
+ message: `The rendered artifact overflows ${overflow.length} viewport/theme combinations.`,
+ evidence: {
+ overflows: overflow.map((entry) => ({
+ viewport: entry.subject?.viewport,
+ scrollWidth: entry.evidence?.scrollWidth,
+ scrollHeight: entry.evidence?.scrollHeight,
+ overflowX: entry.evidence?.overflowX,
+ overflowY: entry.evidence?.overflowY,
+ overflowDisposition: entry.evidence?.overflowDisposition,
+ })),
+ },
+ });
+ } else if (overflow.length === 1) {
+ result.splice(overflowIndex, 0, overflow[0]);
+ }
+ return result;
+}
+
function failureDiagnostics(stage, result, receipt, quality) {
if (Array.isArray(receipt?.diagnostics) && receipt.diagnostics.length) return receipt.diagnostics;
const invalidReceipt = (result.status ?? 1) === 0 && !validStageReceipt(stage, receipt, quality);
@@ -839,7 +877,9 @@ export async function runFinalize({
if (status !== 'pass') {
exitCode = status === 'skipped' ? 2 : (code || 1);
receipt.status = status;
- receipt.diagnostics = stageDiagnostics || failureDiagnostics(stage, result, stageReceipt, quality);
+ receipt.diagnostics = consolidateDiagnostics(
+ stageDiagnostics || failureDiagnostics(stage, result, stageReceipt, quality),
+ );
receipt.failedStage = stage === 'deliver'
&& receipt.stages.validate.status === 'fail' ? 'validate' : stage;
break;