Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

test: cut the jsdom style work that times out UI suites under load (#10285)

Christopher Chedeau089f7a078e2e
diff --git a/packages/core/src/DateTimeInput/DateTimeInputTouch.test.tsx b/packages/core/src/DateTimeInput/DateTimeInputTouch.test.tsx
index 2f65d8d054..3b8b590b6c 100644
--- a/packages/core/src/DateTimeInput/DateTimeInputTouch.test.tsx
+++ b/packages/core/src/DateTimeInput/DateTimeInputTouch.test.tsx
@@ -29,6 +29,7 @@ import {Profiler, useState} from 'react';
import * as stylex from '@stylexjs/stylex';
import {readFileSync} from 'node:fs';
import {render, screen, fireEvent, within} from '@testing-library/react';
+import {getOnlyButton} from '../__tests__/fastRoleQueries';
import {InternationalizationProvider} from '../i18n';
import {DateTimeInput as CoreDateTimeInput} from './DateTimeInput';
import type {DateTimeInputProps, ISODateTimeString} from './DateTimeInput';
@@ -349,13 +350,13 @@ describe('DateTimeInput touch surface', () => {
expect(dateField()).toHaveAttribute('aria-expanded', 'true');
expect(timeField()).toHaveAttribute('aria-expanded', 'false');
- fireEvent.click(screen.getByRole('button', {name: 'Save date'}));
+ fireEvent.click(getOnlyButton('Save date'));
expect(screen.getByRole('radio', {name: 'Time'})).toHaveAttribute(
'aria-checked',
'true',
);
- fireEvent.click(screen.getByRole('button', {name: 'Save'}));
- fireEvent.click(screen.getByRole('button', {name: 'Open calendar'}));
+ fireEvent.click(getOnlyButton('Save'));
+ fireEvent.click(getOnlyButton('Open calendar'));
expect(screen.getByRole('radio', {name: 'Date'})).toHaveAttribute(
'aria-checked',
'true',
@@ -372,8 +373,8 @@ describe('DateTimeInput touch surface', () => {
expect(dateField()).toHaveAttribute('aria-expanded', 'false');
expect(timeField()).toHaveAttribute('aria-expanded', 'true');
- fireEvent.click(screen.getByRole('button', {name: 'Save'}));
- fireEvent.click(screen.getByRole('button', {name: 'Open Meeting time'}));
+ fireEvent.click(getOnlyButton('Save'));
+ fireEvent.click(getOnlyButton('Open Meeting time'));
expect(screen.getByRole('radio', {name: 'Time'})).toHaveAttribute(
'aria-checked',
'true',
@@ -394,8 +395,8 @@ describe('DateTimeInput touch surface', () => {
'aria-checked',
'true',
);
- fireEvent.click(screen.getByRole('button', {name: 'Save date'}));
- fireEvent.click(screen.getByRole('button', {name: 'Save'}));
+ fireEvent.click(getOnlyButton('Save date'));
+ fireEvent.click(getOnlyButton('Save'));
fireEvent.click(timeSegment());
expect(screen.getByRole('radio', {name: 'Time'})).toHaveAttribute(
@@ -418,8 +419,8 @@ describe('DateTimeInput touch surface', () => {
'true',
);
- fireEvent.click(screen.getByRole('button', {name: 'Save date'}));
- fireEvent.click(screen.getByRole('button', {name: 'Save'}));
+ fireEvent.click(getOnlyButton('Save date'));
+ fireEvent.click(getOnlyButton('Save'));
fireEvent.keyDown(timeField(), {key: ' '});
expect(screen.getByRole('radio', {name: 'Time'})).toHaveAttribute(
'aria-checked',
@@ -461,9 +462,7 @@ describe('DateTimeInput touch surface', () => {
render(<DateTimeInput label="Meeting" onChange={onChange} />);
openDateSheet();
- fireEvent.click(
- screen.getByRole('button', {name: 'Saturday, March 21, 2026'}),
- );
+ fireEvent.click(getOnlyButton('Saturday, March 21, 2026'));
expect(onChange).toHaveBeenCalledWith('2026-03-21T09:30');
expect(screen.getByRole('radio', {name: 'Date'})).toHaveAttribute(
@@ -487,9 +486,7 @@ describe('DateTimeInput touch surface', () => {
expect(onChange).not.toHaveBeenCalled();
fireEvent.click(screen.getByRole('radio', {name: 'Date'}));
- fireEvent.click(
- screen.getByRole('button', {name: 'Saturday, March 21, 2026'}),
- );
+ fireEvent.click(getOnlyButton('Saturday, March 21, 2026'));
expect(onChange).toHaveBeenCalledWith('2026-03-21T15:45');
});
});
@@ -517,7 +514,7 @@ describe('DateTimeInput touch surface', () => {
fireEvent.click(optionIn('Minute', '45'));
expect(timeField()).toHaveValue('3:45 PM');
- fireEvent.click(screen.getByRole('button', {name: 'Save'}));
+ fireEvent.click(getOnlyButton('Save'));
expect(timeField()).toHaveValue('');
});
@@ -621,7 +618,7 @@ describe('DateTimeInput touch surface', () => {
render(<DateTimeInput label="Meeting" onChange={() => {}} />);
openDateSheet();
- fireEvent.click(screen.getByRole('button', {name: 'Next month'}));
+ fireEvent.click(getOnlyButton('Next month'));
expect(screen.getByText('April 2026')).toBeInTheDocument();
switchToTimePanel();
@@ -702,9 +699,7 @@ describe('DateTimeInput touch surface', () => {
fireEvent.click(optionIn('Hour', '3'));
fireEvent.click(screen.getByRole('radio', {name: 'Date'}));
- fireEvent.click(
- screen.getByRole('button', {name: 'Saturday, March 21, 2026'}),
- );
+ fireEvent.click(getOnlyButton('Saturday, March 21, 2026'));
expect(onChange).toHaveBeenCalledWith('2026-03-21T09:00');
});
@@ -721,9 +716,7 @@ describe('DateTimeInput touch surface', () => {
/>,
);
openDateSheet();
- const disabledDay = screen.getByRole('button', {
- name: 'Saturday, March 21, 2026',
- });
+ const disabledDay = getOnlyButton('Saturday, March 21, 2026');
expect(disabledDay).toHaveAttribute('aria-disabled', 'true');
fireEvent.click(disabledDay);
@@ -743,7 +736,7 @@ describe('DateTimeInput touch surface', () => {
);
const field = openDateSheet();
- fireEvent.click(screen.getByRole('button', {name: 'Reset'}));
+ fireEvent.click(getOnlyButton('Reset'));
expect(onChange).toHaveBeenCalledWith(undefined);
expect(field).toHaveAttribute('aria-expanded', 'true');
expect(screen.getByRole('radio', {name: 'Date'})).toHaveAttribute(
@@ -757,7 +750,7 @@ describe('DateTimeInput touch surface', () => {
withMonthLayout(() => {
render(<ControlledDateTimeInput />);
openDateSheet();
- const saveDateButton = screen.getByRole('button', {name: 'Save date'});
+ const saveDateButton = getOnlyButton('Save date');
expect(saveDateButton).toBeDisabled();
fireEvent.click(saveDateButton);
@@ -774,12 +767,10 @@ describe('DateTimeInput touch surface', () => {
withMonthLayout(() => {
render(<ControlledDateTimeInput />);
openDateSheet();
- const saveDateButton = screen.getByRole('button', {name: 'Save date'});
+ const saveDateButton = getOnlyButton('Save date');
expect(saveDateButton).toBeDisabled();
- fireEvent.click(
- screen.getByRole('button', {name: 'Saturday, March 21, 2026'}),
- );
+ fireEvent.click(getOnlyButton('Saturday, March 21, 2026'));
expect(dateField()).toHaveValue('March 21, 2026');
expect(saveDateButton).not.toBeDisabled();
@@ -803,10 +794,10 @@ describe('DateTimeInput touch surface', () => {
/>,
);
openDateSheet();
- const saveDateButton = screen.getByRole('button', {name: 'Save date'});
+ const saveDateButton = getOnlyButton('Save date');
expect(saveDateButton).not.toBeDisabled();
- fireEvent.click(screen.getByRole('button', {name: 'Reset'}));
+ fireEvent.click(getOnlyButton('Reset'));
expect(dateField()).toHaveValue('');
expect(saveDateButton).toBeDisabled();
@@ -833,7 +824,7 @@ describe('DateTimeInput touch surface', () => {
openDateSheet();
const timeTab = screen.getByRole('radio', {name: 'Time'});
- fireEvent.click(screen.getByRole('button', {name: 'Save date'}));
+ fireEvent.click(getOnlyButton('Save date'));
expect(dateField()).toHaveAttribute('aria-expanded', 'false');
expect(timeField()).toHaveAttribute('aria-expanded', 'true');
@@ -863,8 +854,8 @@ describe('DateTimeInput touch surface', () => {
fireEvent.keyDown(field, {key: 'Enter'});
expect(field).toHaveAttribute('aria-expanded', 'true');
- fireEvent.click(screen.getByRole('button', {name: 'Save date'}));
- fireEvent.click(screen.getByRole('button', {name: 'Save'}));
+ fireEvent.click(getOnlyButton('Save date'));
+ fireEvent.click(getOnlyButton('Save'));
expect(field).toHaveAttribute('aria-expanded', 'false');
expect(timeField()).toHaveAttribute('aria-expanded', 'false');
});
@@ -881,9 +872,9 @@ describe('DateTimeInput touch surface', () => {
/>,
);
openDateSheet();
- fireEvent.click(screen.getByRole('button', {name: 'Save date'}));
+ fireEvent.click(getOnlyButton('Save date'));
- fireEvent.click(screen.getByRole('button', {name: 'Save'}));
+ fireEvent.click(getOnlyButton('Save'));
expect(dateField()).toHaveAttribute('aria-expanded', 'false');
expect(timeField()).toHaveAttribute('aria-expanded', 'false');
expect(onChange).not.toHaveBeenCalled();
@@ -945,7 +936,7 @@ describe('DateTimeInput touch surface', () => {
const field = dateField();
const focusSpy = vi.spyOn(field, 'focus');
- fireEvent.click(screen.getByRole('button', {name: 'Clear Meeting'}));
+ fireEvent.click(getOnlyButton('Clear Meeting'));
expect(onChange).toHaveBeenCalledWith(undefined);
expect(field).toHaveAttribute('aria-expanded', 'false');
expect(focusSpy).not.toHaveBeenCalled();
@@ -1013,7 +1004,7 @@ describe('DateTimeInput touch surface', () => {
);
openTimeSheet();
fireEvent.click(optionIn('Minute', '45'));
- fireEvent.click(screen.getByRole('button', {name: 'Save'}));
+ fireEvent.click(getOnlyButton('Save'));
const spinner = container.querySelector(
'.astryx-date-time-input-date-segment .astryx-spinner',
) as HTMLElement;
@@ -1114,7 +1105,7 @@ describe('DateTimeInput touch surface: no stale commit', () => {
);
const {rerender} = render(ui('2026-12-31T23:59' as ISODateTimeString));
openDateSheet();
- const next = screen.getByRole('button', {name: 'Next month'});
+ const next = getOnlyButton('Next month');
fireEvent.click(next);
fireEvent.click(next);
fireEvent.click(next);
diff --git a/packages/core/src/Table/Table.perf.test.tsx b/packages/core/src/Table/Table.perf.test.tsx
index fe750218bb..a464f93e7e 100644
--- a/packages/core/src/Table/Table.perf.test.tsx
+++ b/packages/core/src/Table/Table.perf.test.tsx
@@ -450,8 +450,25 @@ describe('Table render performance', () => {
// ===========================================================================
describe('render benchmarks', () => {
+ // An untimed render first: a run's first Table render also pays one-off
+ // module and compiler work, which is not what these budgets measure. The
+ // warm-up unmounts and uses other rows, so the timed render is a fresh
+ // mount that reuses nothing.
+ const warmUp = () => {
+ const rows = createTestData(100).map(row => ({
+ ...row,
+ id: `warm-${row.id}`,
+ name: `Warm ${row.name}`,
+ }));
+ const {unmount} = render(
+ <Table data={rows} columns={testColumns} idKey="id" />,
+ );
+ unmount();
+ };
+
it('should render 100 rows within performance budget', () => {
const data = createTestData(100);
+ warmUp();
const started = process.threadCpuUsage();
render(<Table data={data} columns={testColumns} idKey="id" />);
@@ -464,6 +481,7 @@ describe('Table render performance', () => {
it('should render 500 rows within performance budget', () => {
const data = createTestData(500);
+ warmUp();
const started = process.threadCpuUsage();
render(<Table data={data} columns={testColumns} idKey="id" />);
diff --git a/packages/core/src/Table/plugins/rowExpansion/useTableRowExpansion.test.tsx b/packages/core/src/Table/plugins/rowExpansion/useTableRowExpansion.test.tsx
index 60804f452e..cf840e4723 100644
--- a/packages/core/src/Table/plugins/rowExpansion/useTableRowExpansion.test.tsx
+++ b/packages/core/src/Table/plugins/rowExpansion/useTableRowExpansion.test.tsx
@@ -554,6 +554,11 @@ describe('useTableRowExpansion (detail panel)', () => {
* sibling row in the same tbody (which is what makes an exclusion
* necessary at all), and every stripe rule counts only rows that are not
* panels.
+ *
+ * Both cases render without row dividers. The panel's divider carry reads
+ * the striped row's computed style, and jsdom resolves it in about 2,000
+ * nested passes, which takes seconds. Striping does not depend on
+ * dividers.
*/
const stripeRules = () => {
const out: string[] = [];
@@ -572,7 +577,9 @@ describe('useTableRowExpansion (detail panel)', () => {
};
it('counts stripes over data rows only, so an open panel cannot flip them', () => {
- render(<Harness isStriped initialExpanded={new Set(['a'])} />);
+ render(
+ <Harness isStriped dividers="none" initialExpanded={new Set(['a'])} />,
+ );
// The panel really is a row among the rows — left in the count, it takes
// the stripe meant for the row below it and inverts everything after.
@@ -592,7 +599,9 @@ describe('useTableRowExpansion (detail panel)', () => {
it('marks the panel row so the stripe rule can skip it', () => {
// The attribute is what the selector keys off, so it is contract, not
// decoration — losing it silently restores the parity shift above.
- render(<Harness initialExpanded={new Set(['a'])} isStriped />);
+ render(
+ <Harness initialExpanded={new Set(['a'])} isStriped dividers="none" />,
+ );
const panels = Array.from(
document.querySelectorAll<HTMLTableRowElement>('tbody tr'),
).filter(r => r.hasAttribute('data-expansion-panel'));
diff --git a/packages/core/src/__tests__/fastRoleQueries.ts b/packages/core/src/__tests__/fastRoleQueries.ts
index c310615eb3..1fe8876245 100644
--- a/packages/core/src/__tests__/fastRoleQueries.ts
+++ b/packages/core/src/__tests__/fastRoleQueries.ts
@@ -3,7 +3,8 @@
/**
* @file fastRoleQueries.ts
* @input Uses @testing-library/react screen, dom-accessibility-api
- * @output getButton/queryButton — role+name lookups that stay O(match) in jsdom
+ * @output getButton/queryButton/getOnlyButton — role+name lookups that stay
+ * O(match) in jsdom
* @position Shared test helper; imported by component tests that render large
* always-mounted button collections (Calendar month grids)
*
@@ -23,12 +24,15 @@
* names only consult display/visibility, and under {hidden: true}
* semantics visibility must not exclude candidates anyway.
*
- * Trade-off vs getByRole: first match wins — no tree-wide uniqueness check.
+ * Trade-off vs getByRole: getButton and queryButton take the first match —
+ * no tree-wide uniqueness check. getOnlyButton keeps getByRole's checks. Each
+ * button with a matching name must also pass RTL's own role, name and
+ * accessibility query, run on its parent alone. Exactly one may.
*
* SYNC: When modified, update this header.
*/
-import {screen} from '@testing-library/react';
+import {screen, within} from '@testing-library/react';
import {computeAccessibleName} from 'dom-accessibility-api';
// The name algorithm only reads getPropertyValue (for display/visibility/
@@ -64,3 +68,20 @@ export function getButton(name: string | RegExp): HTMLElement {
}
return el;
}
+
+export function getOnlyButton(name: string | RegExp): HTMLElement {
+ const matches = screen
+ .queryAllByRole('button', {hidden: true})
+ .filter(
+ el =>
+ matchesName(el, name) &&
+ el.parentElement != null &&
+ within(el.parentElement).queryAllByRole('button', {name}).includes(el),
+ );
+ if (matches.length !== 1) {
+ throw new Error(
+ `Expected one accessible role=button named ${String(name)}, found ${matches.length}`,
+ );
+ }
+ return matches[0];
+}