An open source design system that's fully customizable and agent ready
TypeScript
fix(core,lab): reset container padding custom properties on overlay elements (#5208) (#5209)
Geervan0c6ab035b4de
diff --git a/.changeset/reset-overlay-container-padding.md b/.changeset/reset-overlay-container-padding.mdnew file mode 100644index 0000000000..5fcfa36205--- /dev/null+++ b/.changeset/reset-overlay-container-padding.md@@ -0,0 +1,7 @@+---+'@astryxdesign/core': patch+---++[fix] Reset container padding custom properties on overlay elements (`BottomSheet`, `Dialog`, `MobileNav`, `Popover`) to prevent nested `Section` components from inheriting ancestor section padding.++@Geervandiff --git a/packages/core/src/BottomSheet/BottomSheet.test.tsx b/packages/core/src/BottomSheet/BottomSheet.test.tsxindex 2a2752ffd7..9d64e4e750 100644--- a/packages/core/src/BottomSheet/BottomSheet.test.tsx+++ b/packages/core/src/BottomSheet/BottomSheet.test.tsx@@ -2262,4 +2262,21 @@ describe('BottomSheet', () => {expect(screen.getByRole('dialog')).toBeInTheDocument();});});++ describe('container padding isolation', () => {+ it('resets container padding custom properties to 0px on the sheet panel element', () => {+ render(+ <BottomSheet isOpen onOpenChange={() => {}} label="Filters">+ Content+ </BottomSheet>,+ );+ const sheet = getSheet();+ const computed = window.getComputedStyle(sheet);+ expect(computed.getPropertyValue('--container-padding-inline-start')).toBe('0px');+ expect(computed.getPropertyValue('--container-padding-inline-end')).toBe('0px');+ expect(computed.getPropertyValue('--container-padding-block-start')).toBe('0px');+ expect(computed.getPropertyValue('--container-padding-block-end')).toBe('0px');+ });+ });});+diff --git a/packages/core/src/BottomSheet/BottomSheetPanel.tsx b/packages/core/src/BottomSheet/BottomSheetPanel.tsxindex d1d16a1347..0fc82f79b4 100644--- a/packages/core/src/BottomSheet/BottomSheetPanel.tsx+++ b/packages/core/src/BottomSheet/BottomSheetPanel.tsx@@ -111,6 +111,10 @@ const styles = stylex.create({width: '100%',maxWidth: 640,backgroundColor: colorVars['--color-background-surface'],+ '--container-padding-inline-start': '0px',+ '--container-padding-inline-end': '0px',+ '--container-padding-block-start': '0px',+ '--container-padding-block-end': '0px',borderStartStartRadius: radiusVars['--radius-container'],borderStartEndRadius: radiusVars['--radius-container'],boxShadow: shadowVars['--shadow-high'],diff --git a/packages/core/src/Dialog/Dialog.test.tsx b/packages/core/src/Dialog/Dialog.test.tsxindex e78910a832..8effe58e73 100644--- a/packages/core/src/Dialog/Dialog.test.tsx+++ b/packages/core/src/Dialog/Dialog.test.tsx@@ -461,4 +461,20 @@ describe('Dialog', () => {before.remove();});});++ describe('container padding isolation', () => {+ it('resets container padding custom properties on the root dialog element', () => {+ render(+ <Dialog isOpen={true} onOpenChange={() => {}}>+ Content+ </Dialog>,+ );+ const dialog = screen.getByRole('dialog');+ const computed = window.getComputedStyle(dialog);+ expect(computed.getPropertyValue('--container-padding-inline-start')).toBe('0px');+ expect(computed.getPropertyValue('--container-padding-inline-end')).toBe('0px');+ expect(computed.getPropertyValue('--container-padding-block-start')).toBe('0px');+ expect(computed.getPropertyValue('--container-padding-block-end')).toBe('0px');+ });+ });});diff --git a/packages/core/src/Dialog/Dialog.tsx b/packages/core/src/Dialog/Dialog.tsxindex 024133a1e3..64ffaaa9be 100644--- a/packages/core/src/Dialog/Dialog.tsx+++ b/packages/core/src/Dialog/Dialog.tsx@@ -129,6 +129,10 @@ const styles = stylex.create({border: 'none',backgroundColor: colorVars['--color-background-surface'],'--_dialog-radius': radiusVars['--radius-container'],+ '--container-padding-inline-start': '0px',+ '--container-padding-inline-end': '0px',+ '--container-padding-block-start': '0px',+ '--container-padding-block-end': '0px',borderRadius: 'var(--_dialog-radius)',boxShadow: shadowVars['--shadow-high'],display: 'none',@@ -184,6 +188,10 @@ const styles = stylex.create({border: 'none',backgroundColor: colorVars['--color-background-surface'],'--_dialog-radius': radiusVars['--radius-container'],+ '--container-padding-inline-start': '0px',+ '--container-padding-inline-end': '0px',+ '--container-padding-block-start': '0px',+ '--container-padding-block-end': '0px',borderRadius: 'var(--_dialog-radius)',boxShadow: shadowVars['--shadow-high'],display: 'flex',diff --git a/packages/core/src/MobileNav/MobileNav.tsx b/packages/core/src/MobileNav/MobileNav.tsxindex 133bd70afb..258ba0978f 100644--- a/packages/core/src/MobileNav/MobileNav.tsx+++ b/packages/core/src/MobileNav/MobileNav.tsx@@ -139,6 +139,10 @@ const styles = stylex.create({flexDirection: 'column',backgroundColor: colorVars['--color-background-surface'],boxSizing: 'border-box',+ '--container-padding-inline-start': '0px',+ '--container-padding-inline-end': '0px',+ '--container-padding-block-start': '0px',+ '--container-padding-block-end': '0px',overflow: 'hidden',transitionProperty: 'transform',transitionDuration: durationVars['--duration-medium'],diff --git a/packages/core/src/Popover/usePopover.tsx b/packages/core/src/Popover/usePopover.tsxindex edfb95e54d..d6997d1240 100644--- a/packages/core/src/Popover/usePopover.tsx+++ b/packages/core/src/Popover/usePopover.tsx@@ -40,6 +40,10 @@ const styles = stylex.create({// Consumers that need a raw positioned layer should use useLayer instead.surface: {backgroundColor: colorVars['--color-background-popover'],+ '--container-padding-inline-start': '0px',+ '--container-padding-inline-end': '0px',+ '--container-padding-block-start': '0px',+ '--container-padding-block-end': '0px',borderRadius: radiusVars['--radius-container'],boxShadow: shadowVars['--shadow-low'],},diff --git a/packages/lab/src/Drawer/Drawer.test.tsx b/packages/lab/src/Drawer/Drawer.test.tsxindex fe10e6b537..0cf341ad65 100644--- a/packages/lab/src/Drawer/Drawer.test.tsx+++ b/packages/lab/src/Drawer/Drawer.test.tsx@@ -633,4 +633,21 @@ describe('Drawer', () => {expect(closeFirst).toHaveBeenCalledTimes(1);});});++ describe('container padding isolation', () => {+ it('resets container padding custom properties on the root dialog element', () => {+ render(+ <Drawer isOpen onClose={() => {}} label="Details">+ Content+ </Drawer>,+ );+ const dialog = screen.getByRole('dialog');+ const computed = window.getComputedStyle(dialog);+ expect(computed.getPropertyValue('--container-padding-inline-start')).toBe('0px');+ expect(computed.getPropertyValue('--container-padding-inline-end')).toBe('0px');+ expect(computed.getPropertyValue('--container-padding-block-start')).toBe('0px');+ expect(computed.getPropertyValue('--container-padding-block-end')).toBe('0px');+ });+ });});+diff --git a/packages/lab/src/Drawer/Drawer.tsx b/packages/lab/src/Drawer/Drawer.tsxindex 14b6ff304e..3814b8067d 100644--- a/packages/lab/src/Drawer/Drawer.tsx+++ b/packages/lab/src/Drawer/Drawer.tsx@@ -123,6 +123,10 @@ const styles = stylex.create({overflow: 'hidden',overscrollBehavior: 'contain',outline: 'none',+ '--container-padding-inline-start': '0px',+ '--container-padding-inline-end': '0px',+ '--container-padding-block-start': '0px',+ '--container-padding-block-end': '0px',// Closed state. `display` participates in the transition with// allow-discrete so it flips to none only after the slide-out finishes// (@starting-style covers the none -> flex entry). max-width animates