Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

fix(theme): update focus outline color (#253)

rubyycheung0e05b0ddfcf8
diff --git a/packages/core/src/TextInput/XDSTextInput.tsx b/packages/core/src/TextInput/XDSTextInput.tsx
index 48f825aaa8..58c34b02a8 100644
--- a/packages/core/src/TextInput/XDSTextInput.tsx
+++ b/packages/core/src/TextInput/XDSTextInput.tsx
@@ -107,6 +107,27 @@ const statusBorderStyles = stylex.create({
},
});
+const statusFocusStyles = stylex.create({
+ warning: {
+ outline: {
+ default: 'none',
+ ':focus-within': `2px solid ${colorVars['--color-focus-outline-warning']}`,
+ },
+ },
+ error: {
+ outline: {
+ default: 'none',
+ ':focus-within': `2px solid ${colorVars['--color-focus-outline-error']}`,
+ },
+ },
+ success: {
+ outline: {
+ default: 'none',
+ ':focus-within': `2px solid ${colorVars['--color-focus-outline-success']}`,
+ },
+ },
+});
+
export type XDSTextInputSize = keyof typeof sizeStyles;
// Re-export shared types for convenience
@@ -292,6 +313,7 @@ export const XDSTextInput = forwardRef<HTMLInputElement, XDSTextInputProps>(
sizeStyles[size],
isDisabled && styles.wrapperDisabled,
status && statusBorderStyles[status.type],
+ status && statusFocusStyles[status.type],
wrapperOverride,
)}>
{startIcon && <XDSIcon icon={startIcon} size="sm" color="primary" />}
diff --git a/packages/core/src/theme/tokens.stylex.ts b/packages/core/src/theme/tokens.stylex.ts
index 7129e00fb2..f3a277ed6d 100644
--- a/packages/core/src/theme/tokens.stylex.ts
+++ b/packages/core/src/theme/tokens.stylex.ts
@@ -24,7 +24,10 @@ export const colorRaw = {
'--color-overlay': 'light-dark(#01122866, #11111299)',
'--color-hover-overlay': 'light-dark(#0536590C, #FFFFFF0C)',
'--color-pressed-overlay': 'light-dark(#05365919, #FFFFFF19)',
- '--color-focus-outline': 'light-dark(#042F97, #AFD7FF)',
+ '--color-focus-outline': 'light-dark(#0171E3, #2694FE)',
+ '--color-focus-outline-error': 'light-dark(#E3193B, #F5394F)',
+ '--color-focus-outline-success': 'light-dark(#0D8626, #0D8626)',
+ '--color-focus-outline-warning': 'light-dark(#F2C00B, #E9AF08)',
'--color-deemphasized': 'light-dark(#0536590C, #1111127F)',
// Text
diff --git a/packages/themes/default/src/defaultTheme.stylex.ts b/packages/themes/default/src/defaultTheme.stylex.ts
index 65eadebdcc..e20e4b436a 100644
--- a/packages/themes/default/src/defaultTheme.stylex.ts
+++ b/packages/themes/default/src/defaultTheme.stylex.ts
@@ -65,7 +65,10 @@ const colorRaw = {
'--color-overlay': 'light-dark(#01122866, #11111299)',
'--color-hover-overlay': 'light-dark(#0536590C, #FFFFFF0C)',
'--color-pressed-overlay': 'light-dark(#05365919, #FFFFFF19)',
- '--color-focus-outline': 'light-dark(#042F97, #AFD7FF)',
+ '--color-focus-outline': 'light-dark(#0171E3, #2694FE)',
+ '--color-focus-outline-error': 'light-dark(#E3193B, #F5394F)',
+ '--color-focus-outline-success': 'light-dark(#0D8626, #0D8626)',
+ '--color-focus-outline-warning': 'light-dark(#F2C00B, #E9AF08)',
'--color-deemphasized': 'light-dark(#0536590C, #1111127F)',
// Text
diff --git a/packages/themes/neutral/src/neutralTheme.stylex.ts b/packages/themes/neutral/src/neutralTheme.stylex.ts
index f86bfc90f2..7b6e7b07f7 100644
--- a/packages/themes/neutral/src/neutralTheme.stylex.ts
+++ b/packages/themes/neutral/src/neutralTheme.stylex.ts
@@ -70,6 +70,9 @@ const colorRaw = {
'--color-pressed-overlay':
'light-dark(oklch(0 0 0 / 10%), oklch(1 0 0 / 10%))',
'--color-focus-outline': 'light-dark(oklch(0.708 0 0), oklch(0.556 0 0))',
+ '--color-focus-outline-error': 'light-dark(#E3193B, #F5394F)',
+ '--color-focus-outline-success': 'light-dark(#0D8626, #0D8626)',
+ '--color-focus-outline-warning': 'light-dark(#F2C00B, #E9AF08)',
'--color-deemphasized': 'light-dark(oklch(0.97 0 0), oklch(0.269 0 0))',
// Text