Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

fix(Selector): forward extra HTML attributes from XDSBaseProps (#1444)

Cindy Zhang11175f57a798
diff --git a/packages/core/src/Selector/XDSSelector.tsx b/packages/core/src/Selector/XDSSelector.tsx
index dc199c94fc..48b33cbb0f 100644
--- a/packages/core/src/Selector/XDSSelector.tsx
+++ b/packages/core/src/Selector/XDSSelector.tsx
@@ -459,8 +459,10 @@ export function XDSSelector<T extends XDSSelectorOptionType>(
xstyle,
className,
style,
- } = props;
- const hasClear = 'hasClear' in props && props.hasClear === true;
+ hasClear: hasClearProp,
+ ...rest
+ } = props as XDSSelectorPropsClearable<T>;
+ const hasClear = hasClearProp === true;
// Normalize null to undefined for internal use (null is the clear sentinel)
const normalizedValue = value === null ? undefined : value;
@@ -684,6 +686,7 @@ export function XDSSelector<T extends XDSSelectorOptionType>(
id={triggerId}
type="button"
role="combobox"
+ {...rest}
aria-haspopup="listbox"
aria-expanded={popover.isOpen}
aria-controls={listboxId}