An open source design system that's fully customizable and agent ready
TypeScript
fix(core): emit border and background resets as longhands so StyleX keeps them (#6732)
홍규진12a6e8a83547
diff --git a/.changeset/core-border-background-longhands.md b/.changeset/core-border-background-longhands.mdnew file mode 100644index 0000000000..cba1d4eb95--- /dev/null+++ b/.changeset/core-border-background-longhands.md@@ -0,0 +1,7 @@+---+'@astryxdesign/core': patch+---++[fix] `Dialog` and 30 other components no longer lose their `border` and `background` resets in the shipped CSS. The sources used the `border: 'none'` and `background: 'none' | 'transparent'` shorthands, which StyleX's default property-specificity mode drops silently, so the declarations never reached `astryx.css`; a consumer that does not load `reset.css` saw the UA `<dialog>` frame. They are now the `borderWidth` / `borderStyle` / `backgroundColor` longhands. No API change.++@kyu-rongdiff --git a/packages/core/src/BottomSheet/BottomSheet.tsx b/packages/core/src/BottomSheet/BottomSheet.tsxindex 40cddbb32e..04cbe37307 100644--- a/packages/core/src/BottomSheet/BottomSheet.tsx+++ b/packages/core/src/BottomSheet/BottomSheet.tsx@@ -66,7 +66,8 @@ const styles = stylex.create({maxHeight: 'none',margin: 0,padding: 0,- border: 'none',+ borderWidth: 0,+ borderStyle: 'none',backgroundColor: 'transparent',overflow: 'visible',display: 'none',diff --git a/packages/core/src/BottomSheet/BottomSheetSwitcher.tsx b/packages/core/src/BottomSheet/BottomSheetSwitcher.tsxindex cf8bfc472c..8106421861 100644--- a/packages/core/src/BottomSheet/BottomSheetSwitcher.tsx+++ b/packages/core/src/BottomSheet/BottomSheetSwitcher.tsx@@ -74,7 +74,8 @@ const styles = stylex.create({maxHeight: 'none',margin: 0,padding: 0,- border: 'none',+ borderWidth: 0,+ borderStyle: 'none',backgroundColor: 'transparent',overflow: 'visible',display: 'none',diff --git a/packages/core/src/Breadcrumbs/BreadcrumbItem.tsx b/packages/core/src/Breadcrumbs/BreadcrumbItem.tsxindex dbe15836bb..db173da75f 100644--- a/packages/core/src/Breadcrumbs/BreadcrumbItem.tsx+++ b/packages/core/src/Breadcrumbs/BreadcrumbItem.tsx@@ -177,8 +177,9 @@ const itemStyles = stylex.create({// paddingBlock `link` sets above, which shrank the button crumbs to 20px// against their sibling links' 28px.buttonReset: {- background: 'none',- border: 'none',+ backgroundColor: 'transparent',+ borderWidth: 0,+ borderStyle: 'none',paddingInline: 0,margin: 0,font: 'inherit',diff --git a/packages/core/src/Chat/useTriggerMenu.tsx b/packages/core/src/Chat/useTriggerMenu.tsxindex 764be45b3a..02ca531687 100644--- a/packages/core/src/Chat/useTriggerMenu.tsx+++ b/packages/core/src/Chat/useTriggerMenu.tsx@@ -124,7 +124,8 @@ const styles = stylex.create({},outline: 'none',backgroundColor: 'transparent',- border: 'none',+ borderWidth: 0,+ borderStyle: 'none',textAlign: 'start' as const,fontFamily: typographyVars['--font-family-body'],fontSize: typeScaleVars['--text-body-size'],diff --git a/packages/core/src/CodeBlock/CodeBlock.tsx b/packages/core/src/CodeBlock/CodeBlock.tsxindex 6bb384b70b..1fa89b400f 100644--- a/packages/core/src/CodeBlock/CodeBlock.tsx+++ b/packages/core/src/CodeBlock/CodeBlock.tsx@@ -134,7 +134,8 @@ const styles = stylex.create({minWidth: 0,// Reset default <button> appearance for the collapsible title control.padding: 0,- border: 'none',+ borderWidth: 0,+ borderStyle: 'none',backgroundColor: 'transparent',color: 'inherit',font: 'inherit',diff --git a/packages/core/src/CommandPalette/CommandPaletteInput.tsx b/packages/core/src/CommandPalette/CommandPaletteInput.tsxindex 956072fbe7..00385b33a5 100644--- a/packages/core/src/CommandPalette/CommandPaletteInput.tsx+++ b/packages/core/src/CommandPalette/CommandPaletteInput.tsx@@ -68,7 +68,8 @@ const styles = stylex.create({input: {flex: 1,minWidth: 0,- border: 'none',+ borderWidth: 0,+ borderStyle: 'none',outline: 'none',backgroundColor: 'transparent',color: colorVars['--color-text-primary'],diff --git a/packages/core/src/CommandPalette/CommandPaletteItem.tsx b/packages/core/src/CommandPalette/CommandPaletteItem.tsxindex 7d615f4101..3279efd70e 100644--- a/packages/core/src/CommandPalette/CommandPaletteItem.tsx+++ b/packages/core/src/CommandPalette/CommandPaletteItem.tsx@@ -43,7 +43,8 @@ const styles = stylex.create({fontSize: typeScaleVars['--text-label-size'],color: colorVars['--color-text-primary'],backgroundColor: 'transparent',- border: 'none',+ borderWidth: 0,+ borderStyle: 'none',cursor: {default: 'pointer',':is(:disabled,[aria-disabled="true"])': 'default',diff --git a/packages/core/src/Dialog/Dialog.source-build.test.mjs b/packages/core/src/Dialog/Dialog.source-build.test.mjsnew file mode 100644index 0000000000..0c30642ce4--- /dev/null+++ b/packages/core/src/Dialog/Dialog.source-build.test.mjs@@ -0,0 +1,43 @@+// Copyright (c) Meta Platforms, Inc. and affiliates.++/**+ * @file Dialog.source-build.test.mjs+ * @input Uses Babel, the core StyleX build config, and Dialog source+ * @output Verifies the dialog border reset survives compilation+ * @position Regression test for the shipped Dialog stylesheet+ */++import fs from 'node:fs/promises';+import path from 'node:path';+import {fileURLToPath} from 'node:url';+import {transformAsync} from '@babel/core';+import {describe, expect, it} from 'vitest';++const __dirname = path.dirname(fileURLToPath(import.meta.url));+const CORE_ROOT = path.resolve(__dirname, '../..');+const DIALOG_SOURCE = path.join(__dirname, 'Dialog.tsx');++async function compileDialogRules() {+ const source = await fs.readFile(DIALOG_SOURCE, 'utf8');+ const result = await transformAsync(source, {+ babelrc: false,+ configFile: path.join(CORE_ROOT, 'babel.config.json'),+ filename: DIALOG_SOURCE,+ });+ return (result?.metadata?.stylex ?? []).map(([, rule]) => rule.ltr);+}++describe('Dialog border stylesheet', () => {+ it('emits the border reset that hides the UA <dialog> frame', async () => {+ const rules = await compileDialogRules();++ // StyleX's default property-specificity mode silently drops the `border`+ // shorthand, so the reset must be longhands to reach the shipped CSS.+ // Without it, a consumer that does not load reset.css sees the UA+ // `dialog { border: solid }` frame.+ expect(rules).toContainEqual(expect.stringMatching(/\{border-width:0\}$/));+ expect(rules).toContainEqual(+ expect.stringMatching(/\{border-style:none\}$/),+ );+ });+});diff --git a/packages/core/src/Dialog/Dialog.tsx b/packages/core/src/Dialog/Dialog.tsxindex 624f7b91c9..4364633486 100644--- a/packages/core/src/Dialog/Dialog.tsx+++ b/packages/core/src/Dialog/Dialog.tsx@@ -164,7 +164,8 @@ const styles = stylex.create({position: 'fixed',margin: 'auto',padding: 0,- border: 'none',+ borderWidth: 0,+ borderStyle: 'none',backgroundColor: colorVars['--color-background-surface'],'--_dialog-radius': radiusVars['--radius-container'],borderRadius: 'var(--_dialog-radius)',@@ -237,7 +238,8 @@ const styles = stylex.create({// Inline wrapper mirrors the dialog's visual styles without <dialog> behaviorinlineWrapper: {padding: 0,- border: 'none',+ borderWidth: 0,+ borderStyle: 'none',backgroundColor: colorVars['--color-background-surface'],'--_dialog-radius': radiusVars['--radius-container'],borderRadius: 'var(--_dialog-radius)',diff --git a/packages/core/src/DropdownMenu/DropdownMenuItem.tsx b/packages/core/src/DropdownMenu/DropdownMenuItem.tsxindex e73677295a..e2d548b309 100644--- a/packages/core/src/DropdownMenu/DropdownMenuItem.tsx+++ b/packages/core/src/DropdownMenu/DropdownMenuItem.tsx@@ -55,7 +55,8 @@ const menuItemStyles = stylex.create({':active:where(:not(:disabled,[aria-disabled="true"]))':colorVars['--color-overlay-pressed'],},- border: 'none',+ borderWidth: 0,+ borderStyle: 'none',cursor: {default: 'pointer',':is(:disabled,[aria-disabled="true"])': 'default',diff --git a/packages/core/src/DropdownMenu/DropdownMenuSubMenu.tsx b/packages/core/src/DropdownMenu/DropdownMenuSubMenu.tsxindex 9132a2dbb6..e1589a0ba2 100644--- a/packages/core/src/DropdownMenu/DropdownMenuSubMenu.tsx+++ b/packages/core/src/DropdownMenu/DropdownMenuSubMenu.tsx@@ -106,7 +106,8 @@ const triggerStyles = stylex.create({default: 'transparent',':focus': colorVars['--color-overlay-hover'],},- border: 'none',+ borderWidth: 0,+ borderStyle: 'none',cursor: {default: 'pointer',':is(:disabled,[aria-disabled="true"])': 'default',diff --git a/packages/core/src/Lightbox/Lightbox.tsx b/packages/core/src/Lightbox/Lightbox.tsxindex 3de78ff899..16c0473b8a 100644--- a/packages/core/src/Lightbox/Lightbox.tsx+++ b/packages/core/src/Lightbox/Lightbox.tsx@@ -125,7 +125,8 @@ const styles = stylex.create({maxHeight: 'none',margin: 0,padding: 0,- border: 'none',+ borderWidth: 0,+ borderStyle: 'none',backgroundColor: 'transparent',overflow: 'hidden',outline: 'none',diff --git a/packages/core/src/MetadataList/MetadataList.tsx b/packages/core/src/MetadataList/MetadataList.tsxindex 9fe811df0a..61e24fdc81 100644--- a/packages/core/src/MetadataList/MetadataList.tsx+++ b/packages/core/src/MetadataList/MetadataList.tsx@@ -143,8 +143,9 @@ const styles = stylex.create({// Show more/less buttontoggleButton: {appearance: 'none',- background: 'none',- border: 'none',+ backgroundColor: 'transparent',+ borderWidth: 0,+ borderStyle: 'none',padding: `${spacingVars['--spacing-2']} 0`,cursor: {default: 'pointer',diff --git a/packages/core/src/MobileNav/MobileNav.tsx b/packages/core/src/MobileNav/MobileNav.tsxindex 24f39d0c4c..ea1c2ab0ce 100644--- a/packages/core/src/MobileNav/MobileNav.tsx+++ b/packages/core/src/MobileNav/MobileNav.tsx@@ -78,7 +78,8 @@ const styles = stylex.create({position: 'fixed',margin: 0,padding: 0,- border: 'none',+ borderWidth: 0,+ borderStyle: 'none',maxWidth: 'none',maxHeight: 'none',// Full viewport overlay — the dialog itself is the full-screen containerdiff --git a/packages/core/src/MultiSelector/MultiSelector.tsx b/packages/core/src/MultiSelector/MultiSelector.tsxindex 42c4be9722..0c96645e37 100644--- a/packages/core/src/MultiSelector/MultiSelector.tsx+++ b/packages/core/src/MultiSelector/MultiSelector.tsx@@ -318,7 +318,8 @@ const styles = stylex.create({fontWeight: fontWeightVars['--font-weight-medium'],color: colorVars['--color-text-primary'],backgroundColor: 'transparent',- border: 'none',+ borderWidth: 0,+ borderStyle: 'none',outline: 'none',},itemHighlighted: {diff --git a/packages/core/src/NavMenu/NavHeadingMenuItem.tsx b/packages/core/src/NavMenu/NavHeadingMenuItem.tsxindex fa304dec7b..22bbcc043e 100644--- a/packages/core/src/NavMenu/NavHeadingMenuItem.tsx+++ b/packages/core/src/NavMenu/NavHeadingMenuItem.tsx@@ -47,7 +47,8 @@ const styles = stylex.create({'@media (hover: hover)': colorVars['--color-overlay-hover'],},},- border: 'none',+ borderWidth: 0,+ borderStyle: 'none',cursor: {default: 'pointer',':is(:disabled,[aria-disabled="true"])': 'default',diff --git a/packages/core/src/Selector/Selector.tsx b/packages/core/src/Selector/Selector.tsxindex 4ecbc01138..ec2c96da92 100644--- a/packages/core/src/Selector/Selector.tsx+++ b/packages/core/src/Selector/Selector.tsx@@ -351,7 +351,8 @@ const styles = stylex.create({fontSize: typeScaleVars['--text-label-size'],color: colorVars['--color-text-primary'],backgroundColor: 'transparent',- border: 'none',+ borderWidth: 0,+ borderStyle: 'none',cursor: {default: 'pointer',':is(:disabled,[aria-disabled="true"])': 'default',diff --git a/packages/core/src/SideNav/SideNavHeading.tsx b/packages/core/src/SideNav/SideNavHeading.tsxindex 37acd8ec13..45181f94b5 100644--- a/packages/core/src/SideNav/SideNavHeading.tsx+++ b/packages/core/src/SideNav/SideNavHeading.tsx@@ -204,7 +204,8 @@ const styles = stylex.create({alignItems: 'center',gap: spacingVars['--spacing-2'],width: '100%',- border: 'none',+ borderWidth: 0,+ borderStyle: 'none',backgroundColor: 'transparent',fontFamily: 'inherit',fontSize: 'inherit',diff --git a/packages/core/src/Table/plugins/filtering/useTableFiltering.tsx b/packages/core/src/Table/plugins/filtering/useTableFiltering.tsxindex 5d544b2fec..92b652f9b8 100644--- a/packages/core/src/Table/plugins/filtering/useTableFiltering.tsx+++ b/packages/core/src/Table/plugins/filtering/useTableFiltering.tsx@@ -367,8 +367,9 @@ const filterStyles = stylex.create({minWidth: 0,},triggerButton: {- background: 'none',- border: 'none',+ backgroundColor: 'transparent',+ borderWidth: 0,+ borderStyle: 'none',cursor: {default: 'pointer',':is(:disabled,[aria-disabled="true"])': 'default',diff --git a/packages/core/src/Table/plugins/groupedRows/useTableGroupedRows.tsx b/packages/core/src/Table/plugins/groupedRows/useTableGroupedRows.tsxindex 7a3004bf74..1fce3a2c5d 100644--- a/packages/core/src/Table/plugins/groupedRows/useTableGroupedRows.tsx+++ b/packages/core/src/Table/plugins/groupedRows/useTableGroupedRows.tsx@@ -162,8 +162,9 @@ const styles = stylex.create({flexShrink: '0',padding: 0,margin: 0,- background: 'transparent',- border: 'none',+ backgroundColor: 'transparent',+ borderWidth: 0,+ borderStyle: 'none',cursor: {default: 'pointer',':is(:disabled,[aria-disabled="true"])': 'default',diff --git a/packages/core/src/Table/plugins/rowExpansion/useTableRowExpansion.tsx b/packages/core/src/Table/plugins/rowExpansion/useTableRowExpansion.tsxindex 1b3ddbb6d5..2e71a67112 100644--- a/packages/core/src/Table/plugins/rowExpansion/useTableRowExpansion.tsx+++ b/packages/core/src/Table/plugins/rowExpansion/useTableRowExpansion.tsx@@ -75,8 +75,9 @@ const expansionStyles = stylex.create({justifyContent: 'center',width: spacingVars['--spacing-6'],height: spacingVars['--spacing-6'],- background: 'transparent',- border: 'none',+ backgroundColor: 'transparent',+ borderWidth: 0,+ borderStyle: 'none',borderRadius: radiusVars['--radius-inner'],cursor: {default: 'pointer',diff --git a/packages/core/src/Table/plugins/sortable/useTableSortable.tsx b/packages/core/src/Table/plugins/sortable/useTableSortable.tsxindex 2f697d0e1f..c7ec1d1d3e 100644--- a/packages/core/src/Table/plugins/sortable/useTableSortable.tsx+++ b/packages/core/src/Table/plugins/sortable/useTableSortable.tsx@@ -121,8 +121,9 @@ const sortStyles = stylex.create({display: 'flex',alignItems: 'center',gap: spacingVars['--spacing-1'],- background: 'transparent',- border: 'none',+ backgroundColor: 'transparent',+ borderWidth: 0,+ borderStyle: 'none',padding: 0,margin: 0,cursor: {diff --git a/packages/core/src/Table/plugins/tree/useTableTreeData.tsx b/packages/core/src/Table/plugins/tree/useTableTreeData.tsxindex 6ba31e7ecf..f7eb1236c9 100644--- a/packages/core/src/Table/plugins/tree/useTableTreeData.tsx+++ b/packages/core/src/Table/plugins/tree/useTableTreeData.tsx@@ -239,8 +239,9 @@ const treeStyles = stylex.create({justifyContent: 'center',width: '24px',height: '24px',- background: 'transparent',- border: 'none',+ backgroundColor: 'transparent',+ borderWidth: 0,+ borderStyle: 'none',borderRadius: radiusVars['--radius-inner'],cursor: {default: 'pointer',diff --git a/packages/core/src/Toast/ToastViewport.tsx b/packages/core/src/Toast/ToastViewport.tsxindex 60446683e1..fef8e24813 100644--- a/packages/core/src/Toast/ToastViewport.tsx+++ b/packages/core/src/Toast/ToastViewport.tsx@@ -76,8 +76,8 @@ const styles = stylex.create({// at x=19.width: 'auto',margin: 0,- border: 'none',- background: 'none',+ borderWidth: 0,+ borderStyle: 'none',backgroundColor: 'transparent',overflow: 'visible',},diff --git a/packages/core/src/TopNav/TopNavHeading.tsx b/packages/core/src/TopNav/TopNavHeading.tsxindex 9e188186d0..43fec8ff1d 100644--- a/packages/core/src/TopNav/TopNavHeading.tsx+++ b/packages/core/src/TopNav/TopNavHeading.tsx@@ -181,7 +181,8 @@ const styles = stylex.create({alignItems: 'center',gap: spacingVars['--spacing-2'],width: '100%',- border: 'none',+ borderWidth: 0,+ borderStyle: 'none',backgroundColor: 'transparent',fontFamily: 'inherit',fontSize: 'inherit',diff --git a/packages/core/src/TopNav/TopNavMegaMenu.tsx b/packages/core/src/TopNav/TopNavMegaMenu.tsxindex 6fe49bd59d..a41daee9d3 100644--- a/packages/core/src/TopNav/TopNavMegaMenu.tsx+++ b/packages/core/src/TopNav/TopNavMegaMenu.tsx@@ -93,7 +93,8 @@ const styles = stylex.create({'@media (hover: hover)': colorVars['--color-overlay-hover'],},},- border: 'none',+ borderWidth: 0,+ borderStyle: 'none',fontFamily: 'inherit',},triggerOpen: {@@ -209,8 +210,9 @@ const styles = stylex.create({// base layout/colors come from navItemStyles.itemdrawerHeader: {justifyContent: 'space-between',- border: 'none',- background: 'none',+ borderWidth: 0,+ borderStyle: 'none',+ backgroundColor: 'transparent',},drawerChevron: {display: 'inline-flex',diff --git a/packages/core/src/TopNav/TopNavMegaMenuItem.tsx b/packages/core/src/TopNav/TopNavMegaMenuItem.tsxindex 337597dd86..aeeb6d443c 100644--- a/packages/core/src/TopNav/TopNavMegaMenuItem.tsx+++ b/packages/core/src/TopNav/TopNavMegaMenuItem.tsx@@ -58,7 +58,8 @@ const styles = stylex.create({transitionProperty: 'background-color',transitionDuration: durationVars['--duration-fast'],transitionTimingFunction: easeVars['--ease-standard'],- border: 'none',+ borderWidth: 0,+ borderStyle: 'none',color: 'inherit',fontFamily: 'inherit',textAlign: 'start',diff --git a/packages/core/src/TopNav/TopNavMenu.tsx b/packages/core/src/TopNav/TopNavMenu.tsxindex 906901814f..8f17336b53 100644--- a/packages/core/src/TopNav/TopNavMenu.tsx+++ b/packages/core/src/TopNav/TopNavMenu.tsx@@ -81,7 +81,8 @@ const styles = stylex.create({'@media (hover: hover)': colorVars['--color-overlay-hover'],},},- border: 'none',+ borderWidth: 0,+ borderStyle: 'none',fontFamily: 'inherit',},triggerOpen: {@@ -134,7 +135,8 @@ const styles = stylex.create({'@media (hover: hover)': colorVars['--color-overlay-hover'],},},- border: 'none',+ borderWidth: 0,+ borderStyle: 'none',},menuItemIcon: {display: 'flex',@@ -173,8 +175,9 @@ const drawerStyles = stylex.create({},header: {justifyContent: 'space-between',- border: 'none',- background: 'none',+ borderWidth: 0,+ borderStyle: 'none',+ backgroundColor: 'transparent',},chevron: {display: 'inline-flex',diff --git a/packages/core/src/TreeList/TreeListItem.tsx b/packages/core/src/TreeList/TreeListItem.tsxindex 7268b0c2a8..157d868169 100644--- a/packages/core/src/TreeList/TreeListItem.tsx+++ b/packages/core/src/TreeList/TreeListItem.tsx@@ -181,8 +181,9 @@ const styles = stylex.create({default: 'pointer',':is(:disabled,[aria-disabled="true"])': 'default',},- border: 'none',- background: 'none',+ borderWidth: 0,+ borderStyle: 'none',+ backgroundColor: 'transparent',padding: 0,color: colorVars['--color-icon-secondary'],borderRadius: radiusVars['--radius-inner'],diff --git a/packages/core/src/Typeahead/BaseTypeahead.tsx b/packages/core/src/Typeahead/BaseTypeahead.tsxindex 039ce94b92..cfee187768 100644--- a/packages/core/src/Typeahead/BaseTypeahead.tsx+++ b/packages/core/src/Typeahead/BaseTypeahead.tsx@@ -321,7 +321,8 @@ const styles = stylex.create({},outline: 'none',backgroundColor: 'transparent',- border: 'none',+ borderWidth: 0,+ borderStyle: 'none',textAlign: 'start',},itemHighlighted: {diff --git a/packages/core/src/hooks/useInputStatusIcon.tsx b/packages/core/src/hooks/useInputStatusIcon.tsxindex 537b075583..ce4fddb8ad 100644--- a/packages/core/src/hooks/useInputStatusIcon.tsx+++ b/packages/core/src/hooks/useInputStatusIcon.tsx@@ -78,8 +78,9 @@ const styles = stylex.create({justifyContent: 'center',padding: 0,margin: 0,- border: 'none',- background: 'none',+ borderWidth: 0,+ borderStyle: 'none',+ backgroundColor: 'transparent',color: 'inherit',cursor: {default: 'pointer',diff --git a/packages/core/src/hooks/useKeyboardHint.tsx b/packages/core/src/hooks/useKeyboardHint.tsxindex d3fa378479..035491251e 100644--- a/packages/core/src/hooks/useKeyboardHint.tsx+++ b/packages/core/src/hooks/useKeyboardHint.tsx@@ -109,7 +109,8 @@ const styles = stylex.create({position: 'fixed',inset: 'auto',margin: 0,- border: 'none',+ borderWidth: 0,+ borderStyle: 'none',// SurfacebackgroundColor: colorVars['--color-background-popover'],