An open source design system that's fully customizable and agent ready
TypeScript
refactor(templates): improve login-card XDS purity (grade 85→92) (#2587)
rubyycheung14d9b8cef381
diff --git a/packages/cli/templates/pages/login-card/page.tsx b/packages/cli/templates/pages/login-card/page.tsxindex 05ebc3ec77..967628644a 100644--- a/packages/cli/templates/pages/login-card/page.tsx+++ b/packages/cli/templates/pages/login-card/page.tsx@@ -14,38 +14,53 @@ import {XDSCard} from '@xds/core/Card';import {XDSLink} from '@xds/core/Link';import {XDSDivider} from '@xds/core/Divider';import {XDSIcon} from '@xds/core/Icon';-import {colorVars, spacingVars} from '@xds/core/theme/tokens.stylex';--// Brand icons — no heroicons equivalent+import {colorVars} from '@xds/core/theme/tokens.stylex';+// Brand sign-in marks — no heroicons or template-assets equivalent.const AppleIcon = (props: React.SVGProps<SVGSVGElement>) => (- <svg viewBox="0 0 24 24" fill="currentColor" width={16} height={16} aria-hidden="true" {...props}>+ <svg+ viewBox="0 0 24 24"+ fill="currentColor"+ width={16}+ height={16}+ aria-hidden="true"+ {...props}><path d="M17.05 20.28c-.98.95-2.05.88-3.08.4-1.09-.5-2.08-.48-3.24 0-1.44.62-2.2.44-3.06-.4C2.79 15.25 3.51 7.59 9.05 7.31c1.35.07 2.29.74 3.08.8 1.18-.24 2.31-.93 3.57-.84 1.51.12 2.65.72 3.4 1.8-3.12 1.87-2.38 5.98.48 7.13-.57 1.5-1.31 2.99-2.54 4.09zM12.03 7.25c-.15-2.23 1.66-4.07 3.74-4.25.29 2.58-2.34 4.5-3.74 4.25z" /></svg>);const GoogleIcon = (props: React.SVGProps<SVGSVGElement>) => (- <svg viewBox="0 0 24 24" fill="currentColor" width={16} height={16} aria-hidden="true" {...props}>- <path d="M22.56 12.25c0-.78-.07-1.53-.2-2.25H12v4.26h5.92a5.06 5.06 0 01-2.2 3.32v2.77h3.57c2.08-1.92 3.28-4.74 3.28-8.1z" fill="#4285F4" />- <path d="M12 23c2.97 0 5.46-.98 7.28-2.66l-3.57-2.77c-.98.66-2.23 1.06-3.71 1.06-2.86 0-5.29-1.93-6.16-4.53H2.18v2.84C3.99 20.53 7.7 23 12 23z" fill="#34A853" />- <path d="M5.84 14.09c-.22-.66-.35-1.36-.35-2.09s.13-1.43.35-2.09V7.07H2.18C1.43 8.55 1 10.22 1 12s.43 3.45 1.18 4.93l2.85-2.22.81-.62z" fill="#FBBC05" />- <path d="M12 5.38c1.62 0 3.06.56 4.21 1.64l3.15-3.15C17.45 2.09 14.97 1 12 1 7.7 1 3.99 3.47 2.18 7.07l3.66 2.84c.87-2.6 3.3-4.53 6.16-4.53z" fill="#EA4335" />+ <svg+ viewBox="0 0 24 24"+ fill="currentColor"+ width={16}+ height={16}+ aria-hidden="true"+ {...props}>+ <path+ d="M22.56 12.25c0-.78-.07-1.53-.2-2.25H12v4.26h5.92a5.06 5.06 0 01-2.2 3.32v2.77h3.57c2.08-1.92 3.28-4.74 3.28-8.1z"+ fill="#4285F4"+ />+ <path+ d="M12 23c2.97 0 5.46-.98 7.28-2.66l-3.57-2.77c-.98.66-2.23 1.06-3.71 1.06-2.86 0-5.29-1.93-6.16-4.53H2.18v2.84C3.99 20.53 7.7 23 12 23z"+ fill="#34A853"+ />+ <path+ d="M5.84 14.09c-.22-.66-.35-1.36-.35-2.09s.13-1.43.35-2.09V7.07H2.18C1.43 8.55 1 10.22 1 12s.43 3.45 1.18 4.93l2.85-2.22.81-.62z"+ fill="#FBBC05"+ />+ <path+ d="M12 5.38c1.62 0 3.06.56 4.21 1.64l3.15-3.15C17.45 2.09 14.97 1 12 1 7.7 1 3.99 3.47 2.18 7.07l3.66 2.84c.87-2.6 3.3-4.53 6.16-4.53z"+ fill="#EA4335"+ /></svg>);+// Standalone auth page paints its own body background (no host shell).const styles = stylex.create({page: {- minHeight: '100dvh',- padding: spacingVars['--spacing-6'],backgroundColor: colorVars['--color-background-body'],},- fullWidth: {- width: '100%',- },- centered: {textAlign: 'center'},- termsFooter: {- maxWidth: 400,- },});export default function LoginSimple() {@@ -68,7 +83,7 @@ export default function LoginSimple() {};return (- <XDSCenter axis="both" xstyle={styles.page}>+ <XDSCenter axis="both" height="100dvh" xstyle={styles.page}><XDSVStack gap={4} hAlign="center">{/* Logo */}<XDSVStack gap={2} hAlign="center">@@ -80,15 +95,13 @@ export default function LoginSimple() {{/* Card */}<XDSCard padding={8} width={400}>- <XDSVStack gap={4}>+ <XDSVStack gap={4} hAlign="stretch">{/* Header */}- <XDSVStack hAlign="center" xstyle={styles.centered}>- <XDSVStack gap={1}>- <XDSHeading level={2}>Welcome back</XDSHeading>- <XDSText type="body" color="secondary" size="sm">- Sign in to your account- </XDSText>- </XDSVStack>+ <XDSVStack gap={1} hAlign="center">+ <XDSHeading level={2}>Welcome back</XDSHeading>+ <XDSText type="body" color="secondary" size="sm">+ Sign in to your account+ </XDSText></XDSVStack>{/* Form fields */}@@ -116,7 +129,10 @@ export default function LoginSimple() {size="lg"status={loginFailed- ? {type: 'error', message: 'Incorrect password. Try again.'}+ ? {+ type: 'error',+ message: 'Incorrect password. Try again.',+ }: undefined}/>@@ -140,7 +156,6 @@ export default function LoginSimple() {variant="primary"size="lg"isLoading={isLoading}- xstyle={styles.fullWidth}onClick={handleLogin}/>@@ -148,20 +163,18 @@ export default function LoginSimple() {<XDSDivider label="Or continue with" />{/* Social buttons */}- <XDSVStack gap={3}>+ <XDSVStack gap={3} hAlign="stretch"><XDSButtonlabel="Login with Apple"variant="secondary"icon={<AppleIcon />}size="lg"- xstyle={styles.fullWidth}/><XDSButtonlabel="Login with Google"variant="secondary"icon={<GoogleIcon />}size="lg"- xstyle={styles.fullWidth}/></XDSVStack>@@ -178,8 +191,8 @@ export default function LoginSimple() {</XDSCard>{/* Terms */}- <XDSVStack hAlign="center" xstyle={styles.termsFooter}>- <XDSText type="supporting" color="secondary" xstyle={styles.centered}>+ <XDSVStack hAlign="center" width={400}>+ <XDSText type="supporting" color="secondary" justify="center">By clicking continue, you agree to our{' '}<XDSLink href="#" type="supporting">Terms of Service