An open source design system that's fully customizable and agent ready
TypeScript
docs(knowledge): add Joey as a spec approver (#6261)
Joey17044ab1e814
diff --git a/.github/scripts/spec-owner-workflow.test.mjs b/.github/scripts/spec-owner-workflow.test.mjsindex 455a5cc096..872666223d 100644--- a/.github/scripts/spec-owner-workflow.test.mjs+++ b/.github/scripts/spec-owner-workflow.test.mjs@@ -229,6 +229,18 @@ describe('spec-only workflow contract', () => {expect(prComment).toContain('expectedCount: pull.changed_files');});+ it('keeps the schema approval roster within the ENGOWNERS set', () => {+ const {parseOwnerFile} = require('./knowledge-frontmatter.cjs');+ const latestSchema = JSON.parse(read('docs/schemas/knowledge/v4.json'));+ const engineeringOwners = parseOwnerFile(+ read('.github/ENGOWNERS'),+ );++ for (const owner of latestSchema.approvalOwners) {+ expect(engineeringOwners).toContain(owner);+ }+ });+it('runs the tested exact-head reconciler from the trusted default branch', () => {const workflow = read('.github/workflows/spec-owner-gate.yml');const reconciler = read('.github/scripts/spec-owner-reconcile.cjs');diff --git a/docs/schemas/knowledge/v4.json b/docs/schemas/knowledge/v4.jsonnew file mode 100644index 0000000000..c0c727d893--- /dev/null+++ b/docs/schemas/knowledge/v4.json@@ -0,0 +1,37 @@+{+ "schemaVersion": 4,+ "extends": 3,+ "kinds": {+ "system-spec": {+ "template": "docs/templates/knowledge/system-spec.md",+ "requiredFrontmatter": [+ "schema_version",+ "template_version",+ "kind",+ "id",+ "authority",+ "archive_reason",+ "superseded_by",+ "approved_by",+ "approved_at",+ "phase",+ "owners",+ "affects_architecture",+ "affects_families",+ "affects_contributing",+ "affects_consumer_docs"+ ],+ "requiredSections": [+ "Intent",+ "Non-goals",+ "Requirements",+ "Current-state impact",+ "Verification",+ "Decision log",+ "Open questions"+ ],+ "currentNonEmptyFields": ["owners"]+ }+ },+ "approvalOwners": ["cixzhang", "imdreamrunner", "josephfarina"]+}diff --git a/docs/specs/AST-001/spec.md b/docs/specs/AST-001/spec.mdindex 01c0273854..29682267bc 100644--- a/docs/specs/AST-001/spec.md+++ b/docs/specs/AST-001/spec.md@@ -1,5 +1,5 @@----schema_version: 1+schema_version: 4template_version: 1kind: system-specid: spec:AST-001diff --git a/docs/specs/AST-002/spec.md b/docs/specs/AST-002/spec.mdindex 04baa2de77..56a4e35ac1 100644--- a/docs/specs/AST-002/spec.md+++ b/docs/specs/AST-002/spec.md@@ -1,5 +1,5 @@----schema_version: 1+schema_version: 4template_version: 1kind: system-specid: spec:AST-002diff --git a/docs/specs/AST-003/spec.md b/docs/specs/AST-003/spec.mdindex 764c2bd59d..ef1511eb20 100644--- a/docs/specs/AST-003/spec.md+++ b/docs/specs/AST-003/spec.md@@ -1,5 +1,5 @@----schema_version: 1+schema_version: 4template_version: 1kind: system-specid: spec:AST-003diff --git a/docs/specs/AST-004/spec.md b/docs/specs/AST-004/spec.mdindex 957e27917e..23680b1792 100644--- a/docs/specs/AST-004/spec.md+++ b/docs/specs/AST-004/spec.md@@ -1,5 +1,5 @@----schema_version: 1+schema_version: 4template_version: 1kind: system-specid: spec:AST-004diff --git a/docs/specs/AST-005/spec.md b/docs/specs/AST-005/spec.mdindex 658f2b5863..8b43c9867f 100644--- a/docs/specs/AST-005/spec.md+++ b/docs/specs/AST-005/spec.md@@ -1,5 +1,5 @@----schema_version: 1+schema_version: 4template_version: 1kind: system-specid: spec:AST-005diff --git a/docs/specs/AST-006/spec.md b/docs/specs/AST-006/spec.mdindex a0ac564328..158e125883 100644--- a/docs/specs/AST-006/spec.md+++ b/docs/specs/AST-006/spec.md@@ -1,5 +1,5 @@----schema_version: 1+schema_version: 4template_version: 1kind: system-specid: spec:AST-006diff --git a/docs/specs/AST-008/spec.md b/docs/specs/AST-008/spec.mdindex fb3af73cb7..417b1c5fde 100644--- a/docs/specs/AST-008/spec.md+++ b/docs/specs/AST-008/spec.md@@ -1,5 +1,5 @@----schema_version: 1+schema_version: 4template_version: 1kind: system-specid: spec:AST-008diff --git a/docs/specs/AST-009/spec.md b/docs/specs/AST-009/spec.mdindex 7fa836301f..7371bfe922 100644--- a/docs/specs/AST-009/spec.md+++ b/docs/specs/AST-009/spec.md@@ -1,5 +1,5 @@----schema_version: 1+schema_version: 4template_version: 1kind: system-specid: spec:AST-009diff --git a/docs/specs/AST-010/spec.md b/docs/specs/AST-010/spec.mdindex 4d90e9a2ad..769f92b1d8 100644--- a/docs/specs/AST-010/spec.md+++ b/docs/specs/AST-010/spec.md@@ -1,5 +1,5 @@----schema_version: 1+schema_version: 4template_version: 1kind: system-specid: spec:AST-010diff --git a/docs/specs/AST-011/spec.md b/docs/specs/AST-011/spec.mdindex 998c232a45..f8dd1e31c7 100644--- a/docs/specs/AST-011/spec.md+++ b/docs/specs/AST-011/spec.md@@ -1,5 +1,5 @@----schema_version: 1+schema_version: 4template_version: 1kind: system-specid: spec:AST-011diff --git a/docs/specs/AST-012/spec.md b/docs/specs/AST-012/spec.mdindex 861eaee4ac..cc913d1cdd 100644--- a/docs/specs/AST-012/spec.md+++ b/docs/specs/AST-012/spec.md@@ -1,5 +1,5 @@----schema_version: 1+schema_version: 4template_version: 1kind: system-specid: spec:AST-012diff --git a/docs/specs/AST-013/spec.md b/docs/specs/AST-013/spec.mdindex 8248f8a45b..cb14424ac9 100644--- a/docs/specs/AST-013/spec.md+++ b/docs/specs/AST-013/spec.md@@ -1,5 +1,5 @@----schema_version: 1+schema_version: 4template_version: 1kind: system-specid: spec:AST-013diff --git a/docs/specs/AST-017/spec.md b/docs/specs/AST-017/spec.mdindex 19cc139123..5585d6ccf5 100644--- a/docs/specs/AST-017/spec.md+++ b/docs/specs/AST-017/spec.md@@ -1,5 +1,5 @@----schema_version: 1+schema_version: 4template_version: 1kind: system-specid: spec:AST-017diff --git a/docs/specs/AST-018/spec.md b/docs/specs/AST-018/spec.mdindex 6b9a3f5cbc..f5662bc9c7 100644--- a/docs/specs/AST-018/spec.md+++ b/docs/specs/AST-018/spec.md@@ -1,5 +1,5 @@----schema_version: 1+schema_version: 4template_version: 1kind: system-specid: spec:AST-018diff --git a/docs/specs/AST-020/spec.md b/docs/specs/AST-020/spec.mdindex 68d0e3030b..8754036052 100644--- a/docs/specs/AST-020/spec.md+++ b/docs/specs/AST-020/spec.md@@ -1,5 +1,5 @@----schema_version: 1+schema_version: 4template_version: 1kind: system-specid: spec:AST-020diff --git a/docs/specs/AST-021/spec.md b/docs/specs/AST-021/spec.mdindex f0b167614c..0c130cee5e 100644--- a/docs/specs/AST-021/spec.md+++ b/docs/specs/AST-021/spec.md@@ -1,5 +1,5 @@----schema_version: 1+schema_version: 4template_version: 1kind: system-specid: spec:AST-021diff --git a/docs/specs/AST-022/spec.md b/docs/specs/AST-022/spec.mdindex 1b8521d26f..bd0765da62 100644--- a/docs/specs/AST-022/spec.md+++ b/docs/specs/AST-022/spec.md@@ -1,5 +1,5 @@----schema_version: 1+schema_version: 4template_version: 1kind: system-specid: spec:AST-022diff --git a/docs/specs/AST-024/spec.md b/docs/specs/AST-024/spec.mdindex 4a7a23f3d1..ccb42f892a 100644--- a/docs/specs/AST-024/spec.md+++ b/docs/specs/AST-024/spec.md@@ -1,5 +1,5 @@----schema_version: 1+schema_version: 4template_version: 1kind: system-specid: spec:AST-024diff --git a/docs/specs/AST-025/spec.md b/docs/specs/AST-025/spec.mdindex 2d2e9f70c7..d11d473df6 100644--- a/docs/specs/AST-025/spec.md+++ b/docs/specs/AST-025/spec.md@@ -1,5 +1,5 @@----schema_version: 1+schema_version: 4template_version: 1kind: system-specid: spec:AST-025diff --git a/docs/specs/AST-026/spec.md b/docs/specs/AST-026/spec.mdindex ccb828e016..2e544cc14c 100644--- a/docs/specs/AST-026/spec.md+++ b/docs/specs/AST-026/spec.md@@ -1,5 +1,5 @@----schema_version: 1+schema_version: 4template_version: 1kind: system-specid: spec:AST-026diff --git a/docs/specs/AST-027/spec.md b/docs/specs/AST-027/spec.mdindex 6be6868a6e..7fba17720c 100644--- a/docs/specs/AST-027/spec.md+++ b/docs/specs/AST-027/spec.md@@ -1,5 +1,5 @@----schema_version: 1+schema_version: 4template_version: 1kind: system-specid: spec:AST-027diff --git a/docs/specs/AST-028/spec.md b/docs/specs/AST-028/spec.mdindex 99b10b3670..c7acbdee15 100644--- a/docs/specs/AST-028/spec.md+++ b/docs/specs/AST-028/spec.md@@ -1,5 +1,5 @@----schema_version: 1+schema_version: 4template_version: 1kind: system-specid: spec:AST-028diff --git a/docs/specs/AST-029/spec.md b/docs/specs/AST-029/spec.mdindex 4cc428227b..e1cbc29dcd 100644--- a/docs/specs/AST-029/spec.md+++ b/docs/specs/AST-029/spec.md@@ -1,5 +1,5 @@----schema_version: 1+schema_version: 4template_version: 1kind: system-specid: spec:AST-029diff --git a/docs/specs/AST-030/spec.md b/docs/specs/AST-030/spec.mdindex 68e1ffa209..bd279874d9 100644--- a/docs/specs/AST-030/spec.md+++ b/docs/specs/AST-030/spec.md@@ -1,5 +1,5 @@----schema_version: 1+schema_version: 4template_version: 1kind: system-specid: spec:AST-030diff --git a/docs/specs/AST-031/spec.md b/docs/specs/AST-031/spec.mdindex 0016cb6e43..cd1baa9742 100644--- a/docs/specs/AST-031/spec.md+++ b/docs/specs/AST-031/spec.md@@ -1,5 +1,5 @@----schema_version: 1+schema_version: 4template_version: 1kind: system-specid: spec:AST-031diff --git a/docs/specs/AST-032/spec.md b/docs/specs/AST-032/spec.mdindex b827c1982a..a41300fbb0 100644--- a/docs/specs/AST-032/spec.md+++ b/docs/specs/AST-032/spec.md@@ -1,5 +1,5 @@----schema_version: 1+schema_version: 4template_version: 1kind: system-specid: spec:AST-032diff --git a/docs/specs/AST-033/spec.md b/docs/specs/AST-033/spec.mdindex 0cbc7e9ee9..9b0bfdb372 100644--- a/docs/specs/AST-033/spec.md+++ b/docs/specs/AST-033/spec.md@@ -1,5 +1,5 @@----schema_version: 1+schema_version: 4template_version: 1kind: system-specid: spec:AST-033diff --git a/docs/specs/AST-034/spec.md b/docs/specs/AST-034/spec.mdindex d45fdf2549..47763fa909 100644--- a/docs/specs/AST-034/spec.md+++ b/docs/specs/AST-034/spec.md@@ -1,5 +1,5 @@----schema_version: 1+schema_version: 4template_version: 1kind: system-specid: spec:AST-034diff --git a/docs/specs/AST-036/spec.md b/docs/specs/AST-036/spec.mdindex 3cf2352296..b249b3ca67 100644--- a/docs/specs/AST-036/spec.md+++ b/docs/specs/AST-036/spec.md@@ -1,5 +1,5 @@----schema_version: 1+schema_version: 4template_version: 1kind: system-specid: spec:AST-036diff --git a/docs/specs/AST-037-timer/spec.md b/docs/specs/AST-037-timer/spec.mdindex 6594ea0d1c..0b250410d4 100644--- a/docs/specs/AST-037-timer/spec.md+++ b/docs/specs/AST-037-timer/spec.md@@ -1,5 +1,5 @@----schema_version: 1+schema_version: 4template_version: 1kind: system-specid: spec:AST-037diff --git a/docs/specs/AST-038-layer-text-boundary/spec.md b/docs/specs/AST-038-layer-text-boundary/spec.mdindex 1fbbeefdbd..4d42c7e018 100644--- a/docs/specs/AST-038-layer-text-boundary/spec.md+++ b/docs/specs/AST-038-layer-text-boundary/spec.md@@ -1,5 +1,5 @@----schema_version: 1+schema_version: 4template_version: 1kind: system-specid: spec:AST-038diff --git a/docs/specs/AST-040-consumer-file-modification/spec.md b/docs/specs/AST-040-consumer-file-modification/spec.mdindex ca46c6bd8c..b00fbe8c35 100644--- a/docs/specs/AST-040-consumer-file-modification/spec.md+++ b/docs/specs/AST-040-consumer-file-modification/spec.md@@ -1,5 +1,5 @@----schema_version: 1+schema_version: 4template_version: 1kind: system-specid: spec:AST-040diff --git a/docs/specs/AST-041-consumer-docs-audience/spec.md b/docs/specs/AST-041-consumer-docs-audience/spec.mdindex 768c0c8410..38a8f6e0e9 100644--- a/docs/specs/AST-041-consumer-docs-audience/spec.md+++ b/docs/specs/AST-041-consumer-docs-audience/spec.md@@ -1,5 +1,5 @@----schema_version: 1+schema_version: 4template_version: 1kind: system-specid: spec:AST-041diff --git a/docs/templates/knowledge/system-spec.md b/docs/templates/knowledge/system-spec.mdindex c15d2e4d1b..31e8f68d88 100644--- a/docs/templates/knowledge/system-spec.md+++ b/docs/templates/knowledge/system-spec.md@@ -1,5 +1,5 @@----schema_version: 1+schema_version: 4template_version: 1kind: system-specid: spec:AST-000diff --git a/scripts/check-knowledge.test.mjs b/scripts/check-knowledge.test.mjsindex 3f35ddcfe4..089ca2309b 100644--- a/scripts/check-knowledge.test.mjs+++ b/scripts/check-knowledge.test.mjs@@ -36,7 +36,7 @@ function fixtureRoot() {path.join(root, 'docs/templates/knowledge'),{recursive: true},);- for (const version of ['v1.json', 'v2.json', 'v3.json']) {+ for (const version of ['v1.json', 'v2.json', 'v3.json', 'v4.json']) {fs.copyFileSync(path.join(repoRoot, `docs/schemas/knowledge/${version}`),path.join(root, `docs/schemas/knowledge/${version}`),@@ -207,7 +207,7 @@ function themeRecord(overrides = {}) {function systemSpecRecord(overrides = {}) {const values = {- schema_version: '1',+ schema_version: '4',template_version: '1',kind: 'system-spec',id: 'spec:AST-900',