Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

fix(core): clamp Slider controlled values (#4062)

Kevinjohn Gallagher17d83c9e0694
diff --git a/.changeset/slider-clamp-controlled-value.md b/.changeset/slider-clamp-controlled-value.md
new file mode 100644
index 0000000000..147f8ef548
--- /dev/null
+++ b/.changeset/slider-clamp-controlled-value.md
@@ -0,0 +1,7 @@
+---
+'@astryxdesign/core': patch
+---
+
+[fix] Slider now clamps controlled values to its minimum and maximum before positioning the thumb and exposing ARIA values.
+
+@Kevinjohn
diff --git a/packages/core/src/Slider/Slider.test.tsx b/packages/core/src/Slider/Slider.test.tsx
index 1e676340c8..3c42856fa6 100644
--- a/packages/core/src/Slider/Slider.test.tsx
+++ b/packages/core/src/Slider/Slider.test.tsx
@@ -85,6 +85,19 @@ describe('Slider', () => {
expect(slider).toHaveAttribute('aria-valuenow', '72');
});
+ it.each([
+ {value: 150, expectedValue: 100, expectedPosition: '100%'},
+ {value: -50, expectedValue: 0, expectedPosition: '0%'},
+ ])(
+ 'clamps a controlled value of $value to $expectedValue',
+ ({value, expectedValue, expectedPosition}) => {
+ render(<Slider label="Volume" value={value} min={0} max={100} />);
+ const slider = screen.getByRole('slider');
+ expect(slider).toHaveAttribute('aria-valuenow', String(expectedValue));
+ expect(slider).toHaveStyle({left: expectedPosition});
+ },
+ );
+
it('range mode sets correct aria values on both thumbs', () => {
render(
<Slider
diff --git a/packages/core/src/Slider/Slider.tsx b/packages/core/src/Slider/Slider.tsx
index 1edb96b7a8..4c6a30cb3b 100644
--- a/packages/core/src/Slider/Slider.tsx
+++ b/packages/core/src/Slider/Slider.tsx
@@ -439,10 +439,12 @@ export function Slider({ref, ...props}: SliderProps) {
// Value helpers — guard against undefined value (e.g. playground previews
// that render the component without providing a value prop).
- const values: number[] = useMemo(
- () => (isRange ? value : [value != null ? value : min]),
- [isRange, value, min],
- );
+ const values: number[] = useMemo(() => {
+ const currentValues = Array.isArray(value)
+ ? value
+ : [value != null ? value : min];
+ return currentValues.map(currentValue => clamp(currentValue, min, max));
+ }, [value, min, max]);
const valuesRef = useRef(values);
valuesRef.current = values;