Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

ci: the seven empty-array expansions under set -u work on bash 3.2 (#10295)

Cindy Zhang1936df98a4e0
diff --git a/.github/scripts/ci-test-routing.test.mjs b/.github/scripts/ci-test-routing.test.mjs
index 89bb3ce3c1..32e19690f8 100644
--- a/.github/scripts/ci-test-routing.test.mjs
+++ b/.github/scripts/ci-test-routing.test.mjs
@@ -908,7 +908,7 @@ describe('scoped browser audits (spec:AST-030 FR9, FR13)', () => {
'if [ -n "$DEPENDENTS" ]; then DEPENDENT_ARGS=(--dependents "$DEPENDENTS"); fi',
);
expect(visual.run).toContain(
- 'SCOPE_ARGS=(--tiers component --components "$COMPONENTS" "${DEPENDENT_ARGS[@]}" --no-scout)',
+ 'SCOPE_ARGS=(--tiers component --components "$COMPONENTS" ${DEPENDENT_ARGS[@]+"${DEPENDENT_ARGS[@]}"} --no-scout)',
);
expect(visual.run).toContain(
"FORCE_FULL_AUDITS=$(jq -r '.forceFullComponentAudits == true' analysis.json)",
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 1babc87f5d..a931e0fbec 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -3276,9 +3276,9 @@ jobs:
COMMAND=release
SCOPE_ARGS=()
elif [ -n "$COMPONENTS$DEPENDENTS" ] && [ -n "$THEMES" ]; then
- SCOPE_ARGS=(--tiers 'component,theme-matrix' --components "$COMPONENTS" "${DEPENDENT_ARGS[@]}" --themes "$THEMES")
+ SCOPE_ARGS=(--tiers 'component,theme-matrix' --components "$COMPONENTS" ${DEPENDENT_ARGS[@]+"${DEPENDENT_ARGS[@]}"} --themes "$THEMES")
elif [ -n "$COMPONENTS$DEPENDENTS" ]; then
- SCOPE_ARGS=(--tiers component --components "$COMPONENTS" "${DEPENDENT_ARGS[@]}" --no-scout)
+ SCOPE_ARGS=(--tiers component --components "$COMPONENTS" ${DEPENDENT_ARGS[@]+"${DEPENDENT_ARGS[@]}"} --no-scout)
elif [ -n "$THEMES" ]; then
SCOPE_ARGS=(--tiers theme-matrix --themes "$THEMES")
else
@@ -3298,8 +3298,8 @@ jobs:
--storybook-dir apps/storybook/dist \
--baseline .github/visual-baseline \
--out .visual-run \
- "${SCOPE_ARGS[@]}" \
- "${OBS_ARGS[@]}" \
+ ${SCOPE_ARGS[@]+"${SCOPE_ARGS[@]}"} \
+ ${OBS_ARGS[@]+"${OBS_ARGS[@]}"} \
--summary-output visual-summary.md
}
set +e
@@ -3327,7 +3327,7 @@ jobs:
--storybook-dir apps/storybook/dist \
--baseline .github/visual-baseline \
--out .visual-run \
- "${OBS_ARGS[@]}" \
+ ${OBS_ARGS[@]+"${OBS_ARGS[@]}"} \
--summary-output visual-summary.md
code=$?
set -e
@@ -3402,7 +3402,7 @@ jobs:
--storybook-dir apps/storybook/dist \
--baseline .github/visual-baseline \
--out .visual-run \
- "${OBS_ARGS[@]}" \
+ ${OBS_ARGS[@]+"${OBS_ARGS[@]}"} \
--summary-output visual-summary.md
code=$?
set -e
@@ -3790,7 +3790,7 @@ jobs:
--output rtl-audit-report.json \
--packages core \
--merge-shards rtl-parts \
- "${FILTER_ARGS[@]}"
+ ${FILTER_ARGS[@]+"${FILTER_ARGS[@]}"}
code=$?
set -e
# 1 is the soft findings signal; anything else is a failed join.