An open source design system that's fully customizable and agent ready
TypeScript
feat(table): reflect density as data-density on cell theme targets (#4697)
freddymeta1c1396781cee
diff --git a/.changeset/table-cell-density-theme-hook.md b/.changeset/table-cell-density-theme-hook.mdnew file mode 100644index 0000000000..589e821cda--- /dev/null+++ b/.changeset/table-cell-density-theme-hook.md@@ -0,0 +1,7 @@+---+'@astryxdesign/core': patch+---++[feat] Table: `astryx-table-cell` and `astryx-table-header-cell` now reflect the active row density as `data-density` (`compact`/`balanced`/`spacious`), so a theme can override cell padding per density via `defineTheme`. Previously the density split lived entirely in internal StyleX classes with no `density:*` hook on the cell target, so a `components: { 'table-cell': {...} }` entry could only set one padding for all densities — it could not, for example, hold the inline inset constant while varying only the block padding per density. The targets now carry the hook (`{className: 'astryx-table-cell', visualProps: ['density']}`), enabling `components: { 'table-cell': { 'density:balanced': { paddingBlock: '12px' } } }`. Purely additive — default padding is unchanged.++@freddymetadiff --git a/packages/core/src/Table/Table.doc.mjs b/packages/core/src/Table/Table.doc.mjsindex c05eb88f33..5f6d0c3ef9 100644--- a/packages/core/src/Table/Table.doc.mjs+++ b/packages/core/src/Table/Table.doc.mjs@@ -31,8 +31,8 @@ export const docs = {{className: 'astryx-table-body'},{className: 'astryx-table-footer'},{className: 'astryx-table-row'},- {className: 'astryx-table-cell'},- {className: 'astryx-table-header-cell'},+ {className: 'astryx-table-cell', visualProps: ['density']},+ {className: 'astryx-table-header-cell', visualProps: ['density']},],},description: 'Styled, data-driven table with density, dividers, hover highlight, striped rows, and named plugin support. T must extend Record<string, unknown>.',diff --git a/packages/core/src/Table/Table.test.tsx b/packages/core/src/Table/Table.test.tsxindex 01a7872748..dc43ae0b1c 100644--- a/packages/core/src/Table/Table.test.tsx+++ b/packages/core/src/Table/Table.test.tsx@@ -886,6 +886,33 @@ describe('Table', () => {render(<Table data={users} columns={columns} density="spacious" />);expect(screen.getAllByRole('row')).toHaveLength(4);});++ it('reflects density as data-density on cells and header cells (theme hook)', () => {+ // The density lives in internal StyleX classes, so cells expose it as a+ // data-density attribute on the stable astryx-table-cell /+ // astryx-table-header-cell targets. This lets a theme override padding+ // per density (e.g. hold the inline inset while varying the block) via+ // `defineTheme` — the padding split is otherwise unreachable.+ const {rerender} = render(+ <Table data={users} columns={columns} density="spacious" />,+ );+ const cell = screen.getAllByRole('cell')[0];+ const header = screen.getAllByRole('columnheader')[0];+ expect(cell.className).toContain('astryx-table-cell');+ expect(cell).toHaveAttribute('data-density', 'spacious');+ expect(header.className).toContain('astryx-table-header-cell');+ expect(header).toHaveAttribute('data-density', 'spacious');++ rerender(<Table data={users} columns={columns} density="compact" />);+ expect(screen.getAllByRole('cell')[0]).toHaveAttribute(+ 'data-density',+ 'compact',+ );+ expect(screen.getAllByRole('columnheader')[0]).toHaveAttribute(+ 'data-density',+ 'compact',+ );+ });});describe('dividers', () => {diff --git a/packages/core/src/Table/TableCell.tsx b/packages/core/src/Table/TableCell.tsxindex 1082249dff..f5a716e59b 100644--- a/packages/core/src/Table/TableCell.tsx+++ b/packages/core/src/Table/TableCell.tsx@@ -252,7 +252,7 @@ export function TableCell({ref={ref}{...props}{...mergeProps(- themeProps('table-cell'),+ themeProps('table-cell', {density: ctx?.density}),stylex.props(...mergeXStyle(cellStyles, xstyle)),incomingClassName,incomingStyle,diff --git a/packages/core/src/Table/TableHeaderCell.tsx b/packages/core/src/Table/TableHeaderCell.tsxindex dec317849e..6d1670223d 100644--- a/packages/core/src/Table/TableHeaderCell.tsx+++ b/packages/core/src/Table/TableHeaderCell.tsx@@ -157,7 +157,7 @@ export function TableHeaderCell({ref={ref}{...props}{...mergeProps(- themeProps('table-header-cell'),+ themeProps('table-header-cell', {density: ctx?.density}),stylex.props(...mergeXStyle(cellStyles, xstyle)),incomingClassName,incomingStyle,