An open source design system that's fully customizable and agent ready
TypeScript
feat(Button): add isPressed prop for toggle button state (#1202)
Cindy Zhang1dab429016c4
diff --git a/apps/storybook/stories/ToggleButton.stories.tsx b/apps/storybook/stories/ToggleButton.stories.tsxindex 6cd399542b..21b2cc5cdf 100644--- a/apps/storybook/stories/ToggleButton.stories.tsx+++ b/apps/storybook/stories/ToggleButton.stories.tsx@@ -5,17 +5,25 @@ import {BoldIcon,ItalicIcon,UnderlineIcon,+ StrikethroughIcon,+ LinkIcon,ListBulletIcon,Squares2X2Icon,StarIcon,BookmarkIcon,BellIcon,BellSlashIcon,+ HeartIcon,} from '@heroicons/react/24/outline';import {StarIcon as StarIconSolid,BookmarkIcon as BookmarkIconSolid,+ HeartIcon as HeartIconSolid,+ BoldIcon as BoldIconSolid,+ ItalicIcon as ItalicIconSolid,+ UnderlineIcon as UnderlineIconSolid,} from '@heroicons/react/24/solid';+import {XDSIcon} from '@xds/core/Icon';const iconSize = {width: 16, height: 16} as const;@@ -219,3 +227,125 @@ export const NotificationToggle: Story = {);},};++// =============================================================================+// Colored icons in pressed state+// =============================================================================++/**+ * Formatting toolbar with colored icons — icon shifts to accent color when pressed.+ * Uses outline → solid icon swap + XDSIcon color prop to reinforce state.+ */+export const ColoredIconToolbar: Story = {+ render: function Render() {+ const [pressed, setPressed] = useState<Record<string, boolean>>({+ bold: true,+ italic: false,+ underline: true,+ strikethrough: false,+ link: false,+ });+ const toggle = (key: string) => setPressed(p => ({...p, [key]: !p[key]}));+ return (+ <div style={{display: 'flex', gap: 4}}>+ <XDSToggleButton+ label="Bold"+ icon={<XDSIcon icon={BoldIcon} size="sm" color="secondary" />}+ pressedIcon={+ <XDSIcon icon={BoldIconSolid} size="sm" color="accent" />+ }+ isPressed={pressed.bold}+ onPressedChange={() => toggle('bold')}+ />+ <XDSToggleButton+ label="Italic"+ icon={<XDSIcon icon={ItalicIcon} size="sm" color="secondary" />}+ pressedIcon={+ <XDSIcon icon={ItalicIconSolid} size="sm" color="accent" />+ }+ isPressed={pressed.italic}+ onPressedChange={() => toggle('italic')}+ />+ <XDSToggleButton+ label="Underline"+ icon={<XDSIcon icon={UnderlineIcon} size="sm" color="secondary" />}+ pressedIcon={+ <XDSIcon icon={UnderlineIconSolid} size="sm" color="accent" />+ }+ isPressed={pressed.underline}+ onPressedChange={() => toggle('underline')}+ />+ <XDSToggleButton+ label="Strikethrough"+ icon={+ <XDSIcon icon={StrikethroughIcon} size="sm" color="secondary" />+ }+ pressedIcon={+ <XDSIcon icon={StrikethroughIcon} size="sm" color="accent" />+ }+ isPressed={pressed.strikethrough}+ onPressedChange={() => toggle('strikethrough')}+ />+ <XDSToggleButton+ label="Link"+ icon={<XDSIcon icon={LinkIcon} size="sm" color="secondary" />}+ pressedIcon={<XDSIcon icon={LinkIcon} size="sm" color="positive" />}+ isPressed={pressed.link}+ onPressedChange={() => toggle('link')}+ />+ </div>+ );+ },+};++/**+ * Reaction buttons — semantic icon colors (yellow star, red heart, blue bookmark).+ * Shows icon swap (outline → solid) paired with color to reinforce the pressed state.+ */+export const ColoredIconReactions: Story = {+ render: function Render() {+ const [pressed, setPressed] = useState<Record<string, boolean>>({+ star: false,+ heart: false,+ bookmark: true,+ bell: false,+ });+ const toggle = (key: string) => setPressed(p => ({...p, [key]: !p[key]}));+ return (+ <div style={{display: 'flex', gap: 8}}>+ <XDSToggleButton+ label="Star"+ icon={<XDSIcon icon={StarIcon} size="sm" color="secondary" />}+ pressedIcon={+ <XDSIcon icon={StarIconSolid} size="sm" color="yellow" />+ }+ isPressed={pressed.star}+ onPressedChange={() => toggle('star')}+ />+ <XDSToggleButton+ label="Like"+ icon={<XDSIcon icon={HeartIcon} size="sm" color="secondary" />}+ pressedIcon={<XDSIcon icon={HeartIconSolid} size="sm" color="red" />}+ isPressed={pressed.heart}+ onPressedChange={() => toggle('heart')}+ />+ <XDSToggleButton+ label="Save"+ icon={<XDSIcon icon={BookmarkIcon} size="sm" color="secondary" />}+ pressedIcon={+ <XDSIcon icon={BookmarkIconSolid} size="sm" color="blue" />+ }+ isPressed={pressed.bookmark}+ onPressedChange={() => toggle('bookmark')}+ />+ <XDSToggleButton+ label="Follow"+ icon={<XDSIcon icon={BellIcon} size="sm" color="secondary" />}+ pressedIcon={<XDSIcon icon={BellIcon} size="sm" color="accent" />}+ isPressed={pressed.bell}+ onPressedChange={() => toggle('bell')}+ />+ </div>+ );+ },+};diff --git a/packages/core/src/ToggleButton/XDSToggleButton.tsx b/packages/core/src/ToggleButton/XDSToggleButton.tsxindex aed5ed9ca6..94d1c473c3 100644--- a/packages/core/src/ToggleButton/XDSToggleButton.tsx+++ b/packages/core/src/ToggleButton/XDSToggleButton.tsx@@ -19,7 +19,7 @@import {useCallback, type ReactNode} from 'react';import * as stylex from '@stylexjs/stylex';-import {fontWeightVars} from '../theme/tokens.stylex';+import {colorVars, fontWeightVars} from '../theme/tokens.stylex';import {XDSButton, type XDSButtonSize} from '../Button';import {useXDSToggleButtonGroup} from './XDSToggleButtonGroup';@@ -32,6 +32,12 @@ import {useXDSToggleButtonGroup} from './XDSToggleButtonGroup';* A hidden span renders the same text at semibold weight to reserve* the wider width, preventing layout shift when toggling.*/+const pressedStyles = stylex.create({+ background: {+ backgroundColor: colorVars['--color-overlay-pressed'],+ },+});+const labelStyles = stylex.create({wrapper: {display: 'inline-flex',@@ -280,6 +286,7 @@ export function XDSToggleButton({aria-pressed={isPressed}icon={resolvedIcon}tooltip={tooltip}+ xstyle={isPressed ? pressedStyles.background : undefined}onClick={handleClick}{...props}>{labelContent}