Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

fix(core): make Slider track color visible on muted backgrounds (#3158)

Cindy Zhang1ebdb95a08c9
diff --git a/.changeset/slider-track-color-visible.md b/.changeset/slider-track-color-visible.md
new file mode 100644
index 0000000000..f6f7558d82
--- /dev/null
+++ b/.changeset/slider-track-color-visible.md
@@ -0,0 +1,16 @@
+---
+'@astryxdesign/core': patch
+---
+
+[fix] make the `Slider` default track color visible on muted backgrounds
+
+The background track painted with `--color-background-muted` — the same token
+used for muted surface fills — so the track disappeared on muted backgrounds.
+The track now uses the dedicated `--color-track` channel token, which is
+designed to stay legible against body/muted surfaces.
+
+Also makes the `Slider` docsite examples interactive: the showcase block now
+manages its own state via `onChange`, and the properties-tab preview gains an
+explicit `width` so the track renders with room to drag.
+
+@cixzhang
diff --git a/packages/cli/templates/blocks/components/Slider/SliderShowcase.tsx b/packages/cli/templates/blocks/components/Slider/SliderShowcase.tsx
index ad1ed256fb..620309eafa 100644
--- a/packages/cli/templates/blocks/components/Slider/SliderShowcase.tsx
+++ b/packages/cli/templates/blocks/components/Slider/SliderShowcase.tsx
@@ -2,8 +2,17 @@
'use client';
+import {useState} from 'react';
import {Slider} from '@astryxdesign/core/Slider';
export default function SliderShowcase() {
- return <Slider label="Volume" value={50} style={{width: 300}} />;
+ const [value, setValue] = useState(50);
+ return (
+ <Slider
+ label="Volume"
+ value={value}
+ onChange={setValue}
+ style={{width: 300}}
+ />
+ );
}
diff --git a/packages/core/src/Slider/Slider.doc.mjs b/packages/core/src/Slider/Slider.doc.mjs
index 092ce49f55..ef39ecbbcc 100644
--- a/packages/core/src/Slider/Slider.doc.mjs
+++ b/packages/core/src/Slider/Slider.doc.mjs
@@ -11,6 +11,10 @@ export const docs = {
defaults: {
label: 'Volume',
value: 50,
+ // Give the properties-tab preview a defined width so the track has room
+ // to render and stays draggable/interactive (the slider track grows to
+ // fill its container, which can collapse without an explicit width).
+ width: 300,
},
},
props: [
diff --git a/packages/core/src/Slider/Slider.test.tsx b/packages/core/src/Slider/Slider.test.tsx
index cfc0dd9db2..fa3aa5a7e6 100644
--- a/packages/core/src/Slider/Slider.test.tsx
+++ b/packages/core/src/Slider/Slider.test.tsx
@@ -24,9 +24,7 @@ describe('Slider', () => {
});
it('range thumbs have correct aria-labels', () => {
- render(
- <Slider label="Price range" value={[20, 80] as [number, number]} />,
- );
+ render(<Slider label="Price range" value={[20, 80] as [number, number]} />);
const sliders = screen.getAllByRole('slider');
expect(sliders[0]).toHaveAttribute(
'aria-label',
@@ -172,12 +170,7 @@ describe('Slider', () => {
it('does not fire onChange on keyboard when disabled', () => {
const handleChange = vi.fn();
render(
- <Slider
- label="Volume"
- value={50}
- onChange={handleChange}
- isDisabled
- />,
+ <Slider label="Volume" value={50} onChange={handleChange} isDisabled />,
);
const slider = screen.getByRole('slider');
fireEvent.keyDown(slider, {key: 'ArrowRight'});
@@ -297,13 +290,7 @@ describe('Slider', () => {
it('focuses closest thumb on track click', () => {
render(
- <Slider
- label="Volume"
- value={50}
- min={0}
- max={100}
- onChange={vi.fn()}
- />,
+ <Slider label="Volume" value={50} min={0} max={100} onChange={vi.fn()} />,
);
const slider = screen.getByRole('slider');
const trackContainer = slider.parentElement!;
diff --git a/packages/core/src/Slider/Slider.tsx b/packages/core/src/Slider/Slider.tsx
index c0660bea18..9868666753 100644
--- a/packages/core/src/Slider/Slider.tsx
+++ b/packages/core/src/Slider/Slider.tsx
@@ -159,7 +159,7 @@ const styles = stylex.create({
},
track: {
position: 'absolute',
- backgroundColor: colorVars['--color-background-muted'],
+ backgroundColor: colorVars['--color-track'],
borderRadius: radiusVars['--radius-full'],
},
trackHorizontal: {