Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

ci(visual): use the downloaded Core dist instead of rebuilding Core (#7449)

Cindy Zhang1ed2b258b5a7
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 597965505f..4ac092d9e7 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -2147,7 +2147,8 @@ jobs:
name: storybook-${{ needs.build-storybook.outputs.short_hash }}
path: apps/storybook/dist
- # If the optional theme artifact is missing, the gate builds the themes.
+ # The artifact carries the themes and the Core dist they import, built
+ # at this commit. If it is missing, the gate builds Core and the themes.
- name: Download built themes and core
continue-on-error: true
uses: actions/download-artifact@v8
@@ -2158,10 +2159,6 @@ jobs:
- name: Install Playwright
run: pnpm install --frozen-lockfile && npx playwright install chromium
- # Downloaded theme builds import Core's consumer-facing dist files.
- - name: Build Core dependency for theme inspection
- run: pnpm -F @astryxdesign/core build
-
- name: Scout this shard of the release plan
run: |
node .github/scripts/visual-gate/gate.mjs scout \
@@ -2224,7 +2221,8 @@ jobs:
name: storybook-${{ needs.build-storybook.outputs.short_hash }}
path: apps/storybook/dist
- # If the optional theme artifact is missing, the gate builds the themes.
+ # The artifact carries the themes and the Core dist they import, built
+ # at this commit. If it is missing, the gate builds Core and the themes.
- name: Download built themes and core
if: github.event_name == 'pull_request' || inputs.operation == 'release-check'
continue-on-error: true
@@ -2246,11 +2244,6 @@ jobs:
- name: Install Playwright
run: pnpm install --frozen-lockfile && npx playwright install chromium
- # Downloaded theme builds import Core's consumer-facing dist files.
- - name: Build Core dependency for theme inspection
- if: github.event_name == 'pull_request' || inputs.operation == 'release-check'
- run: pnpm -F @astryxdesign/core build
-
- name: Build canonical maintenance Storybook
if: github.event_name == 'workflow_dispatch' && inputs.operation == 'capture'
run: pnpm build && pnpm -F @astryxdesign/storybook build