An open source design system that's fully customizable and agent ready
TypeScript
fix(core): match list item height to trigger size for md (#2304)
Ernest2256a6fea8bc
diff --git a/packages/core/src/DropdownMenu/XDSDropdownMenu.tsx b/packages/core/src/DropdownMenu/XDSDropdownMenu.tsxindex 03c041f6a6..8f9c29461d 100644--- a/packages/core/src/DropdownMenu/XDSDropdownMenu.tsx+++ b/packages/core/src/DropdownMenu/XDSDropdownMenu.tsx@@ -46,6 +46,7 @@ import {useListFocus} from '../hooks/useListFocus';import {layerAnimations} from '../Layer/layerAnimations.stylex';import {spacingVars,+ sizeVars,radiusVars,durationVars,easeVars,@@ -82,6 +83,23 @@ const styles = stylex.create({}),});+/**+ * Overlay offset styles: shift the popover up so the first item's text+ * aligns with the trigger button's text.+ * Formula: -(container_padding + trigger_height)+ */+const popoverOverlayStyles = stylex.create({+ sm: {+ marginBlockStart: `calc(-1 * (${spacingVars['--spacing-1']} + ${sizeVars['--size-element-sm']}))`,+ },+ md: {+ marginBlockStart: `calc(-1 * (${spacingVars['--spacing-1']} + ${sizeVars['--size-element-md']}))`,+ },+ lg: {+ marginBlockStart: `calc(-1 * (${spacingVars['--spacing-1']} + ${sizeVars['--size-element-lg']}))`,+ },+});+// =============================================================================// Types// =============================================================================@@ -395,7 +413,7 @@ export function XDSDropdownMenu({{placement: 'below',alignment: 'start',- xstyle: [popoverXstyle, styles.popoverGap, layerAnimations.below],+ xstyle: [popoverXstyle, popoverOverlayStyles[menuSize], layerAnimations.below],},)}</>diff --git a/packages/core/src/DropdownMenu/XDSDropdownMenuItem.tsx b/packages/core/src/DropdownMenu/XDSDropdownMenuItem.tsxindex 2600e88c00..0643e8b4de 100644--- a/packages/core/src/DropdownMenu/XDSDropdownMenuItem.tsx+++ b/packages/core/src/DropdownMenu/XDSDropdownMenuItem.tsx@@ -71,7 +71,9 @@ const itemSizeStyles = stylex.create({paddingBlock: spacingVars['--spacing-1'],paddingInline: spacingVars['--spacing-2'],},- md: {},+ md: {+ paddingBlock: spacingVars['--spacing-1-5'],+ },lg: {},});diff --git a/packages/core/src/MultiSelector/XDSMultiSelector.tsx b/packages/core/src/MultiSelector/XDSMultiSelector.tsxindex 0a58a50a7b..3b87d6f203 100644--- a/packages/core/src/MultiSelector/XDSMultiSelector.tsx+++ b/packages/core/src/MultiSelector/XDSMultiSelector.tsx@@ -313,7 +313,8 @@ const itemSizeStyles = stylex.create({padding: spacingVars['--spacing-1'],},md: {- padding: spacingVars['--spacing-2'],+ paddingBlock: spacingVars['--spacing-1-5'],+ paddingInline: spacingVars['--spacing-2'],},lg: {padding: spacingVars['--spacing-2'],diff --git a/packages/core/src/Selector/XDSSelector.tsx b/packages/core/src/Selector/XDSSelector.tsxindex 54960eaa63..ef007476dc 100644--- a/packages/core/src/Selector/XDSSelector.tsx+++ b/packages/core/src/Selector/XDSSelector.tsx@@ -297,7 +297,9 @@ const itemSizeStyles = stylex.create({paddingBlock: spacingVars['--spacing-1'],paddingInline: spacingVars['--spacing-2'],},- md: {},+ md: {+ paddingBlock: spacingVars['--spacing-1-5'],+ },lg: {},});diff --git a/packages/core/src/Typeahead/XDSBaseTypeahead.tsx b/packages/core/src/Typeahead/XDSBaseTypeahead.tsxindex 0db655ba70..c38ec1f26f 100644--- a/packages/core/src/Typeahead/XDSBaseTypeahead.tsx+++ b/packages/core/src/Typeahead/XDSBaseTypeahead.tsx@@ -244,7 +244,9 @@ const itemSizeStyles = stylex.create({paddingBlock: spacingVars['--spacing-1'],paddingInline: spacingVars['--spacing-2'],},- md: {},+ md: {+ paddingBlock: spacingVars['--spacing-1-5'],+ },});// =============================================================================