Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

fix(CommandPalette): prevent search reset on keystroke (#2326)

Cindy Zhang2351785b09cc
diff --git a/packages/core/src/CommandPalette/XDSCommandPalette.tsx b/packages/core/src/CommandPalette/XDSCommandPalette.tsx
index 65986dc105..0941336182 100644
--- a/packages/core/src/CommandPalette/XDSCommandPalette.tsx
+++ b/packages/core/src/CommandPalette/XDSCommandPalette.tsx
@@ -399,12 +399,16 @@ export function XDSCommandPalette<
],
);
- // Bootstrap on open — the only remaining effect.
+ // Bootstrap on open. We use a ref to avoid re-triggering when
+ // runSearch's identity changes (it depends on searchResults).
+ const runSearchRef = useRef(runSearch);
+ runSearchRef.current = runSearch;
+
useEffect(() => {
if (isOpen) {
- runSearch('');
+ runSearchRef.current('');
}
- }, [isOpen, runSearch]);
+ }, [isOpen]);
// Wrap combobox's onKeyDown to intercept Escape (close palette) and
// Enter on highlight (select + close), since we're not using combobox's