Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

feat(Text): default type to 'body' instead of requiring it (#1702)

Cindy Zhang287ff3c37bdb
diff --git a/packages/core/src/Text/Text.doc.mjs b/packages/core/src/Text/Text.doc.mjs
index 37b45487c6..9daf77ab97 100644
--- a/packages/core/src/Text/Text.doc.mjs
+++ b/packages/core/src/Text/Text.doc.mjs
@@ -19,7 +19,7 @@ export const docs = {
type: "'body' | 'large' | 'label' | 'supporting' | 'code'",
description:
'Semantic text type. Determines size, weight, and line-height from the theme.',
- required: true,
+ default: "'body'",
},
{
name: 'children',
@@ -233,7 +233,7 @@ export const docsZh = {
type: "'body' | 'large' | 'label' | 'supporting' | 'code'",
description:
'语义化文本类型。从主题中确定大小、字重和行高。',
- required: true,
+ default: "'body'",
},
{
name: 'children',
diff --git a/packages/core/src/Text/XDSText.test.tsx b/packages/core/src/Text/XDSText.test.tsx
index 13ffc1a3d3..35e4fa0bdb 100644
--- a/packages/core/src/Text/XDSText.test.tsx
+++ b/packages/core/src/Text/XDSText.test.tsx
@@ -9,6 +9,11 @@ import {XDSText} from './XDSText';
describe('XDSText', () => {
describe('rendering', () => {
+ it('renders without type prop (defaults to body)', () => {
+ render(<XDSText>Default body text</XDSText>);
+ expect(screen.getByText('Default body text')).toBeInTheDocument();
+ });
+
it('renders children correctly', () => {
render(<XDSText type="body">Hello World</XDSText>);
expect(screen.getByText('Hello World')).toBeInTheDocument();
diff --git a/packages/core/src/Text/XDSText.tsx b/packages/core/src/Text/XDSText.tsx
index 2b74187a61..7b407e4f45 100644
--- a/packages/core/src/Text/XDSText.tsx
+++ b/packages/core/src/Text/XDSText.tsx
@@ -53,9 +53,9 @@ export interface XDSTextProps extends Omit<XDSBaseProps, 'children'> {
ref?: React.Ref<HTMLElement>;
/**
* Semantic text type. Determines size, weight, and line-height from theme.
- * Required to ensure semantic usage.
+ * @default 'body'
*/
- type: XDSTextType;
+ type?: XDSTextType;
/**
* Explicit font size override. When set, overrides the size from `type`
@@ -172,7 +172,7 @@ const defaultColorByType: Record<XDSTextType, XDSTextColor> = {
* ```
*/
export function XDSText({
- type,
+ type = 'body',
size: _size,
color,
weight,