An open source design system that's fully customizable and agent ready
TypeScript
fix(table): detect removed row properties in the memo comparator (#3596)
Md Shahrier Islam Arham2dbb4d46f91a
diff --git a/.changeset/table-row-memo-removed-keys.md b/.changeset/table-row-memo-removed-keys.mdnew file mode 100644index 0000000000..0723d5cd80--- /dev/null+++ b/.changeset/table-row-memo-removed-keys.md@@ -0,0 +1,8 @@+---+'@astryxdesign/core': patch+---++[fix] Table rows re-render when a field is removed from the row object (#3595)++The row memo compared only the keys of the new item, so a field cleared by omission (optimistic update, server response) never invalidated the memo and the cell kept rendering the deleted value indefinitely. A key-count check now catches removed properties.+@arham766diff --git a/packages/core/src/Table/BaseTable.tsx b/packages/core/src/Table/BaseTable.tsxindex 0f531ca132..375c2faf34 100644--- a/packages/core/src/Table/BaseTable.tsx+++ b/packages/core/src/Table/BaseTable.tsx@@ -284,6 +284,12 @@ function areRowPropsEqual<T extends Record<string, unknown>>(const nextItem = nextProps.item;const keys = Object.keys(nextItem);+ // A key deleted from nextItem would never be visited by the loop below,+ // and the row would keep rendering the removed field's stale value.+ if (Object.keys(prevItem).length !== keys.length) {+ return false;+ }+for (const key of keys) {if (prevItem[key] !== nextItem[key]) {return false;diff --git a/packages/core/src/Table/Table.test.tsx b/packages/core/src/Table/Table.test.tsxindex 036fa0a438..6659be05d5 100644--- a/packages/core/src/Table/Table.test.tsx+++ b/packages/core/src/Table/Table.test.tsx@@ -617,6 +617,29 @@ describe('BaseTable', () => {// =============================================================================describe('Table', () => {+ it('clears a cell when the field is removed from the row object (#3595)', () => {+ const cols: TableColumn<Record<string, unknown>>[] = [+ {key: 'name', header: 'Name'},+ {key: 'status', header: 'Status'},+ ];+ const {rerender} = render(+ <Table+ data={[{id: '1', name: 'Alice', status: 'active'}]}+ columns={cols}+ idKey="id"+ />,+ );+ expect(screen.getByText('active')).toBeInTheDocument();++ // Clearing a field by omitting it (optimistic update / server response)+ // must re-render the row — the memo previously only compared the keys of+ // the NEW item, so the deleted field's stale value kept rendering.+ rerender(+ <Table data={[{id: '1', name: 'Alice'}]} columns={cols} idKey="id" />,+ );+ expect(screen.queryByText('active')).not.toBeInTheDocument();+ });+it('renders a table with correct structure', () => {render(<Table data={users} columns={columns} />);expect(screen.getByRole('table')).toBeInTheDocument();