An open source design system that's fully customizable and agent ready
TypeScript
fix(TopNav): stop click propagation on heading links in mixed mode (#2135)
Joey3119f74b5dc1
diff --git a/packages/core/src/TopNav/XDSTopNavHeading.tsx b/packages/core/src/TopNav/XDSTopNavHeading.tsxindex b9b0eabd0c..5f0cd9f65f 100644--- a/packages/core/src/TopNav/XDSTopNavHeading.tsx+++ b/packages/core/src/TopNav/XDSTopNavHeading.tsx@@ -374,6 +374,7 @@ export function XDSTopNavHeading({(hasAnyHref && superheadingHref && menu ? (<XDSLinkhref={superheadingHref}+ onClick={(e: React.MouseEvent) => e.stopPropagation()}color="secondary"size="xsm">{superheading}@@ -385,6 +386,7 @@ export function XDSTopNavHeading({{hasAnyHref && headingHref && menu ? (<LinkComponenthref={headingHref}+ onClick={(e: React.MouseEvent) => e.stopPropagation()}{...stylex.props(styles.heading, styles.headingLink)}>{heading}</LinkComponent>@@ -397,6 +399,7 @@ export function XDSTopNavHeading({(hasAnyHref && subheadingHref && menu ? (<XDSLinkhref={subheadingHref}+ onClick={(e: React.MouseEvent) => e.stopPropagation()}color="secondary"size="xsm">{subheading}@@ -545,7 +548,10 @@ export function XDSTopNavHeading({)}>{logo &&(headingHref ? (- <LinkComponent href={headingHref} {...stylex.props(styles.logo)}>+ <LinkComponent+ href={headingHref}+ onClick={(e: React.MouseEvent) => e.stopPropagation()}+ {...stylex.props(styles.logo)}>{logo}</LinkComponent>) : (@@ -614,20 +620,14 @@ export function XDSTopNavHeading({<span {...stylex.props(styles.textContainer)}>{superheading &&(superheadingHref ? (- <XDSLink- href={superheadingHref}- color="secondary"- size="xsm">+ <XDSLink href={superheadingHref} color="secondary" size="xsm">{superheading}</XDSLink>) : (<span {...stylex.props(styles.superheading)}>{superheading}</span>))}{headingHref ? (- <XDSLink- href={headingHref}- color="primary"- weight="semibold">+ <XDSLink href={headingHref} color="primary" weight="semibold">{heading}</XDSLink>) : (@@ -635,10 +635,7 @@ export function XDSTopNavHeading({)}{subheading &&(subheadingHref ? (- <XDSLink- href={subheadingHref}- color="secondary"- size="xsm">+ <XDSLink href={subheadingHref} color="secondary" size="xsm">{subheading}</XDSLink>) : (