An open source design system that's fully customizable and agent ready
TypeScript
fix(core): guard ProgressBar value label against zero max (#3742)
raphaelroshanM32fe72d41667
diff --git a/.changeset/progressbar-zero-max-value-label.md b/.changeset/progressbar-zero-max-value-label.mdnew file mode 100644index 0000000000..4d02ff69eb--- /dev/null+++ b/.changeset/progressbar-zero-max-value-label.md@@ -0,0 +1,8 @@+---+'@astryxdesign/core': patch+---++[fix] ProgressBar: guard the value label against a zero max++When `max` was `0` (or negative), the default value-label formatter produced `NaN%` (`0/0`) or `Infinity%`. That string was rendered visually and written into `aria-valuetext`, so screen readers announced "NaN percent". Guard it the same way the fill percentage already is (`max > 0 ? … : 0`).+@raphaelroshanMdiff --git a/packages/core/src/ProgressBar/ProgressBar.test.tsx b/packages/core/src/ProgressBar/ProgressBar.test.tsxindex 3bf9c9fd93..838adc0f79 100644--- a/packages/core/src/ProgressBar/ProgressBar.test.tsx+++ b/packages/core/src/ProgressBar/ProgressBar.test.tsx@@ -140,6 +140,16 @@ describe('ProgressBar', () => {expect(progressbar).toHaveAttribute('aria-valuemax', '0');});+ it('does not render NaN in the value label when max is zero', () => {+ render(<ProgressBar value={0} max={0} label="Empty" hasValueLabel />);+ expect(screen.queryByText(/NaN|Infinity/)).not.toBeInTheDocument();+ const progressbar = screen.getByRole('progressbar');+ expect(progressbar.getAttribute('aria-valuetext') ?? '').not.toMatch(+ /NaN|Infinity/,+ );+ expect(screen.getByText('0%')).toBeInTheDocument();+ });+// Disabled statedescribe('disabled state', () => {it('renders with isDisabled', () => {diff --git a/packages/core/src/ProgressBar/ProgressBar.tsx b/packages/core/src/ProgressBar/ProgressBar.tsxindex cd2a8ac350..916c73195f 100644--- a/packages/core/src/ProgressBar/ProgressBar.tsx+++ b/packages/core/src/ProgressBar/ProgressBar.tsx@@ -228,7 +228,8 @@ const variantStyles = stylex.create({});function defaultFormatValueLabel(value: number, max: number): string {- return `${Math.round((value / max) * 100)}%`;+ const pct = max > 0 ? Math.round((value / max) * 100) : 0;+ return `${pct}%`;}/**