Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

fix(sandbox): use Next.js Link for card hrefs to respect basePath (#926)

rubyycheung3343a3891660
diff --git a/apps/sandbox/src/app/ProjectCard.tsx b/apps/sandbox/src/app/ProjectCard.tsx
index 45397cca2b..b518e54e1c 100644
--- a/apps/sandbox/src/app/ProjectCard.tsx
+++ b/apps/sandbox/src/app/ProjectCard.tsx
@@ -1,20 +1,17 @@
'use client';
+import Link from 'next/link';
import {XDSText} from '@xds/core/Text';
import type {SandboxPage} from './sandboxPages';
import {ImageIcon} from './icons';
export function ProjectCard({page}: {page: SandboxPage}) {
return (
- <a
+ <Link
href={page.href}
target="_blank"
rel="noopener noreferrer"
- style={{
- textDecoration: 'none',
- color: 'inherit',
- display: 'flex',
- }}>
+ style={{textDecoration: 'none', color: 'inherit', display: 'flex'}}>
<div
style={{
display: 'flex',
@@ -69,6 +66,6 @@ export function ProjectCard({page}: {page: SandboxPage}) {
</XDSText>
</div>
</div>
- </a>
+ </Link>
);
}
diff --git a/apps/sandbox/src/app/SandboxNav.tsx b/apps/sandbox/src/app/SandboxNav.tsx
index 033af190d4..9f51a28769 100644
--- a/apps/sandbox/src/app/SandboxNav.tsx
+++ b/apps/sandbox/src/app/SandboxNav.tsx
@@ -69,7 +69,7 @@ function SandboxHeader() {
<XDSDropdownMenu
button={{
label: 'Theme',
- icon: <PaletteIcon />,
+ icon: <PaletteIcon width={16} height={16} style={{color: 'var(--color-icon-secondary)'}} />,
variant: 'ghost',
size: 'sm',
}}
@@ -79,7 +79,12 @@ function SandboxHeader() {
<XDSDropdownMenu
button={{
label: mode === 'dark' ? 'Dark mode' : 'Light mode',
- icon: mode === 'dark' ? <MoonIcon /> : <SunIcon />,
+ icon:
+ mode === 'dark' ? (
+ <MoonIcon width={16} height={16} style={{color: 'var(--color-icon-secondary)'}} />
+ ) : (
+ <SunIcon width={16} height={16} style={{color: 'var(--color-icon-secondary)'}} />
+ ),
variant: 'ghost',
size: 'sm',
}}