Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

fix(Slider): add playground defaults and guard against undefined value (#2391)

Cindy Zhang3f266236b55b
diff --git a/packages/core/src/Slider/Slider.doc.mjs b/packages/core/src/Slider/Slider.doc.mjs
index 06c6147198..eaac53fe82 100644
--- a/packages/core/src/Slider/Slider.doc.mjs
+++ b/packages/core/src/Slider/Slider.doc.mjs
@@ -6,6 +6,12 @@ export const docs = {
name: 'Slider',
displayName: 'Slider',
keywords: ["slider","range","slidebar","trackbar","scrubber","knob","thumb","rangeslider"],
+ playground: {
+ defaults: {
+ label: 'Volume',
+ value: 50,
+ },
+ },
props: [
{
name: 'label',
diff --git a/packages/core/src/Slider/XDSSlider.tsx b/packages/core/src/Slider/XDSSlider.tsx
index ef77d18ad6..ab1a71d073 100644
--- a/packages/core/src/Slider/XDSSlider.tsx
+++ b/packages/core/src/Slider/XDSSlider.tsx
@@ -370,10 +370,14 @@ export function XDSSlider({ref, ...props}: XDSSliderProps) {
const ariaDescribedBy =
describedByParts.length > 0 ? describedByParts.join(' ') : undefined;
- // Value helpers
+ // Value helpers — guard against undefined value (e.g. playground previews
+ // that render the component without providing a value prop).
const values: number[] = useMemo(
- () => (isRange ? value : [value]),
- [isRange, value],
+ () =>
+ isRange
+ ? (value)
+ : [value != null ? (value) : min],
+ [isRange, value, min],
);
const valuesRef = useRef(values);