Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

fix(theme): Meta and WhatsApp theme refinements (#1496)

Cindy Zhang3fa1235e98ae
diff --git a/packages/core/src/DateInput/DateInput.doc.mjs b/packages/core/src/DateInput/DateInput.doc.mjs
index a0bf1de200..b17747a9ec 100644
--- a/packages/core/src/DateInput/DateInput.doc.mjs
+++ b/packages/core/src/DateInput/DateInput.doc.mjs
@@ -128,7 +128,7 @@ export const docs = {
],
theming: {
targets: [
- {className: 'xds-date-input', visualProps: ['size']},
+ {className: 'xds-date-input', visualProps: ['size', 'status']},
],
},
usage: {
@@ -190,6 +190,7 @@ export const docsZh = {
className: 'xds-date-input',
visualProps: [
'size',
+ 'status',
],
},
],
diff --git a/packages/core/src/DateInput/XDSDateInput.tsx b/packages/core/src/DateInput/XDSDateInput.tsx
index 3df7e82173..29afe35019 100644
--- a/packages/core/src/DateInput/XDSDateInput.tsx
+++ b/packages/core/src/DateInput/XDSDateInput.tsx
@@ -496,7 +496,7 @@ export function XDSDateInput({
ref={popover.triggerRef}
{...rest}
{...mergeProps(
- xdsClassName('date-input', {size}),
+ xdsClassName('date-input', {size, status: status?.type ?? null}),
stylex.props(
inputWrapperStyles.base,
sizeStyles[size],
diff --git a/packages/core/src/NumberInput/NumberInput.doc.mjs b/packages/core/src/NumberInput/NumberInput.doc.mjs
index e1852e2bc6..ccd3ec649e 100644
--- a/packages/core/src/NumberInput/NumberInput.doc.mjs
+++ b/packages/core/src/NumberInput/NumberInput.doc.mjs
@@ -151,7 +151,7 @@ export const docs = {
],
theming: {
targets: [
- {className: 'xds-number-input', visualProps: ['size']},
+ {className: 'xds-number-input', visualProps: ['size', 'status']},
],
},
usage: {
@@ -323,7 +323,7 @@ export const docsZh = {
],
theming: {
targets: [
- {className: 'xds-number-input', visualProps: ['size']},
+ {className: 'xds-number-input', visualProps: ['size', 'status']},
],
},
usage: {
diff --git a/packages/core/src/NumberInput/XDSNumberInput.tsx b/packages/core/src/NumberInput/XDSNumberInput.tsx
index 14ffd4ef5d..19577f399c 100644
--- a/packages/core/src/NumberInput/XDSNumberInput.tsx
+++ b/packages/core/src/NumberInput/XDSNumberInput.tsx
@@ -529,7 +529,7 @@ export function XDSNumberInput({
labelTooltip={labelTooltip}>
<div
{...mergeProps(
- xdsClassName('number-input', {size}),
+ xdsClassName('number-input', {size, status: status?.type ?? null}),
stylex.props(
inputWrapperStyles.base,
styles.wrapper,
diff --git a/packages/core/src/TextArea/TextArea.doc.mjs b/packages/core/src/TextArea/TextArea.doc.mjs
index fd46041e6a..f67a52a645 100644
--- a/packages/core/src/TextArea/TextArea.doc.mjs
+++ b/packages/core/src/TextArea/TextArea.doc.mjs
@@ -150,7 +150,7 @@ export const docs = {
],
theming: {
targets: [
- {className: 'xds-textarea'},
+ {className: 'xds-textarea', visualProps: ['status']},
],
},
usage: {
@@ -314,7 +314,7 @@ export const docsZh = {
],
theming: {
targets: [
- {className: 'xds-textarea'},
+ {className: 'xds-textarea', visualProps: ['status']},
],
},
usage: {
diff --git a/packages/core/src/TextArea/XDSTextArea.tsx b/packages/core/src/TextArea/XDSTextArea.tsx
index 66d59aa985..773b9b37b1 100644
--- a/packages/core/src/TextArea/XDSTextArea.tsx
+++ b/packages/core/src/TextArea/XDSTextArea.tsx
@@ -355,7 +355,7 @@ export function XDSTextArea({
labelTooltip={labelTooltip}>
<div
{...mergeProps(
- xdsClassName('textarea'),
+ xdsClassName('textarea', {status: status?.type ?? null}),
stylex.props(
inputWrapperStyles.base,
styles.wrapper,
diff --git a/packages/core/src/TextInput/TextInput.doc.mjs b/packages/core/src/TextInput/TextInput.doc.mjs
index 060621cedb..3e996e473e 100644
--- a/packages/core/src/TextInput/TextInput.doc.mjs
+++ b/packages/core/src/TextInput/TextInput.doc.mjs
@@ -126,7 +126,7 @@ export const docs = {
],
theming: {
targets: [
- {className: 'xds-text-input', visualProps: ['size']},
+ {className: 'xds-text-input', visualProps: ['size', 'status']},
],
},
usage: {
@@ -272,7 +272,7 @@ export const docsZh = {
],
theming: {
targets: [
- {className: 'xds-text-input', visualProps: ['size']},
+ {className: 'xds-text-input', visualProps: ['size', 'status']},
],
},
usage: {
diff --git a/packages/core/src/TextInput/XDSTextInput.tsx b/packages/core/src/TextInput/XDSTextInput.tsx
index e125bab2dd..3b05c9f24b 100644
--- a/packages/core/src/TextInput/XDSTextInput.tsx
+++ b/packages/core/src/TextInput/XDSTextInput.tsx
@@ -345,7 +345,7 @@ export function XDSTextInput({
labelTooltip={labelTooltip}>
<div
{...mergeProps(
- xdsClassName('text-input', {size}),
+ xdsClassName('text-input', {size, status: status?.type ?? null}),
stylex.props(
inputWrapperStyles.base,
styles.wrapper,
diff --git a/packages/core/src/TimeInput/TimeInput.doc.mjs b/packages/core/src/TimeInput/TimeInput.doc.mjs
index 3f4be73d13..133f978205 100644
--- a/packages/core/src/TimeInput/TimeInput.doc.mjs
+++ b/packages/core/src/TimeInput/TimeInput.doc.mjs
@@ -138,7 +138,7 @@ export const docs = {
],
theming: {
targets: [
- {className: 'xds-time-input', visualProps: ['size']},
+ {className: 'xds-time-input', visualProps: ['size', 'status']},
],
},
usage: {
@@ -290,7 +290,7 @@ export const docsZh = {
],
theming: {
targets: [
- {className: 'xds-time-input', visualProps: ['size']},
+ {className: 'xds-time-input', visualProps: ['size', 'status']},
],
},
usage: {
diff --git a/packages/core/src/TimeInput/XDSTimeInput.tsx b/packages/core/src/TimeInput/XDSTimeInput.tsx
index 6ac23b28fb..81ea36ac67 100644
--- a/packages/core/src/TimeInput/XDSTimeInput.tsx
+++ b/packages/core/src/TimeInput/XDSTimeInput.tsx
@@ -535,7 +535,7 @@ export function XDSTimeInput({
labelTooltip={labelTooltip}>
<div
{...mergeProps(
- xdsClassName('time-input', {size}),
+ xdsClassName('time-input', {size, status: status?.type ?? null}),
stylex.props(
inputWrapperStyles.base,
sizeStyles[size],
diff --git a/packages/themes/meta/src/icons.tsx b/packages/themes/meta/src/icons.tsx
index 963ab917de..94f7ec1000 100644
--- a/packages/themes/meta/src/icons.tsx
+++ b/packages/themes/meta/src/icons.tsx
@@ -33,16 +33,13 @@ import {
ClipboardDocumentIcon,
WrenchScrewdriverIcon,
MicrophoneIcon,
-} from '@heroicons/react/24/outline';
-
-import {
CheckCircleIcon,
XCircleIcon,
ExclamationTriangleIcon,
ArrowTopRightOnSquareIcon,
StopIcon,
StopCircleIcon,
-} from '@heroicons/react/24/solid';
+} from '@heroicons/react/24/outline';
const iconProps = {
width: '1em',
diff --git a/packages/themes/meta/src/metaTheme.ts b/packages/themes/meta/src/metaTheme.ts
index e4fe39580b..0ab6207791 100644
--- a/packages/themes/meta/src/metaTheme.ts
+++ b/packages/themes/meta/src/metaTheme.ts
@@ -252,7 +252,7 @@ export const metaTheme = defineTheme({
// =========================================================================
button: {
base: {
- borderRadius: '9999px !important',
+ borderRadius: '9999px',
gap: '4px',
},
'size:sm': {
@@ -266,7 +266,11 @@ export const metaTheme = defineTheme({
},
'variant:primary': {fontWeight: '500'},
'variant:secondary': {fontWeight: '500'},
- 'variant:destructive': {fontWeight: '500'},
+ 'variant:destructive': {
+ backgroundColor: 'light-dark(#D31130, #DA2A3E)',
+ color: '#FFFFFF',
+ fontWeight: '500',
+ },
'variant:ghost': {fontWeight: '500'},
'variant:primary-muted': {
backgroundColor: 'light-dark(#ECF5FF, #182849)',
@@ -342,16 +346,17 @@ export const metaTheme = defineTheme({
// =========================================================================
'text-input': {
base: {
- borderRadius: '8px !important',
- paddingInline: '12px !important',
- paddingBlock: '12px !important',
+ borderRadius: '8px',
+ paddingInline: '12px',
+ paddingBlock: '12px',
minHeight: '44px',
- borderColor: 'light-dark(#CCD3DB, #494D53)',
},
+ 'status:success': {borderColor: '#686A6E'},
+ 'status:warning': {borderColor: '#686A6E'},
'variant:search': {
backgroundColor: 'light-dark(#F3F4F5, #28292C)',
borderColor: 'transparent',
- borderRadius: '9999px !important',
+ borderRadius: '9999px',
},
},
@@ -360,12 +365,12 @@ export const metaTheme = defineTheme({
// =========================================================================
'field-status': {
base: {
- backgroundColor: 'transparent !important',
- marginTop: '4px !important',
- paddingBlockStart: '0 !important',
- paddingBlockEnd: '0 !important',
- paddingInline: '0 !important',
- borderRadius: '0 !important',
+ backgroundColor: 'transparent',
+ marginTop: '4px',
+ paddingBlockStart: '0',
+ paddingBlockEnd: '0',
+ paddingInline: '0',
+ borderRadius: '0',
},
},
@@ -374,9 +379,9 @@ export const metaTheme = defineTheme({
// =========================================================================
selector: {
base: {
- borderRadius: '8px !important',
- paddingInline: '12px !important',
- paddingBlock: '12px !important',
+ borderRadius: '8px',
+ paddingInline: '12px',
+ paddingBlock: '12px',
minHeight: '44px',
},
},
@@ -440,15 +445,19 @@ export const metaTheme = defineTheme({
// =========================================================================
radio: {
base: {
- borderWidth: '1.5px',
+ borderWidth: '2.5px',
'--color-border-emphasized': '#8F9296',
},
+ checked: {
+ backgroundColor: 'var(--color-background-surface)',
+ borderColor: 'var(--color-accent)',
+ },
},
'radio-dot': {
base: {
backgroundColor: 'var(--color-accent)',
- width: '14px',
- height: '14px',
+ width: '12px',
+ height: '12px',
},
},
@@ -539,7 +548,7 @@ export const metaTheme = defineTheme({
popover: {
base: {
borderRadius: '16px',
- padding: '16px !important',
+ padding: '16px',
},
},
'dropdown-menu': {
@@ -551,7 +560,7 @@ export const metaTheme = defineTheme({
'more-menu': {
base: {
borderRadius: '16px',
- padding: '8px !important',
+ padding: '8px',
},
},
tooltip: {
diff --git a/packages/themes/whatsapp/src/whatsappTheme.ts b/packages/themes/whatsapp/src/whatsappTheme.ts
index 385a6964c5..8bbb0fd3cf 100644
--- a/packages/themes/whatsapp/src/whatsappTheme.ts
+++ b/packages/themes/whatsapp/src/whatsappTheme.ts
@@ -47,14 +47,8 @@ export const whatsappTheme = defineTheme({
},
},
- // Radius: WDS scale (0/4/8/12/28/9999) matches XDS defaults exactly.
- // borderRadiusNone=0 → --radius-none=0
- // borderRadiusHalf=4 → --radius-inner=4
- // borderRadiusSingle=8 → --radius-element=8 (inputs, cards)
- // borderRadiusSinglePlus=12 → --radius-container=12
- // borderRadiusTriplePlus=28 → --radius-page=28
- // borderRadiusCircle=9999 → --radius-full=9999 (buttons)
- // No radius override needed — multiplier=1 (default) is correct.
+ // Radius: WhatsApp uses generously rounded surfaces — doubled radius scale.
+ radius: {base: 4, multiplier: 2},
// Motion: WhatsApp feels snappy but not jarring.
// Slightly faster than XDS default, with ease-out for natural deceleration.