An open source design system that's fully customizable and agent ready
TypeScript
fix(core): remove deprecated XDSSelectorItem and internalize XDSSelectorOption (#1582)
Cindy Zhang3ff60a3874eb
diff --git a/apps/storybook/stories/AnalyticsDashboard.stories.tsx b/apps/storybook/stories/AnalyticsDashboard.stories.tsxindex cf26ba358f..548874d492 100644--- a/apps/storybook/stories/AnalyticsDashboard.stories.tsx+++ b/apps/storybook/stories/AnalyticsDashboard.stories.tsx@@ -458,7 +458,7 @@ const componentAdoptionData: ComponentAdoptionRow[] = [},{id: '7',- component: 'XDSSelectorItem',+ component: 'XDSSelectorOption',usages: 57513,files: 19649,oncalls: 50,diff --git a/packages/core/src/Selector/Selector.doc.mjs b/packages/core/src/Selector/Selector.doc.mjsindex 0e76e7fbe9..88d3441427 100644--- a/packages/core/src/Selector/Selector.doc.mjs+++ b/packages/core/src/Selector/Selector.doc.mjs@@ -88,7 +88,7 @@ export const docs = {},{name: 'children',- type: '(item: XDSSelectorItemData) => ReactNode',+ type: '(item: XDSSelectorOptionData) => ReactNode',description: 'Custom render function for each item in the dropdown.',},{@@ -100,7 +100,7 @@ export const docs = {],},{- name: 'XDSSelectorItem',+ name: 'XDSSelectorOption',description:'Helper component for custom item rendering inside an XDSSelector children render prop.',props: [@@ -230,7 +230,7 @@ export const docsZh = {},{name: 'children',- type: '(item: XDSSelectorItemData) => ReactNode',+ type: '(item: XDSSelectorOptionData) => ReactNode',description: '下拉菜单中每个选项的自定义渲染函数。',},{@@ -242,7 +242,7 @@ export const docsZh = {],},{- name: 'XDSSelectorItem',+ name: 'XDSSelectorOption',description:'用于在 XDSSelector 的 children 渲染函数中自定义选项渲染的辅助组件。',props: [@@ -328,7 +328,7 @@ export const docsDense = {},},{- name: 'XDSSelectorItem',+ name: 'XDSSelectorOption',description:'Helper component for custom item rendering inside XDSSelector children render prop.',propDescriptions: {diff --git a/packages/core/src/Selector/XDSSelectorItem.tsx b/packages/core/src/Selector/XDSSelectorItem.tsxdeleted file mode 100644index d20481ff73..0000000000--- a/packages/core/src/Selector/XDSSelectorItem.tsx+++ /dev/null@@ -1,10 +0,0 @@-/**- * @file XDSSelectorItem.tsx- * @deprecated Use XDSSelectorOption from './XDSSelectorOption' instead- * @output Re-exports XDSSelectorOption as XDSSelectorItem for backward compatibility- */--export {- XDSSelectorOption as XDSSelectorItem,- type XDSSelectorOptionProps as XDSSelectorItemProps,-} from './XDSSelectorOption';diff --git a/packages/core/src/Selector/XDSSelectorOption.tsx b/packages/core/src/Selector/XDSSelectorOption.tsxindex 0f1441f7e6..1c60ca6b81 100644--- a/packages/core/src/Selector/XDSSelectorOption.tsx+++ b/packages/core/src/Selector/XDSSelectorOption.tsx@@ -134,8 +134,3 @@ export function XDSSelectorOption({}XDSSelectorOption.displayName = 'XDSSelectorOption';--/**- * @deprecated Use XDSSelectorOption instead (renamed from XDSSelectorItem)- */-export const XDSSelectorItem = XDSSelectorOption;diff --git a/packages/core/src/Selector/index.ts b/packages/core/src/Selector/index.tsindex 8871a14a7f..ed91c89130 100644--- a/packages/core/src/Selector/index.ts+++ b/packages/core/src/Selector/index.ts@@ -13,10 +13,7 @@ export {type XDSSelectorStatus,type XDSSelectorStatusType,} from './XDSSelector';-export {- XDSSelectorOption,- type XDSSelectorOptionProps,-} from './XDSSelectorOption';+export {XDSSelectorOption} from './XDSSelectorOption';export type {XDSSelectorOptionType,XDSSelectorOptionData,@@ -31,11 +28,3 @@ export {getSelectableOptions,} from './utils';export {useCombobox, useSelectedItemOffset} from './hooks';--// Backward compatibility — deprecated exports-export {XDSSelectorItem, type XDSSelectorItemProps} from './XDSSelectorItem';-export type {- XDSSelectorOption as XDSSelectorOptionLegacy,- XDSSelectorItemData,-} from './types';-export {isItemData, normalizeItem, getSelectableItems} from './utils';diff --git a/packages/core/src/Selector/types.ts b/packages/core/src/Selector/types.tsindex 1a3029df9e..2043857da6 100644--- a/packages/core/src/Selector/types.ts+++ b/packages/core/src/Selector/types.ts@@ -41,13 +41,3 @@ export type XDSSelectorOptionType =| XDSSelectorOptionData| XDSSelectorDivider| XDSSelectorSection;--/**- * @deprecated Use XDSSelectorOptionType instead- */-export type XDSSelectorOption = XDSSelectorOptionType;--/**- * @deprecated Use XDSSelectorOptionData instead- */-export type XDSSelectorItemData = XDSSelectorOptionData;diff --git a/packages/core/src/Selector/utils.ts b/packages/core/src/Selector/utils.tsindex 5aaa79b99b..146f940c6c 100644--- a/packages/core/src/Selector/utils.ts+++ b/packages/core/src/Selector/utils.ts@@ -79,18 +79,3 @@ export function getSelectableOptions(return result;}--/**- * @deprecated Use isOptionData instead- */-export const isItemData = isOptionData;--/**- * @deprecated Use normalizeOption instead- */-export const normalizeItem = normalizeOption;--/**- * @deprecated Use getSelectableOptions instead- */-export const getSelectableItems = getSelectableOptions;