Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

test(Layer): the late-registration cases load their modules once (#10759)

Christopher Chedeau41e0de2e0e45
diff --git a/packages/core/src/Layer/toastHost.lateRegistration.test.tsx b/packages/core/src/Layer/toastHost.lateRegistration.test.tsx
index e9a2306fda..b1254496f1 100644
--- a/packages/core/src/Layer/toastHost.lateRegistration.test.tsx
+++ b/packages/core/src/Layer/toastHost.lateRegistration.test.tsx
@@ -2,8 +2,8 @@
/**
* @file toastHost.lateRegistration.test.tsx
- * @input LayerProvider and its toast context, with ToastViewport imported
- * only inside a test
+ * @input LayerProvider and its toast context, with ToastViewport loaded once
+ * at collection and reloaded fresh inside each test
* @output Proves LayerProvider alone renders no viewport, that a toast added
* before Toast loads shows once it loads, and that the app stays mounted.
* A waiting toast that is removed reports onHide once and never shows. A
@@ -14,13 +14,34 @@
import {act, render, screen} from '@testing-library/react';
import {use, useEffect} from 'react';
-import {beforeEach, describe, expect, it, vi} from 'vitest';
+import {afterEach, beforeEach, describe, expect, it, vi} from 'vitest';
import type {ToastEntry} from '../Toast/types';
+// The modules load once while the file is collected, which no timeout bounds.
+// Each test then reloads them from code that is already transformed. So a
+// cold transform on a busy machine never runs inside a timed test.
+await import('./LayerProvider');
+await import('../Toast/ToastViewport');
+
+// A test that ends before its viewport import settles, such as one that times
+// out, would register that viewport in the next test's modules. So each
+// test's import settles before the modules reload.
+let viewportLoad: Promise<unknown> | null = null;
+
+async function loadViewport() {
+ viewportLoad = import('../Toast/ToastViewport');
+ await viewportLoad;
+}
+
beforeEach(() => {
vi.resetModules();
});
+afterEach(async () => {
+ await viewportLoad?.catch(() => {});
+ viewportLoad = null;
+});
+
async function loadLayer() {
const {LayerProvider} = await import('./LayerProvider');
const {ToastContext} = await import('./toastHost');
@@ -67,7 +88,7 @@ describe('LayerProvider before Toast is imported', () => {
const app = view.getByText('App');
expect(screen.queryByText('Saved before the viewport')).toBeNull();
await act(async () => {
- await import('../Toast/ToastViewport');
+ await loadViewport();
});
expect(
await screen.findByText('Saved before the viewport'),
@@ -101,7 +122,7 @@ describe('LayerProvider before Toast is imported', () => {
expect(found?.id).toBe('second');
expect(onHide.mock.calls).toEqual([['manual']]);
await act(async () => {
- await import('../Toast/ToastViewport');
+ await loadViewport();
});
expect(await screen.findByText('Kept while waiting')).toBeInTheDocument();
expect(screen.queryByText('Removed while waiting')).toBeNull();
@@ -127,7 +148,7 @@ describe('LayerProvider before Toast is imported', () => {
</LayerProvider>,
);
await act(async () => {
- await import('../Toast/ToastViewport');
+ await loadViewport();
});
expect(await screen.findByText('Its namesake')).toBeInTheDocument();
expect(screen.queryByText('Replaced while waiting')).toBeNull();
@@ -158,7 +179,7 @@ describe('LayerProvider before Toast is imported', () => {
</LayerProvider>,
);
await act(async () => {
- await import('../Toast/ToastViewport');
+ await loadViewport();
});
expect(await screen.findByText('Shown first')).toBeInTheDocument();
expect(screen.queryByText('Ignored namesake')).toBeNull();