Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

feat(vibe-tests): per-prompt code viewer and report refinements (#271)

Cindy Zhang4ad2b37595ec
diff --git a/internal/vibe-tests/app/index.html b/internal/vibe-tests/app/index.html
index ea2fa262ec..a2730bbd84 100644
--- a/internal/vibe-tests/app/index.html
+++ b/internal/vibe-tests/app/index.html
@@ -5,18 +5,6 @@
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>XDS Vibe Tests</title>
<style>
- /* CSS Reset for consistent screenshots */
- *, *::before, *::after {
- box-sizing: border-box;
- margin: 0;
- padding: 0;
- }
- html, body {
- height: 100%;
- font-family: system-ui, -apple-system, sans-serif;
- -webkit-font-smoothing: antialiased;
- -moz-osx-font-smoothing: grayscale;
- }
#root {
min-height: 100%;
}
diff --git a/internal/vibe-tests/app/src/main.tsx b/internal/vibe-tests/app/src/main.tsx
index b20b578b8c..39c9bf0710 100644
--- a/internal/vibe-tests/app/src/main.tsx
+++ b/internal/vibe-tests/app/src/main.tsx
@@ -1,5 +1,6 @@
import React, {Suspense, lazy} from 'react';
import {createRoot} from 'react-dom/client';
+import '@xds/core/reset.css';
const params = new URLSearchParams(window.location.search);
const mode = params.get('mode') ?? 'report';
diff --git a/internal/vibe-tests/app/src/report/CodeModal.tsx b/internal/vibe-tests/app/src/report/CodeModal.tsx
new file mode 100644
index 0000000000..b4825af601
--- /dev/null
+++ b/internal/vibe-tests/app/src/report/CodeModal.tsx
@@ -0,0 +1,73 @@
+import * as stylex from '@stylexjs/stylex';
+import {XDSDialog} from '@xds/core/Dialog';
+import {XDSVStack} from '@xds/core/Stack';
+import {XDSText} from '@xds/core/Text';
+import {XDSHeading} from '@xds/core/Text';
+import {XDSCloseButton} from '@xds/core/CloseButton';
+import {spacingVars, colorVars} from '@xds/core/theme/tokens.stylex';
+
+const styles = stylex.create({
+ header: {
+ padding: spacingVars['--spacing-4'],
+ display: 'flex',
+ justifyContent: 'space-between',
+ alignItems: 'flex-start',
+ },
+ content: {
+ padding: spacingVars['--spacing-4'],
+ paddingBlockStart: 0,
+ },
+ codeBlock: {
+ fontFamily: 'ui-monospace, "SF Mono", Menlo, monospace',
+ fontSize: '13px',
+ lineHeight: '1.5',
+ backgroundColor: colorVars['--color-wash'],
+ borderRadius: '6px',
+ padding: spacingVars['--spacing-3'],
+ overflow: 'auto',
+ maxHeight: '70vh',
+ whiteSpace: 'pre',
+ tabSize: 2,
+ },
+});
+
+interface CodeModalProps {
+ isShown: boolean;
+ onHide: () => void;
+ promptId: string;
+ target: 'xds' | 'baseline';
+ code: string;
+}
+
+export function CodeModal({
+ isShown,
+ onHide,
+ promptId,
+ target,
+ code,
+}: CodeModalProps) {
+ const targetLabel = target === 'xds' ? 'XDS' : 'Baseline';
+ const lineCount = code.split('\n').length;
+
+ return (
+ <XDSDialog
+ isShown={isShown}
+ onHide={onHide}
+ purpose="info"
+ width={800}
+ aria-label={`${targetLabel} code for ${promptId}`}>
+ <div {...stylex.props(styles.header)}>
+ <XDSVStack gap="space1">
+ <XDSHeading level={3}>
+ {promptId} — {targetLabel}
+ </XDSHeading>
+ <XDSText type="supporting">{lineCount} lines</XDSText>
+ </XDSVStack>
+ <XDSCloseButton onClick={onHide} />
+ </div>
+ <div {...stylex.props(styles.content)}>
+ <div {...stylex.props(styles.codeBlock)}>{code}</div>
+ </div>
+ </XDSDialog>
+ );
+}
diff --git a/internal/vibe-tests/app/src/report/CompareView.tsx b/internal/vibe-tests/app/src/report/CompareView.tsx
index 30edd68511..875a1a30c6 100644
--- a/internal/vibe-tests/app/src/report/CompareView.tsx
+++ b/internal/vibe-tests/app/src/report/CompareView.tsx
@@ -1,7 +1,6 @@
import * as stylex from '@stylexjs/stylex';
import {XDSCard} from '@xds/core/Card';
import {XDSVStack} from '@xds/core/Stack';
-import {XDSHStack} from '@xds/core/Stack';
import {XDSText} from '@xds/core/Text';
import {XDSHeading} from '@xds/core/Text';
import {XDSBadge} from '@xds/core/Badge';
diff --git a/internal/vibe-tests/app/src/report/DimensionTable.tsx b/internal/vibe-tests/app/src/report/DimensionTable.tsx
index 2a15f7fabb..f4008e8cbc 100644
--- a/internal/vibe-tests/app/src/report/DimensionTable.tsx
+++ b/internal/vibe-tests/app/src/report/DimensionTable.tsx
@@ -14,13 +14,11 @@ import {
interface DimensionTableProps {
byPrompt: Record<string, UniversalScore>;
- categories?: Record<string, string>;
}
interface RowData extends Record<string, unknown> {
id: string;
promptId: string;
- category: string;
correctness: number;
accessibility: number;
codeQuality: number;
@@ -42,11 +40,10 @@ function ScoreCell({score}: {score: number}) {
);
}
-export function DimensionTable({byPrompt, categories}: DimensionTableProps) {
+export function DimensionTable({byPrompt}: DimensionTableProps) {
const data: RowData[] = Object.entries(byPrompt).map(([promptId, score]) => ({
id: promptId,
promptId,
- category: categories?.[promptId] ?? '—',
correctness: score.correctness.score,
accessibility: score.accessibility.score,
codeQuality: score.codeQuality.score,
@@ -56,8 +53,11 @@ export function DimensionTable({byPrompt, categories}: DimensionTableProps) {
}));
const columns: XDSTableColumn<RowData>[] = [
- {key: 'promptId', header: 'Prompt'},
- {key: 'category', header: 'Category'},
+ {
+ key: 'promptId',
+ header: 'Prompt',
+ renderCell: row => <XDSText type="body">{row.promptId}</XDSText>,
+ },
...ALL_DIMENSIONS.map(
(dim): XDSTableColumn<RowData> => ({
key: dim,
diff --git a/internal/vibe-tests/app/src/report/PromptDetailCard.tsx b/internal/vibe-tests/app/src/report/PromptDetailCard.tsx
new file mode 100644
index 0000000000..479641a362
--- /dev/null
+++ b/internal/vibe-tests/app/src/report/PromptDetailCard.tsx
@@ -0,0 +1,232 @@
+import * as stylex from '@stylexjs/stylex';
+import {XDSCard} from '@xds/core/Card';
+import {XDSVStack} from '@xds/core/Stack';
+import {XDSText} from '@xds/core/Text';
+import {XDSHeading} from '@xds/core/Text';
+import {XDSStatusDot} from '@xds/core/StatusDot';
+import {XDSBadge} from '@xds/core/Badge';
+import {XDSButton} from '@xds/core/Button';
+import {XDSDivider} from '@xds/core/Divider';
+import {spacingVars} from '@xds/core/theme/tokens.stylex';
+import type {UniversalScore} from './types';
+import {
+ ALL_DIMENSIONS,
+ DIMENSION_LABELS,
+ computeOverall,
+ scoreToStatusVariant,
+} from './utils';
+
+const styles = stylex.create({
+ card: {
+ padding: spacingVars['--spacing-4'],
+ },
+ header: {
+ display: 'flex',
+ flexDirection: 'column',
+ gap: spacingVars['--spacing-2'],
+ },
+ scoreGrid: {
+ display: 'grid',
+ gridTemplateColumns: 'repeat(3, 1fr)',
+ gap: spacingVars['--spacing-2'],
+ },
+ scoreItem: {
+ display: 'flex',
+ alignItems: 'center',
+ gap: spacingVars['--spacing-1'],
+ whiteSpace: 'nowrap',
+ },
+ scoresRow: {
+ display: 'grid',
+ gridTemplateColumns: '1fr 1fr',
+ gap: spacingVars['--spacing-3'],
+ },
+ scoresRowSingle: {
+ display: 'grid',
+ gridTemplateColumns: '1fr',
+ gap: spacingVars['--spacing-3'],
+ },
+ scoreBlock: {
+ minWidth: 0,
+ overflow: 'hidden',
+ },
+ findingsGrid: {
+ display: 'grid',
+ gridTemplateColumns: 'auto 1fr',
+ gap: `${spacingVars['--spacing-1']} ${spacingVars['--spacing-2']}`,
+ alignItems: 'baseline',
+ },
+ section: {
+ paddingBlockStart: spacingVars['--spacing-2'],
+ },
+ sectionLabel: {
+ paddingBlockEnd: spacingVars['--spacing-1'],
+ },
+ buttonRow: {
+ display: 'flex',
+ gap: spacingVars['--spacing-2'],
+ flexWrap: 'wrap',
+ },
+});
+
+function ScoreItem({label, score}: {label: string; score: number}) {
+ return (
+ <div {...stylex.props(styles.scoreItem)}>
+ <XDSStatusDot
+ variant={scoreToStatusVariant(score)}
+ label={`${label}: ${score}`}
+ size="sm"
+ />
+ <XDSText type="supporting">
+ {label} {score}
+ </XDSText>
+ </div>
+ );
+}
+
+function ScoreSummary({label, score}: {label: string; score: UniversalScore}) {
+ return (
+ <div {...stylex.props(styles.scoreBlock)}>
+ <XDSVStack gap="space2">
+ <XDSText type="label">{label}</XDSText>
+ <div {...stylex.props(styles.scoreGrid)}>
+ {ALL_DIMENSIONS.map(dim => (
+ <ScoreItem
+ key={dim}
+ label={DIMENSION_LABELS[dim]}
+ score={score[dim].score}
+ />
+ ))}
+ <ScoreItem label="Overall" score={computeOverall(score)} />
+ </div>
+ </XDSVStack>
+ </div>
+ );
+}
+
+function Findings({score}: {score: UniversalScore}) {
+ const allFindings = ALL_DIMENSIONS.flatMap(dim =>
+ (score[dim].findings ?? []).map(f => ({
+ dimension: DIMENSION_LABELS[dim],
+ ...f,
+ })),
+ );
+
+ if (allFindings.length === 0) {
+ return <XDSText type="supporting">No issues found.</XDSText>;
+ }
+
+ return (
+ <div {...stylex.props(styles.findingsGrid)}>
+ {allFindings.map((f, i) => (
+ <>
+ <XDSBadge
+ key={`badge-${i}`}
+ variant={
+ f.severity === 'critical'
+ ? 'error'
+ : f.severity === 'moderate'
+ ? 'warning'
+ : 'neutral'
+ }>
+ {f.severity ?? 'info'}
+ </XDSBadge>
+ <XDSText key={`text-${i}`} type="body">
+ <strong>{f.dimension}</strong> — {f.detail}
+ </XDSText>
+ </>
+ ))}
+ </div>
+ );
+}
+
+interface PromptDetailCardProps {
+ promptId: string;
+ xdsScore?: UniversalScore;
+ baselineScore?: UniversalScore;
+ hasXdsCode: boolean;
+ hasBaselineCode: boolean;
+ onViewCode: (target: 'xds' | 'baseline') => void;
+}
+
+export function PromptDetailCard({
+ promptId,
+ xdsScore,
+ baselineScore,
+ hasXdsCode,
+ hasBaselineCode,
+ onViewCode,
+}: PromptDetailCardProps) {
+ const hasBoth = !!(xdsScore && baselineScore);
+
+ return (
+ <XDSCard>
+ <div {...stylex.props(styles.card)}>
+ <XDSVStack gap="space3">
+ {/* Header: prompt ID on its own line, buttons below */}
+ <div {...stylex.props(styles.header)}>
+ <XDSHeading level={4}>{promptId}</XDSHeading>
+ {(hasXdsCode || hasBaselineCode) && (
+ <div {...stylex.props(styles.buttonRow)}>
+ {hasXdsCode && (
+ <XDSButton
+ variant="secondary"
+ size="sm"
+ onClick={() => onViewCode('xds')}>
+ View XDS Code
+ </XDSButton>
+ )}
+ {hasBaselineCode && (
+ <XDSButton
+ variant="secondary"
+ size="sm"
+ onClick={() => onViewCode('baseline')}>
+ View Baseline Code
+ </XDSButton>
+ )}
+ </div>
+ )}
+ </div>
+
+ {/* Score summaries in constrained grid */}
+ {(xdsScore || baselineScore) && (
+ <div
+ {...stylex.props(
+ hasBoth ? styles.scoresRow : styles.scoresRowSingle,
+ )}>
+ {xdsScore && <ScoreSummary label="XDS" score={xdsScore} />}
+ {baselineScore && (
+ <ScoreSummary label="Baseline" score={baselineScore} />
+ )}
+ </div>
+ )}
+
+ {/* Findings */}
+ {xdsScore && (
+ <>
+ <XDSDivider />
+ <div {...stylex.props(styles.section)}>
+ <div {...stylex.props(styles.sectionLabel)}>
+ <XDSText type="label">XDS Findings</XDSText>
+ </div>
+ <Findings score={xdsScore} />
+ </div>
+ </>
+ )}
+
+ {baselineScore && (
+ <>
+ <XDSDivider />
+ <div {...stylex.props(styles.section)}>
+ <div {...stylex.props(styles.sectionLabel)}>
+ <XDSText type="label">Baseline Findings</XDSText>
+ </div>
+ <Findings score={baselineScore} />
+ </div>
+ </>
+ )}
+ </XDSVStack>
+ </div>
+ </XDSCard>
+ );
+}
diff --git a/internal/vibe-tests/app/src/report/Report.tsx b/internal/vibe-tests/app/src/report/Report.tsx
index 9baa64898d..8c58c70224 100644
--- a/internal/vibe-tests/app/src/report/Report.tsx
+++ b/internal/vibe-tests/app/src/report/Report.tsx
@@ -15,6 +15,8 @@ import type {ReportData} from './types';
import {ALL_DIMENSIONS, DIMENSION_LABELS} from './utils';
import {ScoreCard} from './ScoreCard';
import {DimensionTable} from './DimensionTable';
+import {PromptDetailCard} from './PromptDetailCard';
+import {CodeModal} from './CodeModal';
import {CompareView} from './CompareView';
import {ScreenshotGallery} from './ScreenshotGallery';
@@ -194,6 +196,10 @@ function CostMetricsCard({cost}: {cost: ReportData['universal']['cost']}) {
export function Report() {
const [themeMode, setThemeMode] = useState<'light' | 'dark'>('light');
const [activeTab, setActiveTab] = useState('overview');
+ const [codeModal, setCodeModal] = useState<{
+ promptId: string;
+ target: 'xds' | 'baseline';
+ } | null>(null);
const data: ReportData | undefined = window.__REPORT_DATA__;
@@ -306,9 +312,45 @@ export function Report() {
)}
{activeTab === 'byPrompt' && (
- <DimensionTable byPrompt={universal.byPrompt} />
+ <XDSVStack gap="space4">
+ <DimensionTable byPrompt={universal.byPrompt} />
+
+ {/* Per-prompt detail cards */}
+ <XDSVStack gap="space3">
+ <XDSHeading level={3}>Prompt Details</XDSHeading>
+ {Object.keys(universal.byPrompt).map(promptId => (
+ <PromptDetailCard
+ key={promptId}
+ promptId={promptId}
+ xdsScore={universal.byPrompt[promptId]}
+ baselineScore={comparison?.baseline.byPrompt[promptId]}
+ hasXdsCode={!!data.sourceCode?.[promptId]}
+ hasBaselineCode={!!data.baselineSourceCode?.[promptId]}
+ onViewCode={target => setCodeModal({promptId, target})}
+ />
+ ))}
+ </XDSVStack>
+ </XDSVStack>
)}
+ {/* Code modal */}
+ {codeModal &&
+ (() => {
+ const code =
+ codeModal.target === 'xds'
+ ? data.sourceCode?.[codeModal.promptId]
+ : data.baselineSourceCode?.[codeModal.promptId];
+ return code ? (
+ <CodeModal
+ isShown
+ onHide={() => setCodeModal(null)}
+ promptId={codeModal.promptId}
+ target={codeModal.target}
+ code={code}
+ />
+ ) : null;
+ })()}
+
{activeTab === 'screenshots' && screenshots && (
<ScreenshotGallery screenshots={screenshots} />
)}
diff --git a/internal/vibe-tests/app/src/report/types.ts b/internal/vibe-tests/app/src/report/types.ts
index e6e3d48bfd..a892ce332f 100644
--- a/internal/vibe-tests/app/src/report/types.ts
+++ b/internal/vibe-tests/app/src/report/types.ts
@@ -26,6 +26,8 @@ export interface ReportData {
universal: UniversalAggregate;
comparison?: UniversalComparison;
screenshots?: Record<string, string>;
+ sourceCode?: Record<string, string>;
+ baselineSourceCode?: Record<string, string>;
iterationId?: string;
target?: string;
}
diff --git a/internal/vibe-tests/src/build-report.ts b/internal/vibe-tests/src/build-report.ts
index 19c7819532..ef6f9f29fe 100644
--- a/internal/vibe-tests/src/build-report.ts
+++ b/internal/vibe-tests/src/build-report.ts
@@ -104,12 +104,16 @@ function buildDataScript(opts: {
baseline?: string;
comparison?: UniversalComparison;
manifest: unknown;
+ sourceCode?: Record<string, string>;
+ baselineSourceCode?: Record<string, string>;
}): string {
const reportData = {
universal: opts.iterationData,
comparison: opts.comparison ?? undefined,
iterationId: opts.iteration,
target: (opts.manifest as {config?: {target?: string}})?.config?.target,
+ sourceCode: opts.sourceCode,
+ baselineSourceCode: opts.baselineSourceCode,
};
return `<script>window.__REPORT_DATA__=${JSON.stringify(reportData)};</script>`;
@@ -176,18 +180,49 @@ async function main() {
comparison = ensureComparison(iteration, baseline);
}
- // Step 3: Build the data script
+ // Step 3: Load source code for per-prompt inspection
console.log('📝 Step 3: Preparing report data...');
+ const sourceCode: Record<string, string> = {};
+ const codeDir = path.join(iterDir, 'results');
+ if (fs.existsSync(codeDir)) {
+ for (const file of fs
+ .readdirSync(codeDir)
+ .filter(f => f.endsWith('.tsx'))) {
+ const promptId = path.basename(file, '.tsx');
+ sourceCode[promptId] = fs.readFileSync(path.join(codeDir, file), 'utf-8');
+ }
+ }
+
+ let baselineSourceCode: Record<string, string> | undefined;
+ if (baseline) {
+ baselineSourceCode = {};
+ const baseCodeDir = path.join(resultsDir, baseline, 'results');
+ if (fs.existsSync(baseCodeDir)) {
+ for (const file of fs
+ .readdirSync(baseCodeDir)
+ .filter(f => f.endsWith('.tsx'))) {
+ const promptId = path.basename(file, '.tsx');
+ baselineSourceCode[promptId] = fs.readFileSync(
+ path.join(baseCodeDir, file),
+ 'utf-8',
+ );
+ }
+ }
+ }
+
+ // Step 4: Build the data script
const dataScript = buildDataScript({
iteration,
iterationData,
baseline,
comparison,
manifest,
+ sourceCode,
+ baselineSourceCode,
});
console.log(` ✓ ${(dataScript.length / 1024).toFixed(0)} KB of report data`);
- // Step 4: Dev mode or build
+ // Step 5: Dev mode or build
if (dev) {
// For dev mode, write data to a module file so Vite can serve it
const dataDir = path.join(APP_DIR, 'src', 'data');
@@ -214,7 +249,7 @@ async function main() {
console.log('\nOpen http://localhost:5173?mode=report to view the report.');
console.log('Press Ctrl+C to stop.\n');
} else {
- console.log('\n🏗️ Step 4: Building static report...');
+ console.log('\n🏗️ Step 5: Building static report...');
execSync('npx vite build', {
cwd: APP_DIR,
stdio: 'inherit',
@@ -224,7 +259,7 @@ async function main() {
const distDir = path.join(APP_DIR, 'dist');
const reportHtml = path.join(distDir, 'index.html');
if (fs.existsSync(reportHtml)) {
- console.log('💉 Step 5: Injecting report data and styles...');
+ console.log('💉 Step 6: Injecting report data and styles...');
injectDataIntoHtml(reportHtml, dataScript);
inlineCss(reportHtml, distDir);
diff --git a/internal/vibe-tests/src/universal-eval.ts b/internal/vibe-tests/src/universal-eval.ts
index 3a57be94da..c960b32411 100644
--- a/internal/vibe-tests/src/universal-eval.ts
+++ b/internal/vibe-tests/src/universal-eval.ts
@@ -22,6 +22,9 @@ import type {
MaintainabilityMetrics,
} from './types.js';
+import * as _fs from 'node:fs';
+import * as _path from 'node:path';
+
function clamp(n: number): number {
return Math.max(0, Math.min(100, Math.round(n)));
}
@@ -36,25 +39,21 @@ function clamp(n: number): number {
*/
function discoverXDSComponents(): Set<string> {
try {
- // eslint-disable-next-line @typescript-eslint/no-require-imports
- const fs = require('node:fs');
- // eslint-disable-next-line @typescript-eslint/no-require-imports
- const path = require('node:path');
const candidates = [
- path.resolve(import.meta.dirname, '../../../packages/core/src'),
- path.resolve(import.meta.dirname, '../../../../packages/core/src'),
+ _path.resolve(import.meta.dirname, '../../../packages/core/src'),
+ _path.resolve(import.meta.dirname, '../../../../packages/core/src'),
];
for (const srcDir of candidates) {
- if (fs.existsSync(srcDir)) {
+ if (_fs.existsSync(srcDir)) {
const components = new Set<string>();
function scan(dir: string) {
- for (const entry of fs.readdirSync(dir, {withFileTypes: true})) {
+ for (const entry of _fs.readdirSync(dir, {withFileTypes: true})) {
if (
entry.isDirectory() &&
!entry.name.startsWith('_') &&
entry.name !== 'node_modules'
) {
- scan(path.join(dir, entry.name));
+ scan(_path.join(dir, entry.name));
} else if (
/^XDS[A-Z]\w+\.tsx$/.test(entry.name) &&
!entry.name.includes('.test.')