An open source design system that's fully customizable and agent ready
TypeScript
perf(ci): key sandbox next cache by PR to stop cross-basepath invalidation (#3864)
sangwook52d7c5f4677b
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.ymlindex 4073b9cbf4..6774329653 100644--- a/.github/workflows/ci.yml+++ b/.github/workflows/ci.yml@@ -298,7 +298,18 @@ jobs:# so a loose fallback can restore a cache built against a different# export shape and silently produce wrong builds (broke #2941's# post-merge deploy). A changed key yields a cold (safe) rebuild.- key: nextjs-sandbox-${{ hashFiles('pnpm-lock.yaml') }}-${{ hashFiles('packages/core/dist/**') }}+ #+ # Keyed by PR number so PRs never share a cache with main (deploy.yml)+ # or with other PRs: each PR builds with its own basePath+ # (SANDBOX_BASE_PATH=/<repo>/pr/<n>/sandbox vs /<repo>/sandbox on main),+ # and Next.js invalidates the webpack cache whenever the resolved config+ # changes — so a cache built under a different basePath always restores+ # as dead weight (download cost, zero reuse) and, because the shared key+ # "hit", the PR could never save a cache for its own basePath either.+ # Re-pushes to the same PR keep the same key and get real warm builds.+ # (This job only runs on pull_request events — see the job-level `if:`+ # above — so github.event.pull_request.number is always set here.)+ key: nextjs-sandbox-pr${{ github.event.pull_request.number }}-${{ hashFiles('pnpm-lock.yaml') }}-${{ hashFiles('packages/core/dist/**') }}- name: Build Sandboxrun: pnpm -F @astryxdesign/sandbox builddiff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.ymlindex ce79e6b73b..98d8ac5c62 100644--- a/.github/workflows/deploy.yml+++ b/.github/workflows/deploy.yml@@ -126,6 +126,11 @@ jobs:# "Element type is invalid ... undefined" prerender failures.# A changed key now yields a COLD cache (safe rebuild) instead of a# poisoned warm one.+ #+ # PR builds (ci.yml) deliberately use a different, PR-scoped key:+ # they build with a per-PR basePath (/<repo>/pr/<n>/sandbox), and a+ # basePath change makes Next.js invalidate the webpack cache — so a+ # cache shared with this main build would never actually warm a PR.key: nextjs-sandbox-${{ hashFiles('pnpm-lock.yaml') }}-${{ hashFiles('packages/core/dist/**') }}- name: Build Sandbox